MP 1.6: Lockup after GUI Notify is shown in Music/TV (1 Viewer)

[CypherMK]

Hi @ltfearme

I ran into this issue while running this skin on the 1.60 pre release test build. When there is a confirmation dialog on screen, with an OK button in it, and when it disappears automatically, MP isn't controllable anymore. Only ALT+F4 is working

Steps to reproduce:
Scenario 1:
Start music
go to now playing
press F9
select good or bad (lastFM rating, see screenshots)
confirmation of selection comes up (see screenshot)
After that I can stop music, but I cannot use MP anymore, it becomes unresponsive, no button works (but I do hear the clicking sound being played)

Scenario 2:
Start a TV recording
When recording ends, a confirmation will come on screen
after this same issue as above

Tried to reproduce with avallanche, oneportal, and titan skins. But no issue in there.

Can you confirm and fix Thx!

 

[HomeY]

Steps to reproduce:
Scenario 1:
Start music
go to now playing
press F9
select good or bad (lastFM rating, see screenshots)
confirmation of selection comes up (see screenshot)
After that I can stop music, but I cannot use MP anymore, it becomes unresponsive, no button works (but I do hear the clicking sound being played)

I am able to reproduce this issue, but not always and not on every system. It does indeed freeze most of the time on my testsystem (master + SMP), but on HTPC (custom fork) it is working properly. @Sebastiii any clues?

 

[CypherMK]

Is it because of the Ok button in the confirmation dialog? Other skins I tested don't have this Ok button.

 

[HomeY]

Is it because of the Ok button in the confirmation dialog? Other skins I tested don't have this Ok button.

That's what i was thinking also, since SMP has the button and Titan shows the Last.fm image.

 

[CypherMK]

I guess if this Ok button is removed all will be fine!

 

[HomeY]

I guess if this Ok button is removed all will be fine!

Not so sure if that's the problem, because i don't have the freeze or crash on my HTPC, and that runs on current master (+ some extra's) also.

 

[CypherMK]

Some extra info. I can also see in my iMon display that I have to press the Ok button. Even if the message has disappeared on screen.

 

[HomeY]

Tried to debug this but didn't succeed. What i did find out is that if freezes on GUIDialogNotify.cs @ line 98:

[2013-11-17 12:00:59,144] [Log    ] [MPMain   ] [ERROR] - Exception: System.NullReferenceException: Object reference not set to an instance of an object.
   at MediaPortal.Dialogs.GUIDialogNotify.OnMessage(GUIMessage message) in e:\GITsource\MediaPortal-1\mediaportal\Dialogs\Dialogs\GUIDialogNotify.cs:line 98

So since Titan doesn't crash, i looked into the differences, and it seems StreamedMP is targeting another id/xml.
Titan does:

[2013-11-17 13:36:28,744] [Log    ] [MPMain   ] [DEBUG] - WindowManager: unroute to MediaPortal.Dialogs.GUIDialogMenu:2012->MediaPortal.GUI.Music.GUIMusicPlayingNow:510
[2013-11-17 13:36:28,919] [Log    ] [MPMain   ] [DEBUG] - WindowManager: route MediaPortal.GUI.Music.GUIMusicPlayingNow:510->MediaPortal.Dialogs.GUIDialogNotifyLastFM:512
[2013-11-17 13:36:28,920] [Log    ] [MPMain   ] [DEBUG] - DialogWindow: MediaPortal.Dialogs.GUIDialogNotifyLastFM init
[2013-11-17 13:36:30,956] [Log    ] [MPMain   ] [DEBUG] - WindowManager: unroute to MediaPortal.Dialogs.GUIDialogNotifyLastFM:512->MediaPortal.GUI.Music.GUIMusicPlayingNow:510

StreamedMP does:

[2013-11-17 13:33:44,496] [Log    ] [MPMain   ] [DEBUG] - WindowManager: unroute to MediaPortal.Dialogs.GUIDialogMenu:2012->MediaPortal.GUI.Music.GUIMusicPlayingNow:510
[2013-11-17 13:33:44,976] [Log    ] [MPMain   ] [DEBUG] - WindowManager: route MediaPortal.GUI.Music.GUIMusicPlayingNow:510->MediaPortal.Dialogs.GUIDialogNotify:2016
[2013-11-17 13:33:44,981] [Log    ] [MPMain   ] [DEBUG] - DialogWindow: MediaPortal.Dialogs.GUIDialogNotifyLastFM init
[2013-11-17 13:33:47,675] [Log    ] [MPMain   ] [DEBUG] - WindowManager: unroute to MediaPortal.Dialogs.GUIDialogNotify:2016->MediaPortal.GUI.Music.GUIMusicPlayingNow:510
[2013-11-17 13:33:47,767] [Log    ] [MPMain   ] [ERROR] - Exception: System.NullReferenceException: Object reference not set to an instance of an object.

So, Titan calls id 512 (DialogNotifyLastFM.xml) where StreamedMP calls id 2016 (DialogNotify.xml)

But i'm not sure if this is the cause or just a different routing.

 

[CypherMK]

So, if we change the id and test, we will know if it works :-P

 

[HomeY]

So, if we change the id and test, we will know if it works :-P

If it was that simple

I have no clue why (and where...) SMP targets id 2016 instead of 512.