[fixed] MP crashes when use Fanart download (3 Viewers)

[ysmp]

hi guys !

i dont see any problem with downlod fanart with fanart handler plugin with MP 1.2B , evry thing work fine out of the box...

i got all movie info+actor info +actor picture+movie cover+ 3 fanart (as i set it)

all work fine from the box of 1.2B ...

 

[ShIvADeSt]

With latest core.dll no crash (but exceptions in log are present) and no fanart too
Can it be a problem that moviename has russian letters? See no string in log that trying to download fanart

2011-05-09 09:13:20.067802 [Debug][MPMain(1)]: DialogWindow: MediaPortal.Dialogs.GUIDialogSelect init
2011-05-09 09:13:22.559944 [Debug][MPMain(1)]: WindowManager: unroute to MediaPortal.Dialogs.GUIDialogSelect:2000->MediaPortal.GUI.Video.GUIVideoInfo:2003
2011-05-09 09:13:22.583945 [Debug][MPMain(1)]: WindowManager: route MediaPortal.GUI.Video.GUIVideoInfo:2003->MediaPortal.Dialogs.GUIDialogProgress:101
2011-05-09 09:13:22.585946 [Debug][MPMain(1)]: DialogWindow: MediaPortal.Dialogs.GUIDialogProgress init
2011-05-09 09:13:28.554287 [Info.][IMDBDetails(15)]: Picture URL: http://cf1.imgobject.com/posters/23d/4cb1277e5e73d65b8100023d/127-hours-original.jpg
2011-05-09 09:13:28.639292 [Info.][IMDBDetails(15)]: GETLocalFanart: Parameters E:\Фильмы\Новинки 127 Часов [2010]_D.BDRip.720p.mkv 127 часов   127 Hours unknown 0 True
2011-05-09 09:13:28.641292 [Debug][(9)]: fileSystemWatcher_Created file c:\programdata\team mediaportal\mediaportal\thumbs\Skin FanArt\Scraper\movies\127 часов   127 Hours{0}.jpg
2011-05-09 09:13:28.652293 [Info.][IMDBDetails(15)]: GetLocalFanart: line 152 Copy C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Skin FanArt\Scraper\Movies\127 часов   127 Hours{0}.jpg -> C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Skin FanArt\Scraper\Movies\127 Часов [2010]_D.BDRip.720p{0}.jpg
2011-05-09 09:13:28.653293 [Debug][(9)]: fileSystemWatcher_Deleted file c:\programdata\team mediaportal\mediaportal\thumbs\Skin FanArt\Scraper\movies\127 часов   127 Hours{0}.jpg
2011-05-09 09:13:28.674294 [Info.][IMDBDetails(15)]: Exception   :System.IO.FileNotFoundException: Файл "C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Skin FanArt\Scraper\Movies\127 часов   127 Hours{0}.jpg" не найден.
Имя файла: "C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Skin FanArt\Scraper\Movies\127 часов   127 Hours{0}.jpg"
   в System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   в System.IO.File.InternalCopy(String sourceFileName, String destFileName, Boolean overwrite)
   в MediaPortal.Util.FanArt.GetLocalFanart(String path, String filename, String title, String localFile, Int32 index, Boolean share)
2011-05-09 09:13:28.675294 [Info.][IMDBDetails(15)]: Exception   :Файл "C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Skin FanArt\Scraper\Movies\127 часов   127 Hours{0}.jpg" не найден.
2011-05-09 09:13:28.677294 [Info.][IMDBDetails(15)]:   site      :Void WinIOError(Int32, System.String)
2011-05-09 09:13:28.678294 [Info.][IMDBDetails(15)]:   source    :mscorlib
2011-05-09 09:13:28.680294 [Info.][IMDBDetails(15)]:   stacktrace:   в System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   в System.IO.File.InternalCopy(String sourceFileName, String destFileName, Boolean overwrite)
   в MediaPortal.Util.FanArt.GetLocalFanart(String path, String filename, String title, String localFile, Int32 index, Boolean share)
2011-05-09 09:13:28.831303 [Debug][(9)]: fileSystemWatcher_Created file c:\programdata\team mediaportal\mediaportal\thumbs\Videos\Title\127 часов   127 Hours{1900}L.jpg
2011-05-09 09:13:28.845304 [Debug][IMDBDetails(15)]: CreateThumbnail : FileExistsInCache updated with new file: C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Videos\Title\127 часов   127 Hours{1900}L.jpg
2011-05-09 09:13:28.921308 [Debug][(9)]: fileSystemWatcher_Created file c:\programdata\team mediaportal\mediaportal\thumbs\Videos\Title\127 часов   127 Hours{1900}.jpg
2011-05-09 09:13:28.925308 [Debug][IMDBDetails(15)]: CreateThumbnail : FileExistsInCache updated with new file: C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Videos\Title\127 часов   127 Hours{1900}.jpg
2011-05-09 09:13:29.083317 [Debug][IMDBDetails(15)]: WindowManager: unroute to MediaPortal.Dialogs.GUIDialogProgress:101->MediaPortal.GUI.Video.GUIVideoInfo:2003
2011-05-09 09:13:29.097318 [Info.][MPMain(1)]: RefreshIMDB() - Found movie and added info for: 127 часов   127 Hours (Year: 2010)
2011-05-09 09:13:32.751527 [Debug][MPMain(1)]: Windowmanager: Goto previous window

 

[Deda]

I'm curious about this:

2011-05-09 09:13:28.641292 [Debug][(9)]: fileSystemWatcher_Created file c:\programdata\team mediaportal\mediaportal\thumbs\Skin FanArt\Scraper\movies\127 часов   127 Hours{0}.jpg
2011-05-09 09:13:28.652293 [Info.][IMDBDetails(15)]: GetLocalFanart: line 152 Copy C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Skin FanArt\Scraper\Movies\127 часов   127 Hours{0}.jpg -> C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Skin FanArt\Scraper\Movies\127 Часов [2010]_D.BDRip.720p{0}.jpg
[COLOR=Red]2011-05-09 09:13:28.653293 [Debug][(9)]: fileSystemWatcher_Deleted file c:\programdata\team mediaportal\mediaportal\thumbs\Skin FanArt\Scraper\movies\127 часов   127 Hours{0}.jpg[/COLOR]
2011-05-09 09:13:28.674294 [Info.][IMDBDetails(15)]: Exception   :System.IO.FileNotFoundException: Файл "C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Skin FanArt\Scraper\Movies\127 часов   127 Hours{0}.jpg" не найден.

What deletes already created 127 часов 127 Hours{0}.jpg ? Can you maybe have some angry antivirus or something?

There is no code for delete between creation of fanart for DBView and share view.
What is happening is that first fanart is created then it tries to copy that file as 127 Часов [2010]_D.BDRip.720p{0}.jpg but method fails because something deletes it meanwhile.

I tested fanarts on your database which you sent previously and none error found, everything was ok.

Can you refresh fanart for that movie in configuration? No need to scan movie, you can do that in fanart tab.

All parameters passed to fanart scraper are ok (edit: ahh yes local file is empty, this leads to something else)

09:13:28.639292 [Info.][IMDBDetails(15)]: GETLocalFanart: Parameters
Path->(E:\Фильмы\Новинки)
Filename->(127 Часов [2010]_D.BDRip.720p.mkv)
MovieTitle->(127 часов 127 Hours)
Local file->(unknown) This is not ok
Index->(0)
Create fanart for share view->(True)

 

[ShIvADeSt]

I think I begin to understand problem. If file isn't in vdeoDB and I try to download IMDB info all works fine - fanart downloading.
But if video already in videoDB - fanart on refresh didn't download.
File 127 hours was not in videodb - fanart downloaded and all ok
File harry Potter was in videodb - no fanart downloaded and exception in log.

Bug 2. When fanart fist time downloaded it doesn't show immediatly. Need to close MP and start it again, that downloaded fanart shows for file. May be open new thread for this bug?

 

[Deda]

Ok, this file will help you (I hope so). You can use original core.dll

Fanart scrape in your case should not be taken from GetLocalFanart beacuse it's scrapped during movie refresh (rescan) that's why parameter localfile = unknown. I found possible glitch so I hope we can conclude this.

Possible mistake is this:

if (_movieDetails.FanartURL == string.Empty)
            {
              fanartSearch.GetTmdbFanartByApi

should be

if (_movieDetails.FanartURL == string.Empty || _movieDetails.FanartURL == Strings.Unknown)
            {
              fanartSearch.GetTmdbFanartByApi

You need to get fanart by API not as local file.

 

[ShIvADeSt]

Yes now it works perfectly with old core.dll. Fanart downloaded and no crash ever.

But Bug 2 remains. Newly downloaded fanart shows for file ONLY after MP restart. Must I create new thread?

 

[Deda]

Bug 2. When fanart fist time downloaded it doesn't show immediatly. Need to close MP and start it again, that downloaded fanart shows for file. May be open new thread for this bug?

This is behavior of fanart plugin, I can't do nothing about this. But it should be visible after some time when fanart plugin handles new files.

 

[Deda]

And one thing to help you because I saw that kinopoisk scrapper doesn't have IMDBtt number (but you have it in your db) and when refreshing movie that number is gone from the database,so if you want to have multiple fanarts and without possible mistake, use "Refresh all" in Fanart tab in Configuration and you will have it for all movies because I can only get those when using that tt id, but enter missing tt number in movies you refreshed in MP (to edit that field check "Look up by tt" in title TAB) and save db first.

 

[ShIvADeSt]

Ok if is plugin behavior - let be so. May be mark thread as Bug?

 

[Deda]

Ok bug confirmed and I will added to mantis for 120 RC1. for your help in this.

Mantis http://mantis.team-mediaportal.com/view.php?id=3544