MP plays wrong audio stream (1 Viewer)

[disaster123]

Hi!

I've selected prefer AC-3 Stream and my preferred language to German (deu). When i now play a movie with 3 audio streams:
Index 0: DEU:MPEG1
Index 1: DEU:MPEG1
Index 2: DEU:AC3

MP selects always index 0 why?

2009-11-22 19:52:08.229467 [Debug][MPMain]: VMR9Helper: Playing -> Repainting, Frames 53
2009-11-22 19:52:08.245468 [Info.][MPMain]: TSReaderPlayer:OnRequestAudioChange()
2009-11-22 19:52:08.246468 [Debug][MPMain]: TVHome.OnAudioTracksReady()
2009-11-22 19:52:08.260469 [Debug][MPMain]: TVHome.GetPreferedAudioStreamIndex(): preferred LANG(s):deu;ger preferAC3:True preferAudioTypeOverLang:False
2009-11-22 19:52:08.260469 [Debug][MPMain]: Audio streams avail: 3
2009-11-22 19:52:08.261469 [Info.][MPMain]: TsReaderPlayer: AudioDualMonoMode switching not available. Audioswitcher filter not loaded
2009-11-22 19:52:08.262469 [Debug][MPMain]: Stream 0 lang deu, preffered index 0
2009-11-22 19:52:08.262469 [Debug][MPMain]: Setting as pref
2009-11-22 19:52:08.262469 [Info.][MPMain]: TsReaderPlayer: AudioDualMonoMode switching not available. Audioswitcher filter not loaded
2009-11-22 19:52:08.262469 [Debug][MPMain]: Stream 1 lang deu, preffered index 0
2009-11-22 19:52:08.262469 [Info.][MPMain]: TsReaderPlayer: AudioDualMonoMode switching not available. Audioswitcher filter not loaded
2009-11-22 19:52:08.262469 [Debug][MPMain]: Stream 2 lang deu, preffered index 0
2009-11-22 19:52:08.263469 [Info.][MPMain]: Audio stream: ignoring AC3 audio stream 2
2009-11-22 19:52:08.263469 [Info.][MPMain]: Audio stream: no preferred AC3 audio stream found, trying mpeg instead.
2009-11-22 19:52:08.263469 [Info.][MPMain]: Audio stream: switching to preferred MPEG audio stream 0, based on LANG deu
2009-11-22 19:52:08.268469 [Debug][MPMain]: g_Player.SeekAbsolute() - Preparing to seek to 0:11:15

Stefan

 

[disaster123]

here is a patch for that
https://forum.team-mediaportal.com/...ream-not-selected-correctly-73722/#post538420

 

[framug]

I don't know if it's working in all case therefore, I really like your comments in code.

 

[disaster123]

framug
Sorry for the comments - but the code is missing a lot of comments at all. There are some things which are not logical and nobody knows why / for what reason they're done. The if plus setting priority to index is like a break - cause nothing is processed any longer there.

 

[framug]

Sorry for the comments

Don't say sorry, I really smile when reading, funny.

but the code is missing a lot of comments at all.

Yes but, with quality rules, in general, MP code is good quality and well written then, most of time, it's understandable without comment, isnt it ?

There are some things which are not logical and nobody knows why / for what reason they're done.

That's why we create patchs.

 

[disaster123]

but the code is missing a lot of comments at all.

Yes but, with quality rules, in general, MP code is good quality and well written then, most of time, it's understandable without comment, isnt it ?
Somethimes yes - sometimes no If you've a complex logic and you wrote the code it might be that you can read it for some weeks but nobody else can and after a few month or so you can't too.

And these lines are def. NOT self explaining. Bu we get out of topic now


It was implemented by gibman_dk on August the 2nd Rev 23314 perhaps he knows what this should do or why it is needed...

 

[disaster123]

Newer patch will be posted here.
https://forum.team-mediaportal.com/...ream-not-selected-correctly-73722/#post538420