[Finished] MP1-4777 Additional info for video and audio (1 Viewer)

[Sebastiii]

@yartat a quick question

Before your branch we was able to see this in debug log but not anymore, can you explain why you removed it ? (and can you put it back ?)

[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: DLL Version      : MediaInfoLib - v0.7.65
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [INFO ] - MediaInfoWrapper.MediaInfoWrapper: Inspecting media : \\homeserver\mediaserv\record\TVE3\manual - Video - 2014-12-16.ts
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: Parse speed      : 0.3
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: FrameRate        : 25
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: Width            : 720
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: Height           : 576
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: AspectRatio      : widescreen
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: VideoCodec       : MPEG VIDEO VERSION 2 [ "mpeg video version 2.png" ]
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: Scan type        : interlaced
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: IsInterlaced     : True
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: VideoResolution  : 576
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: VideoDuration    : 53934269
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: AudioRate        : 48000
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: AudioChannels    : 1 [ "mono.png" ]
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: AudioCodec       : MPEG AUDIO VERSION 1 LAYER 2 [ "mpeg audio version 1 layer 2.png" ]
[2016-03-05 16:37:05,020] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: HasAudio         : True
[2016-03-05 16:37:05,036] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: HasVideo         : True
[2016-03-05 16:37:05,036] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: HasSubtitles     : False
[2016-03-05 16:37:05,036] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: NumSubtitles     : 0
[2016-03-05 16:37:05,036] [Log    ] [MPMain   ] [DEBUG] - MediaInfoWrapper.MediaInfoWrapper: Closing file : \\homeserver\mediaserv\record\TVE3\manual - Video - 2014-12-16.ts

 

[yartat]

@Sebastiii , Previous version shows only first video and audio streams, even for DVD (VST with longest duration). This behavior is not very good. We should print all detected streams or print current selected streams.

 

[Sebastiii]

Yep i agree but it can be useful for single video stream it can tell use for log a minimum of information (for ex mediaInfo version etc.). If the file has subtitle for example. How we can workaround it then ? Or expose in log (debug) all information for each stream ? mediaInfo.Count and export to log ?

 

[yartat]

I will add information about all streams for some players (all inherited from DirectShowPlayer, AudioPlayerVMR and VideoPlayerVMR9)

UPDATE: Please, check it

 

[Sebastiii]

Thanks you are fast branch updated and let's go to test

 

[Sebastiii]

Updated a little the branch for the log :
https://git.io/v2xvM

 

[yartat]

@Sebastiii , Looks good

 

[Sebastiii]

Hi,

@yartat

I notice that this new stuff break Moving picture and surely other plugins

Those are screenshot from before (imported a movie and display correctly and after the branch (not imported correctly) :
Correct :

Now : (note that this movie has a subtitle, the runtime is displayed because i have start the movie otherwise, it's displayed like this 0:00 instead of 1:57).

 

[Sebastiii]

Yep, it comes because of this
@yartat could you fix it ?

13-Mar-2016 11:37:13 Debug [        DBLocalMedia]:  System.TypeLoadException: Could not load type 'MediaPortal.Player.MediaInfo' from assembly 'Core, Version=1.13.100.2079, Culture=neutral, PublicKeyToken=null'.
   at MediaPortal.Plugins.MovingPictures.LocalMediaManagement.MediaInfoWrapper..ctor(String strFile)
   at MediaPortal.Plugins.MovingPictures.LocalMediaManagement.VideoFormatExtensions.GetMediaInfo(VideoFormat self, String videoPath)
   at MediaPortal.Plugins.MovingPictures.Database.DBLocalMedia.UpdateMediaInfo(Boolean mountImage)

 

[Sebastiii]

Ok i have downloaded the latest MOVPIC code and affectively the ref to mediaInfo need to be changed, this means that it break plugins and if we go with this new branch, we need to update compatibility version check for plugins. we should avoid this.
I hope you can know how to fi this @yartat