[Finished] MP1-4777 Additional info for video and audio (1 Viewer)

yartat

Portal Pro
October 1, 2007
71
115
Kjiv, Ukraine
Ukraine Ukraine
Description of Change

This branch will change code of enumeration player streams. it's planing mix them with information from the MediaInfoLib.
Unfortunately information about stereoscopic type contains only in the .MKV container. MediaInfoLib detects stereoscopic type well.
For now, there is no way to detect stereoscopic type in the .TS container.
It will create new stream detection.

For ex :
Would it be possible to have a detection based on video track name too?
Would it be possible to disable 3D subtitle rendering if a subtitle track name contains 3D?

Adding new event to g_Player ChangeStream with information about type of the stream to change and information about this stream. This event can be used with third party plugins.

This is a big FEAT / REWORK so get attention about testing, with enough good result and without regression, it surely can go in next MP release.

Jira Link : https://issues.team-mediaportal.com/browse/MP1-4777
Wiki docs: Explain used with third party plugins

Steps to install and test
Installation
2016.03.06 :
Download the -->> Installer based on 1.14 Pre-release <<-- and execute it. (Not available for now)

Testing
Upgrade your current 1.14 Pre-release or 1.13 installation and try :
Please do not forget to give some feedback (also if there is no bug). Thank you!
That's all

Sebastiii

Changelog

Thanks to @yartat
 
Last edited by a moderator:

yartat

Portal Pro
October 1, 2007
71
115
Kjiv, Ukraine
Ukraine Ukraine
According to this post I created pull request with additional info for video and audio stream in g_Player and event to notification when user change audio or video stream. Please, check it
 
Last edited:

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    According to this post I created pull request with additional info for video and audio stream in g_Player and event to notification when user change audio or video stream. Please, check it
    Hi,

    I have build issue with your branch :

    Code:
    Error    15    The command ""D:\MediaPortal-1-Git\mediaportal\MediaPortal.Tests\PostBuild.bat" "D:\MediaPortal-1-Git\mediaportal\" Debug" exited with code 4.    MediaPortal.Tests
    Also when i will be able to buid, can you explain why you have removed :

    C#:
    if (MediaInfo != null && !MediaInfo.MediaInfoNotloaded && !MediaInfo.HasVideo)
    vs
    if (MediaInfo != null && !MediaInfo.HasVideo)
    We add that when mediainfo was not able to scan a file, so it means that mediainfo can failed on some file, so we need to have something working when it happen (for ex : .WTV failed).

    Thanks :)
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    Ok above error it's because directshowfilter was not builded :) so need to compared how is the other postbuild.bat :)
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    @yartat I will push a branch based on your rework but i have put in back the MediaInfoNotloaded and also i have change the space line to be conform with MP1 rules (read here :
    http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/18_Contribute/4_Development/Coding_Standards)

    Could you test the branch (when pushed) and be sure that all space line are ok ?
    Thanks :)

    EDIT : Also i have put in back the mediainfo.dll .69 because recent one is broken on .TS and teletext subs. We also need to use nuget for that and not adding bin. So maybe other dll be be added to a nuget package.

    EDIT 2 : Also why remove : TvEngine3\TVLibrary\TvThumbnails\VideoThumbCreator\MediaInfo.cs it's needed for generate Thumb on TVServer side.

    EDIT 3 : Hope it didn't break : MP1-4757-FEAT-Add_stream_selection_based_on_LAV_Splitter

    @Marcus Venturi sorry to hijack your thread, i will surely open an Area51 thread for this and move post threre.
     
    Last edited:

    yartat

    Portal Pro
    October 1, 2007
    71
    115
    Kjiv, Ukraine
    Ukraine Ukraine
    C#:
    if (MediaInfo != null && !MediaInfo.MediaInfoNotloaded && !MediaInfo.HasVideo)
    vs
    if (MediaInfo != null && !MediaInfo.HasVideo)
    We add that when mediainfo was not able to scan a file, so it means that mediainfo can failed on some file, so we need to have something working when it happen (for ex : .WTV failed).

    Thanks :)
    I replaced MediaInfo definition from official github. This implementation does not support MediaInfoNotloaded. :)
    i have change the space line to be conform with MP1 rules (read here : http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/18_Contribute/4_Development/Coding_Standards)
    My fault. Sorry. I develop 3 projects as parallel and forgot switch sometimes.
    Could you test the branch (when pushed)?
    I tested more than 100 movies and clips from my collection movies (about 750 items)
    A liitlle bit of them in the Mediaportal.Tests
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    C#:
    if (MediaInfo != null && !MediaInfo.MediaInfoNotloaded && !MediaInfo.HasVideo)
    vs
    if (MediaInfo != null && !MediaInfo.HasVideo)
    We add that when mediainfo was not able to scan a file, so it means that mediainfo can failed on some file, so we need to have something working when it happen (for ex : .WTV failed).

    Thanks :)
    I replaced MediaInfo definition from official github. This implementation does not support MediaInfoNotloaded. :)
    Ok :) but that's needed here :) when a mediainfo failed to analyse a file :)

    I have try to merge the new branch into my own for testing too and it break the realspeed branch (MP1-4745-Slow_down_playback) from @regeszter. But that lead to the fact that i think we need to try to load mediainfo once, i remember changing something about a long time ago to avoid multiple loading on mediainfo to speed the process, so now i'm not sure that your branch is OK on this side.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    Yep you revert the change made a long time ago :(
    For example (but there are other place):

    Here, it try to not reload it if already loaded :
    C#:
    // Set currentMediaInfoFilePlaying for later use if it's the same media to play (it will cache mediainfo data)
            MediaInfoWrapper mInfo = null;
            if (!string.IsNullOrEmpty(g_Player.currentMediaInfoFilePlaying) && (g_Player.currentMediaInfoFilePlaying == strFilenameAndPath))
            {
              mInfo = g_Player._mediaInfo;
            }
            else
            {
              g_Player.currentMediaInfoFilePlaying = strFilenameAndPath;
              mInfo = g_Player._mediaInfo = new MediaInfoWrapper(strFilenameAndPath);
            }
    to

    Now you always read/load mediainfo :

    C#:
            // Set currentMediaInfoFilePlaying for later use if it's the same media to play (it will cache mediainfo data)
            var mediaInfo = new MediaInfoWrapper(strFilenameAndPath);
            if (string.IsNullOrEmpty(g_Player.currentMediaInfoFilePlaying) || g_Player.currentMediaInfoFilePlaying != strFilenameAndPath)
            {
              g_Player.currentMediaInfoFilePlaying = strFilenameAndPath;
            }
    I will try to explain what it's needed, the purpose of old code, is to try to load only once the mediainfo.dll and reload it or refresh it if it's really needed.
    So do you think you can do that way too (with your new code) ? And really reload mediainfo if it's really needed.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    Thanks :) i have almost change the code guide lines in MP1-4777 so please use it (on your own repo ofc), you just need to fetch MP1 repo? Thanks.
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    ajs MP2Web - MP1 compatibility MediaPortal 1 20
    T MadVR + LAV Filters, Perfect in MPC-BE, Bad in MP1 MediaPortal 1 Talk 12
    P MP2: US user, OTA - can NOT get SchedulesDirect plugin to work on MP1 or MP2 --> how do I get OTA schedule? General 5
    framug [solved] Some changes/fix in MP1 configuration client and server Submit: code patches (MediaPortal/TV-Server/etc.) 14
    S TV-Server MP1 - Automatic search doesn't work Installation, configuration support 2
    C Streaming/transcoding MP2 vs MP1? General 1
    ajs [fixed] 5015: Improving the MP1 installer, providing nicer GUI :) MediaPortal 1 138
    C Streaming to clients over Wifi. MP1 or MP2? Newcomers Forum 0
    S Shortcuts MP1 My Recorded & TV Guide General 10
    azzuro [WiP] MP1-4999 - Big changes with many related change at once by Sebastiii MediaPortal 1 12
    ajs [Help Us!] MP1 X64 Version MediaPortal 1 20
    joecrow How about a Launcher plugin for MP1? MediaPortal 1 6
    wizard123 [solved] MP1 Build help MediaPortal 1 21
    ajs [News] MediaPortal 1 - 1.24 Released! News and Announcements 3
    CyberSimian [fixed] MP1-4990 : Improve horizontal scrolling in the EPG MediaPortal 1 10
    azzuro [WiP] MP1-5019: Replace MySQL with MariaDB MediaPortal 1 40
    catalpa Umsteiger von MP1: Schwierigkeiten Allgemeines Support- und Diskussionsforum 17
    CyberSimian [solved] MP1-4976 Built-in skin variables for current date MediaPortal 1 8
    rbo [solved] Umsteiger MP1 zu MP2 Allgemeines Support- und Diskussionsforum 67
    azzuro [Info] MP2 TVE inside MP1 repo MediaPortal 2 12
    G MP1 TV Server "failed to upgrade the database" using MS Sql Server Installation, configuration support 3
    lisag Can I get MP1 to open in the Recorded TV screen? MediaPortal 1 Talk 2
    M MP1 stops responding after Starting Plugins General Support 14
    R Problem with MP1 and WifiRemote Skins and Plugins Installer (MPEI) 8
    M.Hulot [solved] Netflix und amazon Prime in MP1 möglich? TV / Streaming 6
    Similar threads

























    Top Bottom