MP2 - V2.3.2 MP2.3.2 client freezes (2 Viewers)

[ge2301]

Same applies for the series and movies overview. Also it is no longer possible to search for movies or to browse media items in folder view.

I just tried with the latest build and works without issues. I do not have any recordings, so thats the only thing I could not test.
Can you use the quickentry shortcuts in home screen? E.g. direct access to movie genres or similar? Those are really not working at the moment.

Edit: I found some recordings and can also not open the recordings view @morpheus_xx @henso another issue I can not solve alone

 

[marabicudi]

Can you use the quickentry shortcuts in home screen? E.g. direct access to movie genres or similar? Those are really not working at the moment.

I tested again and in fact the movies section is working (incl. quick entry shortcut), but there is no possibility to browse the series, neither the quick entry shortcut is working nor any of the predefined filters (genre, year, age, actors). The search is also not working.
The only thing working for me regarding series are the sections "continue playing", "favorites" and "unplayed".

Since the latest builds I am also encountering random system restarts and in the client log there are a lot of NRE logged like:

[2021-12-13 12:47:39,845] [20047  ] [InputMgr ] [INFO ] - WorkflowManager: Pushing workflow state 'SeriesNavigation-Root' (id='30f57cba-459c-4202-a587-09fff5098251') onto the navigation stack...
[2021-12-13 12:47:39,846] [20048  ] [InputMgr ] [DEBUG] - WorkflowManager: Using workflow model with id '4cdd601f-e280-43b9-ad0a-6d7b2403c856' for new workflow state '30f57cba-459c-4202-a587-09fff5098251'
[2021-12-13 12:47:39,847] [20049  ] [InputMgr ] [DEBUG] - WorkflowManager: Entering workflow state 'SeriesNavigation-Root'
[2021-12-13 12:47:39,847] [20049  ] [InputMgr ] [DEBUG] - WorkflowManager: Entering model context with workflow state '30f57cba-459c-4202-a587-09fff5098251' (old state was '7f702d9c-f2dd-42da-9ed8-0ba92f07787f') in new workflow model '4cdd601f-e280-43b9-ad0a-6d7b2403c856'
[2021-12-13 12:47:39,918] [20120  ] [InputMgr ] [ERROR] - WorkflowManager: Error entering model context of workflow model '4cdd601f-e280-43b9-ad0a-6d7b2403c856' for workflow state '30f57cba-459c-4202-a587-09fff5098251'
System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
   bei MediaPortal.UiComponents.Media.Models.NavigationModel.BaseNavigationInitializer.<>c__DisplayClass26_0.<InitMediaNavigation>b__1(Sorting sorting)
   bei System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source, Func`2 predicate)
   bei MediaPortal.UiComponents.Media.Models.NavigationModel.BaseNavigationInitializer.InitMediaNavigation(MediaNavigationConfig config, String& mediaNavigationMode, NavigationData& navigationData)
   bei MediaPortal.UiComponents.Media.Models.MediaNavigationModel.PrepareRootState(Guid workflowStateId, MediaNavigationConfig config)
   bei MediaPortal.UiComponents.Media.Models.MediaNavigationModel.PrepareState(NavigationContext context)
   bei MediaPortal.UiComponents.Media.Models.MediaNavigationModel.EnterModelContext(NavigationContext oldContext, NavigationContext newContext)
   bei MediaPortal.UI.Services.Workflow.WorkflowManager.DoPushNavigationContext(WorkflowState state, NavigationContextConfig config)
[2021-12-13 12:47:39,928] [20130  ] [InputMgr ] [DEBUG] - WorkflowManager: Compiling menu actions for workflow state 'SeriesNavigation-Root'
[2021-12-13 12:47:39,930] [20132  ] [InputMgr ] [ERROR] - WorkflowManager: Error updating menu actions in workflow model '4cdd601f-e280-43b9-ad0a-6d7b2403c856' for workflow state '30f57cba-459c-4202-a587-09fff5098251'
System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
   bei MediaPortal.UiComponents.Media.Models.NavigationModel.BaseNavigationInitializer.<>c__DisplayClass26_0.<InitMediaNavigation>b__1(Sorting sorting)
   bei System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source, Func`2 predicate)
   bei MediaPortal.UiComponents.Media.Models.NavigationModel.BaseNavigationInitializer.InitMediaNavigation(MediaNavigationConfig config, String& mediaNavigationMode, NavigationData& navigationData)
   bei MediaPortal.UiComponents.Media.Models.MediaNavigationModel.PrepareRootState(Guid workflowStateId, MediaNavigationConfig config)
   bei MediaPortal.UiComponents.Media.Models.MediaNavigationModel.PrepareState(NavigationContext context)
   bei MediaPortal.UiComponents.Media.Models.MediaNavigationModel.UpdateMenuActions(NavigationContext context, IDictionary`2 actions)
   bei MediaPortal.UI.Services.Workflow.WorkflowManager.DoPushNavigationContext(WorkflowState state, NavigationContextConfig config)
[2021-12-13 12:47:39,931] [20133  ] [InputMgr ] [DEBUG] - WorkflowManager: Tidying up...
[2021-12-13 12:47:39,932] [20134  ] [InputMgr ] [ERROR] - WorkflowManager.NavigatePushInternal: Error in workflow model or screen
System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
   bei MediaPortal.UI.Services.Workflow.WorkflowManager.DoPushNavigationContext(WorkflowState state, NavigationContextConfig config)
   bei MediaPortal.UI.Services.Workflow.WorkflowManager.NavigatePushInternal(Guid stateId, NavigationContextConfig config)
[2021-12-13 12:47:39,940] [20142  ] [InputMgr ] [INFO ] - WorkflowManager: Trying to remove 1 workflow states from navigation stack...
[2021-12-13 12:47:39,941] [20143  ] [InputMgr ] [DEBUG] - WorkflowManager: Exiting predecessor workflow model '4cdd601f-e280-43b9-ad0a-6d7b2403c856'
[2021-12-13 12:47:39,942] [20144  ] [InputMgr ] [ERROR] - WorkflowManager: Error exiting model context of workflow model '4cdd601f-e280-43b9-ad0a-6d7b2403c856' at workflow state '30f57cba-459c-4202-a587-09fff5098251'
System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
   bei MediaPortal.UiComponents.Media.Models.MediaNavigationModel.ExitModelContext(NavigationContext oldContext, NavigationContext newContext)
   bei MediaPortal.UI.Services.Workflow.WorkflowManager.DoPopNavigationContext(Int32 count, Boolean& workflowStatePopped)

and some dokan issues like:

[2021-12-13 12:47:45,345] [25547  ] [Main     ] [ERROR] - Dokan: Failed to unmount resource 'C:\ProgramData\Team MediaPortal\MP2-Client\RemoteResources'

Mara

 

[ge2301]

Yes, @osre logs show similar NRE issues and I also remember 2 restarts of my living room client with MP2.4 #81 recently. I checked the logs and I find similar errors. @morpheus_xx so it seems latest builds (~#71) are not stable any more and partly not working.

 

[morpheus_xx]

I haven't checked git commits for a while now. Do you remember any changes in the media browsing part?

 

[ge2301]

I haven't checked git commits for a while now. Do you remember any changes in the media browsing part?

Unfortunately not. I also went through the commit history. Most changes are done by me and design related. The deeper changes I made were realted to skin settings, so nothing that could be ralted to the issues I think.

Tha last changes also fitting to the timing of issues more or the less are from @Brownard related to the view model.
And related to the non working quick access links following: MP2-879: Fix linked filter not included in BaseUnwatchedMediaListProv… · MediaPortal/MediaPortal-2@b9650cb and following MP2-879: Revert adding of limit to FilteredRelationshipFilter, we onl… · MediaPortal/MediaPortal-2@e2803b1

Prior to that there were also further changes by @Brownard related to the workflows:
MP2-878: Simplify deferred action interface and handling as DoesChang… · MediaPortal/MediaPortal-2@c015f6b
MP2-878: Remove the delay in pushing the media info WF state as it's … · MediaPortal/MediaPortal-2@1896097

For me everything was working long time after that and only once I removed also the program data fully and set up MP2 freshly I see also mentioned issues.

Would be good if @Brownard could take a look himself, but I didn't see him since august fright after adding the view mode changes.

 

[morpheus_xx]

For me everything was working long time after that and only once I removed also the program data fully and set up MP2 freshly I see also mentioned issues.

This sounds more like a bug in the importer process, so newly imported media items are missing a certain part and then media navigation fails. I will try with a fresh media library...

 

[morpheus_xx]

[2021-12-13 12:47:39,930] [20132 ] [InputMgr ] [ERROR] - WorkflowManager: Error updating menu actions in workflow model '4cdd601f-e280-43b9-ad0a-6d7b2403c856' for workflow state '30f57cba-459c-4202-a587-09fff5098251' System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt. bei MediaPortal.UiComponents.Media.Models.NavigationModel.BaseNavigationInitializer.<>c__DisplayClass26_0.<InitMediaNavigation>b__1(Sorting sorting) bei System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source, Func`2 predicate) bei MediaPortal.UiComponents.Media.Models.NavigationModel.BaseNavigationInitializer.InitMediaNavigation(MediaNavigationConfig config, String& mediaNavigationMode, NavigationData& navigationData) bei MediaPortal.UiComponents.Media.Models.MediaNavigationModel.PrepareRootState(Guid workflowStateId, MediaNavigationConfig config) bei MediaPortal.UiComponents.Media.Models.MediaNavigationModel.PrepareState(NavigationContext context) bei MediaPortal.UiComponents.Media.Models.MediaNavigationModel.UpdateMenuActions(NavigationContext context, IDictionary`2 actions) bei MediaPortal.UI.Services.Workflow.WorkflowManager.DoPushNavigationContext(WorkflowState state, NavigationContextConfig config)

I have checked the code base for this error. It happens inside FirstOrDefault when trying to find sorting for screen. I wonder why there can be "null" items in this list. Anyway, for testing I added a null check inside each FirstOrDefault call inside this method.

Changed are pushed to origin/FIX_MediaNavigationNRE.

@ge2301 are you able to test if this fixes the NRE?

 

[ge2301]

I have checked the code base for this error. It happens inside FirstOrDefault when trying to find sorting for screen. I wonder why there can be "null" items in this list. Anyway, for testing I added a null check inside each FirstOrDefault call inside this method.

Changed are pushed to origin/FIX_MediaNavigationNRE.

@ge2301 are you able to test if this fixes the NRE?

The same issues as before, the quick access shortcuts in homecontent are still not working.
Logs attached.

 

[morpheus_xx]

Okay, I touched the wrong part, the NRE happens from the configuration side. It's tried to find matching LayoutType/LayoutSize for a not-defined screen.

I now added logging to see which config we are missing. Also I apply default for such cases. We need to think about how to handle this in future, if we add new screens, where no config is defined yet.

Please test and report back. Also share mp2-client.log here, so I can see what is missing

 

[ge2301]

Attached the updated log files. The quick access buttons are not working. But you'll find also in the logs, that regular filtering from the side menu is working.