MP2 - V2.1 [MP2-567] Removing shares not working well. (1 Viewer)

[Lehmden]

Hi.
I've tried to remove my images share because I wanted to test something on the thumbnail issue. But I can't remove them.
All I get is "An internal error occurs" and the server's CPU and RAM load is raising a lot but nothing happens aside that the server is not responding any more.
In logs there only is

[2017-01-05 16:28:57,008] [10344745] [53 ] [INFO ] - MediaLibrary: Removing share '7216a147-a3b2-443d-93d3-8831d9668c78'
[2017-01-05 16:28:57,011] [10344748] [53 ] [INFO ] - ImporterWorker: Cancelation of jobs for path '{e88e64a8-0233-4fdf-ba27-0b44c6a39ae9}:///D:/Bilder/' requested...
[2017-01-05 16:39:02,647] [10950384] [28 ] [INFO ] - ImporterWorker: Shutdown requested...
[2017-01-05 16:39:02,651] [10950388] [65 ] [INFO ] - ImporterWorker: Suspended (0 ImportJobs pending)
[2017-01-05 16:39:02,660] [10950397] [65 ] [INFO ] - ImporterWorker: Shutdown
[2017-01-05 16:39:32,671] [10980408] [28 ] [ERROR] - ServiceRegistration: Error while removing service of type ISQLDatabase
System.TimeoutException: Disposing ConnectionPool failed. Probably a connection wasn't returned to the pool.
bei MediaPortal.Database.SQLite.ConnectionPool`1.Dispose()
bei MediaPortal.Database.SQLite.SQLiteDatabase.Dispose()
bei MediaPortal.Common.ServiceRegistration.RemoveAndDispose(Type type)
[2017-01-05 16:39:32,912] [10980649] [28 ] [INFO ] - PluginManager: Shutdown

That's the last log entry also the server seems not to be crashed completely (CPU and RAM load is not static). Even the disconnection of the client is not logged... The importer itself has no recent job to do so the "cancellation" can not be that hard to achieve.

After more than 10 minutes the server finally could be shut down (it was not usable at all in meantime). After the restart the removed share still is available as if nothing has happen...

 

[HTPCSourcer]

Strange. I had removed shares myself before, which worked almost instantaneously, although series not pictures.

From the above it looks as if the importer was still working while you tried to remove the respective share. Full debug level logs would be helpful.

 

[BlueMax1916]

Hi,

I had the same problem Lehmden describes with a share with series episodes. But instead of filing a bug report I decided to do a fresh install of MP 2.1 because the share was garbled in MP 2.1 and it would not show any series nor could I remove it. Just for your interest.


Cheers

Blue Max

 

[Lehmden]

Hi.

it looks as if the importer was still working

Normally this is impossible as the last import was finished more than a day ago. I think there is an error in the database query that leads to a too long transaction (or even an endless loop) so a client only get this "internal error" message but no more data. To work with a few test files is not comparable with hundreds of thousands of media items I now have in my database. That more media I've imported that slower is the server reacting. Now with that much images (150.000 ++) it is painfully slow even in other modules.. I will try to capture a screen video later to show what I mean.

 

[HTPCSourcer]

Hi.
Normally this is impossible as the last import was finished more than a day ago..

You still have no thumbs, do you? And the log says (but that might be a standard activity, just in case):

2017-01-05 16:28:57,011] [10344748] [53 ] [INFO ] - ImporterWorker: Cancelation of jobs for path '{e88e64a8-0233-4fdf-ba27-0b44c6a39ae9}:///D:/Bilder/' requested...

Can you try the same with series for which we know that there isn't any associated importer issue? (But please change log level first)

 

[HTPCSourcer]

But instead of filing a bug report

That's a pity, as without logs this is just anecdotal. We are really interested in qualified reports for any issues of this kind. If such thing happens again then please don't hesitate to post a report.

 

[breese]

Got it....
Went to remove all my music.
You cannot change screens while the system is removing media.
Also got an error during the removal


The client shows the following errors

[2017-01-05 10:55:14,681] [122780 ] [InputMgr ] [WARN ] - SharesConfigModel: Problem adding/editing share
UPnP.Infrastructure.CP.UPnPException: Error invoking action 'X_MediaPortal_RemoveShare' ---> UPnP.Infrastructure.CP.UPnPRemoteException: Network error when invoking action 'X_MediaPortal_RemoveShare': The operation has timed out
at UPnP.Infrastructure.CP.DeviceTree.CpAction.AsyncActionCallResult.GetOutParams()
at UPnP.Infrastructure.CP.DeviceTree.CpAction.EndInvokeAction(IAsyncResult result)
--- End of inner exception stack trace ---
at UPnP.Infrastructure.CP.DeviceTree.CpAction.EndInvokeAction(IAsyncResult result)
at UPnP.Infrastructure.CP.DeviceTree.CpAction.InvokeAction(IList`1 inParameters)
at MediaPortal.Common.Services.ServerCommunication.UPnPContentDirectoryServiceProxy.RemoveShare(Guid shareId)
at MediaPortal.UiComponents.SkinBase.Models.ServerShares.RemoveShares(IEnumerable`1 shares)
at MediaPortal.UiComponents.SkinBase.Models.SharesConfigModel.RemoveSelectedSharesAndFinish()

 

[Lehmden]

Can you try the same with series

Done. Result:

The issue seems to be that the removal of a share takes as long or even longer than the first import. For such looooong delays the system isn't prepared. Now with debug logs I see that every media item, every relation every actor, every director and every other entry is deleted one after the other. This takes ages to complete and while this happens the server is not usable. Not what I like to have. The removal of my images shares may take about 8 or 10 hours, I guess now. This is an absolutely no go... MP 2.0 only needs some seconds to remove a share. With a few test files this is usable but with "real" collections the server performance in such conditions is extremely bad.

I've killed the server task and restored the db so I can use MP 2.1 now again.

 

[HTPCSourcer]

@henso , this is critical. Can you have a look at the code how shares are getting removed?

I will enter a Jira and assign it to you: MP2-567

 

[henso]

Can you have a look at the code how shares are getting removed?

I'll take a peek once I get finished with the sort title issue.