MPE Tools with Version Check community development (4 Viewers)

Migue

Retired Team Member
  • Premium Supporter
  • January 27, 2006
    381
    305
    Florida
    Updated first post with new version.

    Changes:

    -Changed text color of "Ignore updated" in MPEI.

    -Fixed MPEMaker not respecting line breaks after loading.

    -Fixed issues regarding temp files not being cleaned up after failure nor successes. Also temp files are not saved to wrong folder (LocalAppdata) anymore.

    -Fixed bug where MPEI would say an extension is incompatible if the plugins it provides has versioning info but doesn't specify subsystems used.

    -MPEMaker now saves file list to update.xml. This is needed so that Skin version checking works properly without having to download the whole package. (Need to resave extensions with MPEMaker again.)

    -Added a dependency list dialog to MPEI. MPEI will ask user to display dialog if check fails and can also be opened by clicking on red warning icons.

    Please test and provide feedback.
     

    offbyone

    Development Group
  • Team MediaPortal
  • April 26, 2008
    3,989
    3,712
    Stuttgart
    Home Country
    Germany Germany
    Hi, thx so far!
    Here are my TestResults:
    LineBreaks:working!

    MPEI: Still tells me that my just build (and saved) installer does not meet the dependencies. Although it should, as I have just build it with the same binaries?
    The new message to get more details (thx!) comes up and the Datagrid throws an error for each line (attached screenshot). It is an Index out of Range.

    If you need more info or my xml for reproducing tell me!

    Edit: I found out that the dlls that are additionally added throw the error! (OnlineVideos installer has some satellite assemblies with no direct ties to MediaPortal!) These are somehow automatically added to the xml when saving although they don't contain any MP related attributes.
     

    Attachments

    • MPEIError.jpg
      MPEIError.jpg
      90.8 KB
    • MPEIError2.jpg
      MPEIError2.jpg
      27.4 KB

    Migue

    Retired Team Member
  • Premium Supporter
  • January 27, 2006
    381
    305
    Florida
    Thanks for the testing ofbyone.
    You were right, MPEMaker was mistakenly trying to add plugin dependency data to assemblies that weren't plugin (didn't check assemblies implemented ISetupForm).

    I've updated first post with new version that fixes this. Extension projects need to be re-saved in MPEMaker.
     

    offbyone

    Development Group
  • Team MediaPortal
  • April 26, 2008
    3,989
    3,712
    Stuttgart
    Home Country
    Germany Germany
    Thx, the other dlls are now no longer put into the xml!
    But I still can't install the mpe1 file i just build. Attached are the images where it show that my dependencies are not met. Strange that the dll dependency is green and the other is red? Does it take version info from somewhere else?

    Edit: BTW I think a plugin does not HAVE to implement ISetupForm to be recognized as plugin?
     

    Attachments

    • mpei1.jpg
      mpei1.jpg
      21.9 KB
    • mpei2.jpg
      mpei2.jpg
      21 KB

    Migue

    Retired Team Member
  • Premium Supporter
  • January 27, 2006
    381
    305
    Florida
    The minimum version for the MediaPortal dependency must be at least 1.1.6.27644 since this is the first version to incorporate the version checking.

    As for ISetupForm I went by what MP Config does to show plugins in the plugins section and what it does is to check that the assemblies implement this interface.

    EDIT: I guess I can add code to MPEMaker so that if Min version entered for the MediaPortal dependency is less than that value then it auto corrects it.
     

    offbyone

    Development Group
  • Team MediaPortal
  • April 26, 2008
    3,989
    3,712
    Stuttgart
    Home Country
    Germany Germany
    Not every plugin wants to show a config window. There should be already some pattern by the plugin loader what class to inherit is checked for a MP plugin I think?
    Would be nice to automatically set the minversion as requiered, as I did not know that I had to manually set it to something else! Saving my file set the version automatically (at least the max). Min was filled before.
     

    Migue

    Retired Team Member
  • Premium Supporter
  • January 27, 2006
    381
    305
    Florida
    That's the class (interface) they must inherit from: ISetupForm and that's what it checks. That's just a name. The interface has many methods and one of them is HasSetup().

    I've updated binaries in first post so that MPEMaker corrects the min version of the MediaPortal dependency if it's less than the minimum required.
    As usual, projects need to be resaved in MPEMaker.
     

    offbyone

    Development Group
  • Team MediaPortal
  • April 26, 2008
    3,989
    3,712
    Stuttgart
    Home Country
    Germany Germany
    Now it works out of the box. Resaved my installer - dependency was updated - build it and could install it!
    Good to go from my side.
    Not good: Why am I the only one testing this? I sure will miss some things ... So all community devs should test now or rest in silence afterwards!
     

    infinite.loop

    Retired Team Member
  • Premium Supporter
  • December 26, 2004
    16,163
    4,133
    127.0.0.1
    Home Country
    Austria Austria
    Not good: Why am I the only one testing this? I sure will miss some things ... So all community devs should test now or rest in silence afterwards!
    Thank you very much for your efforts offbyone and migue!

    I have no idea either why no one else seems interested to be part of this development. :confused:
     

    Dadeo

    Docs Group Manager
  • Premium Supporter
  • November 26, 2006
    5,340
    3,321
    Himalayas, India
    Home Country
    Canada Canada
    I am happy to report all the issues I reported are fixed:
    • Tooltip tells me to click the Incompatibility icon for more info - Clicking it on Online Videos tells me the exact dll which does not yet meet version compatibility (using old version sorry offbyone :))
    • "Ignore Updates" option is now nicely readable
    • I have not yet had any further issues with temp folder/files
    • line breaks working nicely (at last Hurray!)
    So far looking pretty good Migue - ofc the acid test will be when you update aMPed MPEI :p When will the Wiki docs for MPEI be updated? I feel that one of the reasons MPEI has not been used as well as it could be is that many functions and features are not fully understood. I was not able to understand Dukus well enough in many cases to write them, and in some cases it can be a bit complex. We really need some expert MPEI extension developers to write how to ... guides for both skins and plugins! I am happy to help when you are ready so that new extensions developers can easily manage to create their MPEI extensions.

    Not good: Why am I the only one testing this? I sure will miss some things ... So all community devs should test now or rest in silence afterwards!
    Thank you very much for your efforts offbyone and migue!
    I have no idea either why no one else seems interested to be part of this development. :confused:
    Well put offbyone. However as you know testing is a prevalent issue. Many just install test releases to try them out and do not report results, let alone proper bug reports. As a result I find very few extensions bother with beta releases any more. They just issue a new release every week or so, often with some skin changes which require 20-25 skins to update and thousands of users to update. But what else can you do when no one will test properly until a final release is published?

    I think the only option is as offbyone states, if you don't test, don't complain later because you have to wait many more months for next release (in the case of MPEI).

    :D again to Migue and offbyone
     

    Users who are viewing this thread

    Top Bottom