MPE Tools with Version Check community development (3 Viewers)

[catavolt]

AW: MPE Tools with Version Check community development

Hi Migue, first of all a big for your work!
Additionally to Dadeo´s comments I like to add that the calendar function now works as expected.
Made a new installer for my PVHD skins and they installed like a charm - the copy process seems to be a lot faster and the best of all not stalls for a while until finished.
Great enhancement!

 

[arion_p]

That's the class (interface) they must inherit from: ISetupForm and that's what it checks. That's just a name. The interface has many methods and one of them is HasSetup().

The above is not true:

• Process plugins have to implement IPlugin interface
• Window plugins have to inherit from GUIWindow
• External player plugins have to inherit from IExternalPlayer (which implements IPlayer and ISetupForm)

Any of the above may also implement:

• ISetupForm if it can be configured and needs to appear in Configuration.exe
• IWakeable if it needs to interfere with power management (schedule wake up or prevent suspend)

Currently, even though the infrastructure exists, it is not possible to load 3rd party Remote Plugins and Subtitle plugins.

 

[offbyone]

Hi Migue,
just wanted to ask how this is progressing / if you need any help. I think the only missing step before committing for 1.2 is the check what class / dll is a plugin with the rules arion mentioned.

 

[Migue]

Hi,

I've update first post with binaries that include checking for IPlugin and IWakeable to determine if a dll is an MP plugin, and also ITvServerPlugin for TV Server plugins.

 

[offbyone]

Hi Migue almost there You are still missing one case: A GUI plugin that does not implement any of the interfaces.
Taken from MP Core.dll PluginManager.cs LoadWindowPlugin()

t => t.IsClass && !t.IsAbstract && t.IsSubclassOf(typeof(GUIWindow))

So in Util.IsPlugin() in MpeCore.dll add:

if (!type.IsAbstract)
{
if...
if (type.IsClass && type.IsSubclassOf(typeof(GUIWindow))) return true;
}

Greets!

 

[Migue]

Thanks for catching that offbyone. I've updated bin again with that.

 

[offbyone]

Thanks! Now plugins are found. While doing more thorough testing, I discovered that the description is now saved with double line breaks in the xml. Therefore it also shows with a free line between each test line.

The xml had the single line breaks correctly before, they there just not loaded into the description box.

    <VersionDescription>rtmp: fixed live streams, connection problems, swf hash calulation

added Option to put Favorites and Downloads sites first

reworked Codecs tab in Configuration to test playback

added new info for videos: Airdate (GuiProperty: #OnlineVideos.aired)

YouTube: fixed localized content no available, added "New Videos" in User's Subscribtions

Downloads: refresh current downloading progress info while showing

SiteManager: user can now report broken sites from within MediaPortal

SiteManager: invoke AutomaticUpdate from button in hidden menu

SiteManager: update all sites shown (filtered) from contextmenu</VersionDescription>

Screenshot:

 

[offbyone]

One more thing (seen it reported by a user in the forum somewhere and can confirm by looking at the code):
The MpeInstaller checks if the file has the old installer format, which is fine. BUT, since the old installer exe is no longer supplied (as it is not compatible anyway), the call to it is wrong

MpeInstaller.MainForm.InstallFile should not call

Process.Start(Path.Combine(MpeInstaller.TransformInRealPath("%Base%"), "MPInstaller.exe"), "\"" + file + "\"");

but simply tell the user that the file is for MP 1.1 and quit.

 

[Migue]

offbyone,

I can't reproduce the double line breaks issue . I got onlinevideos from svn and rebuilt xmp2 with new MPEtools and installed it and everything works fine, with single line breaks as it should.

 

[offbyone]

I can't reproduce it reliably either I was able to get in once more the morning (no idea how), but at least 20 other tries failed to produce the double linebreaks It has to be some strange combination of clicks or saves ....