My Lyrics 1.8.0 for MP 1.4 / 1.5 (26-07-13) (4 Viewers)

catavolt

Design Group Manager
  • Team MediaPortal
  • August 13, 2007
    14,631
    10,651
    Königstein (Taunus)
    Home Country
    Germany Germany
    @yoavain, here two more "bugs":
    1. The skin property #Play.Current.Lyrics does not work any longer
    2. There are two labels hardcoded: 179 (track number) and 436 (year) which lead to double display when a skinner already used this labels as prefix for #Play.Current.Track and #Play.Current.Year. These should be removed, please ;)
     

    yoavain

    Extension Dev
  • Premium Supporter
  • May 24, 2009
    427
    467
    47
    Home Country
    Israel Israel
    • Thread starter
    • Moderator
    • #52
    Btw. I also noted that it seems to be possible to check "Don't search previously marked songs" and "Search for marked songs only" at the same time. Kind regards, malte71

    Issue tracker #13

    Will be fixed by instead of disabling and graying the other checkboxes - hide them
     

    yoavain

    Extension Dev
  • Premium Supporter
  • May 24, 2009
    427
    467
    47
    Home Country
    Israel Israel
    • Thread starter
    • Moderator
    • #53
    @yoavain, here two more "bugs":
    1. The skin property #Play.Current.Lyrics does not work any longer
    2. There are two labels hardcoded: 179 (track number) and 436 (year) which lead to double display when a skinner already used this labels as prefix for #Play.Current.Track and #Play.Current.Year. These should be removed, please ;)


    I found the 436 (year) and fixed it.
    I also found 435 as the track number, and fixed that too.
    Did not find 179 anywhere

    Here's your ticket in the issue tracker

    Regarding 1, I'm not sure I understand. Couldn't find it in code at all, so maybe that's the problem. Could you tell me what's its purpose?
     
    Last edited:

    catavolt

    Design Group Manager
  • Team MediaPortal
  • August 13, 2007
    14,631
    10,651
    Königstein (Taunus)
    Home Country
    Germany Germany
    Regarding 1, I'm not sure I understand. Couldn't find it in code at all, so maybe that's the problem. Could you tell me what's its purpose?
    That property can be used anywhere in the skin to show the lyrics, e.g. on NowPlaying screen - this worked a long time before, maybe it got lost anywhere in the development process of MP itself ;)
     

    Dadeo

    Docs Group Manager
  • Premium Supporter
  • November 26, 2006
    5,340
    3,321
    Himalayas, India
    Home Country
    Canada Canada
    You are correct @catavolt - #Play.Current.Lyrics worked in MP 1.3.0 up to MyLyrics 1.7.1 IIRC - I use it in aMPed - it displays any lyrics saved/embedded in ID3 tags when you focus on the Track Info button. It was added in MP 1.2.0 (see Skin Related changes > Music Now playing skin properties). I use MyLyrics to save Lyrics to my ID3 tags, so I don't have to always jump to Lyrics to see them. However, I am not sure that is an issue with MyLyrics plugin? Since I have lyrics embedded for many tracks imo they should display even if the plugin is not installed. IIRC they used to and they don't now. So that may be an issue with MP 1.4.0 but I'm not sure.
     

    yoavain

    Extension Dev
  • Premium Supporter
  • May 24, 2009
    427
    467
    47
    Home Country
    Israel Israel
    • Thread starter
    • Moderator
    • #56
    I've checked the MP code, and it seems that the #Play.Current.Lyrics property is set in the GUIMusicOverlay (along with other properties).
    The tag is set here (in the same class):
    Code:
    MusicTag tag;
     
    	  if (string.IsNullOrEmpty(filename))
    	  {
    		return;
    	  }
    	  // last.fm radio sets properties manually therefore do not overwrite them.
    	  if (Util.Utils.IsLastFMStream(filename))
    	  {
    		return;
    	  }
     
    	  // Radio Properties are set already in Play routine
    	  if (g_Player.IsRadio)
    	  {
    		return;
    	  }
     
    	  // When Playing an Internet Stream, via BASS, skin properties are set during the Play method in BassAudio.cs
    	  if (BassMusicPlayer.IsDefaultMusicPlayer && isInternetStream)
    	  {
    		return;
    	  }
    	  else
    	  {
    		tag = GetTag(filename);
    	  }

    However, in the BassAudio.cs, the lyrics property is not set, only the following:
    Code:
    // and display what we get
    	  GUIPropertyManager.SetProperty("#Play.Current.Album", _tagInfo.album);
    	  GUIPropertyManager.SetProperty("#Play.Current.Artist", _tagInfo.artist);
    	  GUIPropertyManager.SetProperty("#Play.Current.Title", title);
    	  GUIPropertyManager.SetProperty("#Play.Current.Comment", _tagInfo.comment);
    	  GUIPropertyManager.SetProperty("#Play.Current.Genre", _tagInfo.genre);
    	  GUIPropertyManager.SetProperty("#Play.Current.Year", _tagInfo.year);

    Lyrics are either forgotten or not parsed at all...

    Either way, I'm not sure if that related to MyLyrics. I could set this property, when finding the lyrics.
    The issue is with MP not parsing lyrics from file's metadata...
     
    Last edited:

    yoavain

    Extension Dev
  • Premium Supporter
  • May 24, 2009
    427
    467
    47
    Home Country
    Israel Israel
    • Thread starter
    • Moderator
    • #58
    maybe it got lost anywhere in the development process of MP itself ;)
    @Dadeo, @yoavain, that´s what I suspected already - it got lost during the music/BASS rework I fear.
    Maybe Helmut can help us here.
    And a BIG THX yoa, you are doing a great job here (y)


    OK, this is what I can do:
    When file does not have the lyrics in the tag or it is not identified by MP:
    If MyLyrics finds it, it will set the #Play.Current.Lyrics, so that going to another view, will keep this.
    This will happen in both scenarios:
    1. Lyrics are in the database.
    2. Lyrics found on the internet

    Still, MP should be fixed in order to parse the lyrics directly from the tag (without the MyLyrics)

    Yoav
     

    yoavain

    Extension Dev
  • Premium Supporter
  • May 24, 2009
    427
    467
    47
    Home Country
    Israel Israel
    • Thread starter
    • Moderator
    • #60
    Updated the milestone column in the open issue tracker. You can now see in what version to expect a fix.
    You can also see the already done issues/tasks.

    There's no ETA, and both priority and milestone can be changed...;)
     

    Users who are viewing this thread

    Top Bottom