My Lyrics 1.8.0 for MP 1.4 / 1.5 (26-07-13) (2 Viewers)

Dadeo

Docs Group Manager
  • Premium Supporter
  • November 26, 2006
    5,340
    3,321
    Himalayas, India
    Home Country
    Canada Canada
    OK, this is what I can do:
    When file does not have the lyrics in the tag or it is not identified by MP:
    If MyLyrics finds it, it will set the #Play.Current.Lyrics, so that going to another view, will keep this.
    This will happen in both scenarios:
    1. Lyrics are in the database.
    2. Lyrics found on the internet

    Still, MP should be fixed in order to parse the lyrics directly from the tag (without the MyLyrics)

    Yoav
    I agree it should be fixed in MP. I would not rush if I were you Yoav, because I discovered that reindexing my Music DB removes all my previously stored lyrics. So we should get to the root cause before you spend time trying to workaround it ;)

    While I was 'testing' I noticed that MyLyrics no longer saves my lyrics to my music tags. I always enable 'Write newly found lyrics to music tag' in Settings:
    Capture.JPG


    I could have sworn it used to work ;) Can you confirm? Or is there some other step or setting I need?
     

    yoavain

    Extension Dev
  • Premium Supporter
  • May 24, 2009
    427
    467
    47
    Home Country
    Israel Israel
    • Thread starter
    • Moderator
    • #62
    OK, this is what I can do:
    When file does not have the lyrics in the tag or it is not identified by MP:
    If MyLyrics finds it, it will set the #Play.Current.Lyrics, so that going to another view, will keep this.
    This will happen in both scenarios:
    1. Lyrics are in the database.
    2. Lyrics found on the internet

    Still, MP should be fixed in order to parse the lyrics directly from the tag (without the MyLyrics)

    Yoav
    I agree it should be fixed in MP. I would not rush if I were you Yoav, because I discovered that reindexing my Music DB removes all my previously stored lyrics. So we should get to the root cause before you spend time trying to workaround it ;)

    While I was 'testing' I noticed that MyLyrics no longer saves my lyrics to my music tags. I always enable 'Write newly found lyrics to music tag' in Settings:
    ...

    I could have sworn it used to work ;) Can you confirm? Or is there some other step or setting I need?


    Hi Dadeo,

    Haven't tried using this setting, since it only write newly found lyrics to music tag. I will check what it does when I have the time (will add it to the issue tracker;))

    Have you tried the 'Export' in the 'Lyric database' tab?
    Screenshot 2013-07-03 11.06.46.png


    Screenshot 2013-07-03 11.06.51.png


    I've tried it and it seems to write the tags to the file. Did this on a partial database, since it actually changes the MP3 file.
    I recommend doing a backup first
     

    Dadeo

    Docs Group Manager
  • Premium Supporter
  • November 26, 2006
    5,340
    3,321
    Himalayas, India
    Home Country
    Canada Canada
    Yes I tried export also and it does write the Lyrics to tags for me. I wonder if that was what I did before, instead of just ticking the 'write to tags' setting. ;)

    Unfortunately MP Music DB still doesn't read the Lyrics in ID3 tags - at least in MP 1.4.0 (I think it did in MP 1.3.0 but not 100% sure when I last did it). So they don't display with the #Play.Current.Lyrics tag even when I have them exported to ID3 tags. I reported to the Team for further investigation :p

    My usual 'process' is add a song, go to Lyrics plugin - it finds a new lyric and adds it to ID3 tag which I then can see anywhere in MP or other music players, and I don't risk losing it if I screw up my MP music and Lyrics DBs (like MP wiping them all out HA!) If I had not done that I would be screaming now! Ofc Lyrics plugin is awesome cuz you can just grab lyrics for all/selected songs. If this issue gets fixed in MP I will do that! I should have before, but you know how long that list of 'should haves' is ;)
     
    Last edited:

    yoavain

    Extension Dev
  • Premium Supporter
  • May 24, 2009
    427
    467
    47
    Home Country
    Israel Israel
    • Thread starter
    • Moderator
    • #64
    Yes I tried export also and it does write the Lyrics to tags for me. I wonder if that was what I did before, instead of just ticking the 'write to tags' setting. ;)


    I wonder how this feature was designed to work...
    I believe it was only for the configuration batch search, and not via the MP GUI, since there's a good chance the file is locked for writing when inside the Lyrics plugin page (during playback)
    I need to look at the code to understand:unsure:
     

    Dadeo

    Docs Group Manager
  • Premium Supporter
  • November 26, 2006
    5,340
    3,321
    Himalayas, India
    Home Country
    Canada Canada
    ah sorry yoavain - I did not mean to drag you into the quicksand with me! :barefoot:
    You make some good points and before you know it you will end up updating the MyLyrics wiki page - welcome to my world :rolleyes:
     

    ysmp

    Design Group
  • Team MediaPortal
  • May 17, 2008
    1,863
    744
    Seoul.
    Home Country
    South Korea South Korea
    Hi Guys ,
    the option 'Write newly found lyrics to music tag' use to work ... I cannot say when it's was brock ...
    long time ego ...(not by yoav ) I think about when MP 1.23 ~1.3.A .. is stop to work .... ;)

    if this can be fix is great ... as this option work in the backgrownd ... if you don't have Lyrics/LRC file ..play the song, my lyrics find the files and save them same time ..... noting to do more with conf' part .... ( this is when n have so much free time ... :D )
     

    yoavain

    Extension Dev
  • Premium Supporter
  • May 24, 2009
    427
    467
    47
    Home Country
    Israel Israel
    • Thread starter
    • Moderator
    • #67
    Hi Guys ,
    the option 'Write newly found lyrics to music tag' use to work ... I cannot say when it's was brock ...
    long time ego ...(not by yoav ) I think about when MP 1.23 ~1.3.A .. is stop to work .... ;)

    if this can be fix is great ... as this option work in the backgrownd ... if you don't have Lyrics/LRC file ..play the song, my lyrics find the files and save them same time ..... noting to do more with conf' part .... ( this is when n have so much free time ... :D )


    issue #22 :)
     

    yoavain

    Extension Dev
  • Premium Supporter
  • May 24, 2009
    427
    467
    47
    Home Country
    Israel Israel
    • Thread starter
    • Moderator
    • #68
    Hi Guys,

    In the last week I've been working hard on practically rewriting the plugin. The reason for that is that it was not designed for an easy way for adding/removing a search site. I've created a common interface that all sites must use. Next step is to simplify the usage of the sites. In the end of this process, adding a new search site should be very easy.

    During this work, I've seen some sites that are not working any more, or giving the answer very very slowly:
    • LyricsPlguin.com was already removed (site changed and explicitly requested not to scrap it by any software/plugin...)
    • HotLyrics.net seems to be down but I'm checking an alternative site that has its database. issue #23
    • lyricwiki.org (which is now lyrics.wikia.com) no longer give full lyrics (only 1/7 of it) in the regular way. Their API woks like that too. Will probably be removed too.
    • LyrDb.com seems to work very slow (at least from where I'm trying). It sometimes gives me answers after more than 2 minutes, which is unacceptable (unless it's a batch mode maybe)
    Therefore, I decided to use your help to find new search sites. Preferably, ones with an API, but also sites where it's easy to understand what's the link to the page with the actual lyrics in no more than 2 steps.
    Current list to investigate is:
    You can suggest new search sites in this thread or comment in this issue #17 tracker

    Thanks,
    Yoav
     

    yoavain

    Extension Dev
  • Premium Supporter
  • May 24, 2009
    427
    467
    47
    Home Country
    Israel Israel
    • Thread starter
    • Moderator
    • #70
    Hi,

    Is it possible add http://www.darklyrics.com/ site. I dont know how it works but there find good lyrics.


    Possible...
    However, I'm going to rate each site according to the following:
    • Content of the sites database (mainstream music / language / etc.)
    • Does it have an API
    • Steps needed to get the actual lyrics page
    • Parsing complexity
    This site will not get a very high rating, since it doesn't have an API, requires 2 step parsing mechanism (query & parsing), and since the page can have more than 1 song in it, complexity is high. Regarding the content of the database, we can argue ;)
     

    Users who are viewing this thread

    Top Bottom