My Lyrics 1.8.0 for MP 1.4 / 1.5 (26-07-13) (2 Viewers)

[ysmp]

Hi Guys,
just wont to inform ...no crashes with Defaults skins , and v1.7.3 ...

 

[catavolt]

Yeah, seems there´s something wrong in my skin file - will check

 

[yoavain]

Updated to version 1.7.3. (See OP)

Changes and fixes since version 1.7.2

• Fixed Lyrics007 (rewritten)

Hello yoavain,

I think I encountered an error in version .118

Music database batch search - If I check "Don't search songs already in lyrics database" and then click "Start" the checkbox becomes unselected again and songs already in database are in fact searched for again.

(In Settings i've selected LRC mode, also I have checked "Mark song when no lyric found", "Don't search previously marked songs" and "Don't search songs by Various Artists")

Maybe someone can try to reproduce that error...

Also I've noted with >5.000 songs in database media portal configuration chrashes occasionally due to overflow errors.

Kind regards,
malte71

Thanks for the info!
I found some other issues of inconsistency in the settings tab and in batch search tab, and I am working on fixing them.
I will test the scenario you've described as well.

Regarding the second issue, I haven't had any crashes with a large database. Could you enable logging and logs (lyrics batch log + mp configuration & error log)?[DOUBLEPOST=1372599006][/DOUBLEPOST]

Hi Yoav,
Add in first post skin file for Default 4x3 + screenshots
I zip each skin file so the first post will look more organize ,
As I see there some downloads from her too .. let's live them for some more time ... Even the file are with the plugin .

Thanks for continue updating the plugin .

Thanks!
I've took the new default 4:3 skin files. It will be in the next version.

 

[yoavain]

It will take me some time to publish a new version, as I'm planning a major update.
Next version should include:

• New default 4:3 skin files (thanks ysmp)
• Fix some inconsistency issues in settings tab in configuration
• Change search priority default sites (which ones are for speed search, etc.)
• Fix progress bar issues in batch search
• Removing LyricsPlugin.com. Since site changed again, and this time explicitly requesting not to use scrappers.
• Remove any other site that no longer works. Disable those who are too slow.

 

[Dragy]

Cool. But still no embedded LRC's on the list?

 

[yoavain]

Cool. But still no embedded LRC's on the list?

Might be in too
It's issue #1 in the issue tracker. respect
You can star it to get notifications to your Google account

 

[yoavain]

Cool. But still no embedded LRC's on the list?

Might be in too
It's issue #1 in the issue tracker. respect
You can star it to get notifications to your Google account

Sorry it took so long, but I finally finished my analysis:
" Acda en de Munnik - Groeten uit maaiveld.mp3" contains a newer lyrics tag, called Lyrics3v2 which is not part of the id3v2.3. Lyrics are at the end of the file. (can be identified by the "LYRICSBEGIN")

Other 2 files have id3v2.3 unsychronized lyric inside the id3v2.3 tag at the beginning of the file. (Can be identified by the "USLT")

More info:
Lyrics3v2: http://id3.org/Lyrics3v2
id3v2.3: http://id3.org/id3v2.3.0

I'm not sure if this lyrics tag is parsed by MediaPortal.
Also, I don't think this should be done from within the plugin, but as a service from MP.

 

[malte71]

Thanks for the info!
I found some other issues of inconsistency in the settings tab and in batch search tab, and I am working on fixing them.
I will test the scenario you've described as well.

Regarding the second issue, I haven't had any crashes with a large database. Could you enable logging and logs (lyrics batch log + mp configuration & error log)?

Here are the logs and a screenshot of a recent crash.

Btw. I also noted that it seems to be possible to check "Don't search previously marked songs" and "Search for marked songs only" at the same time.

Kind regards,
malte71

 

[Dragy]

Thanks! So, I understand that if MP does not support this parsing, you won't implement it. That's okay for me, I think that 95% of the mp3's I have contain just the id3v2.3 synchronized lyrics, or both Lyrics3v2 and id3 tags. I see in my MiniLyrics configuration that I now save the lyrics in both formats:

But as far as I know, none of the embedded synchronized lyrics show up in the plugin

 

[catavolt]

@sdf, @yoavain, here we go:
The crash in PureVisionHD came from some properties with hardcoded IDs which I commented out!
This must not happen - a skinner should have the freedom to show/not to show properties with hardcoded IDs.
So I now moved these properties outside the screeen, and no longer crashes.
Pls find enclosed the corrected XML for PureVisionHD 1080