MyFilms Mod: Adds Titles as folders, position memory & half stars (1 Viewer)

[zebons]

Yer I commented out just the lines added in the second green block here:-

http://mp-plugins.svn.sourceforge.n...unk/plugins/MyFilms/MesFilms.cs?r1=229&r2=260

and then it works nice n' slick

Also adding a
save_config_values();
before
line1386 mydivx.Clear();
(1386 is relevant to current svn code here http://mp-plugins.svn.sourceforge.n.../MyFilms/MesFilms.cs?revision=260&view=markup )

That sorts out storing the current positional & other settings when they switch view as currently they aren't being saved, I forgot before oops! Tested this end and working good

Corrections done SVN 263.

 

[HappyTalk]

OK The only thing now though is that if you press esc on a dialog in MP it normally just returns back to where you were, but in the case of the user views dialog pressing esc exits the plugin.

 

[zebons]

OK The only thing now though is that if you press esc on a dialog in MP it normally just returns back to where you were, but in the case of the user views dialog pressing esc exits the plugin.

I think corrected with last SVN (266). I also add a clean 'last position' function when exiting setup : during my tests, I encountered a bug (sometimes but I don't really identify when...) with a lastdID = 7987 and no l_index... and no other possibility than suppress those informations by editing the xml file :-(( It's not a good idea !

So to resolve the problem if some users found it, they can suppress it by entering in the setup....

 

[HappyTalk]

I think corrected with last SVN (266). I also add a clean 'last position' function when exiting setup : during my tests, I encountered a bug (sometimes but I don't really identify when...) with a lastdID = 7987 and no l_index... and no other possibility than suppress those informations by editing the xml file :-(( It's not a good idea !

So to resolve the problem if some users found it, they can suppress it by entering in the setup....

So every time I enter MyFilms setup to alter something I will lose the last position? Hmm I don't like the sound of that, I'd rather track down the bug if you describe what is than use a sledgehammer approach of having to run setup to clear the problem. In my original code if an invalid ID was supplied it reset the position to the first item.

BTW this whole approach you added to dealing with LastConfig = "" triggers an exception in GuiWindowManager.cs "{"There is no row at position -1."}" which appears in the MP error log. To make it happen Set LastConfig="" (edit films.xml is easiest), run MyFilms, view selector pops up, press esc.

I fixed it last night in a diff way to avoid this, but then the svn got updated, so I merged to that svn, but its changed again. I'll re-merge and add it so you can see.


Hmmm svn didn't offer me choice to merge with current code as it usually does??? I'll have to re-add the ant pic stuff you added in last revision

 

[zebons]

I think corrected with last SVN (266). I also add a clean 'last position' function when exiting setup : during my tests, I encountered a bug (sometimes but I don't really identify when...) with a lastdID = 7987 and no l_index... and no other possibility than suppress those informations by editing the xml file :-(( It's not a good idea !

So to resolve the problem if some users found it, they can suppress it by entering in the setup....

So every time I enter MyFilms setup to alter something I will lose the last position? Hmm I don't like the sound of that, I'd rather track down the bug if you describe what is than use a sledgehammer approach of having to run setup to clear the problem. In my original code if an invalid ID was supplied it reset the position to the first item.

BTW this whole approach you added to dealing with LastConfig = "" triggers an exception in GuiWindowManager.cs "{"There is no row at position -1."}" which appears in the MP error log. To make it happen Set LastConfig="" (edit films.xml is easiest), run MyFilms, view selector pops up, press esc.

I fixed it last night in a diff way to avoid this, but then the svn got updated, so I merged to that svn, but its changed again. I'll re-merge and add it so you can see.


Hmmm svn didn't offer me choice to merge with current code as it usually does??? I'll have to re-add the ant pic stuff you added in last revision

I download your code (268) and got a bug when re-enter in the plugin with my database :-((( No display and I cann't exit MP !!! It's seems to work with yours.
In that case a clean of the 'last position' function is usefull !
I have to find the pb :-((((

 

[HappyTalk]

When I was stepping through the code in the debugger I noticed various 'unlikely' but possible scenarios that would make the code go off into the unknown. I fixed some of them, but possible bad scenarios, that I'm not sure if accounted for.

If LastConfig = "MyView2", then in setup this view is deleted, then plugin is re-run? (ie is LastConfig set = "" so they will be prompted if prev view is deleted)


I think MyFilms is pretty solid, these are just the outer limits bugs. Deffo my fav MP Plug. BTW if it locks are you not able to ctrl-break in debugger and check call stack to see where its at?

 

[zebons]

When I was stepping through the code in the debugger I noticed various 'unlikely' but possible scenarios that would make the code go off into the unknown. I fixed some of them, but possible bad scenarios, that I'm not sure if accounted for.

If LastConfig = "MyView2", then in setup this view is deleted, then plugin is re-run? (ie is LastConfig set = "" so they will be prompted if prev view is deleted)


I think MyFilms is pretty solid, these are just the outer limits bugs. Deffo my fav MP Plug. BTW if it locks are you not able to ctrl-break in debugger and check call stack to see where its at?

I found my previous bug but I encountered another error :
When I do a Change View or a research by Films or Actors and then press 'H' key, next rerun , the last position is not active :-(
I think that values aren't taken into account at the rerun.. I'll take a look. Don't do modif during if you don't want to merge the code another time ;-))
Thanks.

 

[zebons]

When I was stepping through the code in the debugger I noticed various 'unlikely' but possible scenarios that would make the code go off into the unknown. I fixed some of them, but possible bad scenarios, that I'm not sure if accounted for.

If LastConfig = "MyView2", then in setup this view is deleted, then plugin is re-run? (ie is LastConfig set = "" so they will be prompted if prev view is deleted)


I think MyFilms is pretty solid, these are just the outer limits bugs. Deffo my fav MP Plug. BTW if it locks are you not able to ctrl-break in debugger and check call stack to see where its at?

I found my previous bug but I encountered another error :
When I do a Change View or a research by Films or Actors and then press 'H' key, next rerun , the last position is not active :-(
I think that values aren't taken into account at the rerun.. I'll take a look. Don't do modif during if you don't want to merge the code another time ;-))
Thanks.

Corrected in SVN(270) merge with ours (269).

 

[HappyTalk]

It remembers exactly where you are under normal single view useage with a different sort, but as the user-views were added subsequently to the folder code there may be some new unnaccounted for situations. I will try and thoroughly test it later and list all weird scenarios.

But a quick test reveals that maybe what needs to be examined is that when you switch view does it effectively do everything that is done when first starting up the plug?

 

[zebons]

It remembers exactly where you are under normal single view useage with a different sort, but as the user-views were added subsequently to the folder code there may be some new unnaccounted for situations. I will try and thoroughly test it later and list all weird scenarios.

But a quick test reveals that maybe what needs to be examined is that when you switch view does it effectively do everything that is done when first starting up the plug?

User-views were not added subsequently to the folder code, it was already coded in the previous version !
I think it's now working with latest mod (270).