MyLyrics v. 1.00 (2 Viewers)

[mackey]

Ok Soren, thanks for your help, Ill give that a go. The interesting thing is that I installed MyLyrics onto an already working MP 0.2.3.0 with a much earlier version of MyLyrics.

So did earlier versions of did MyLyrics not use GetTotalSongs ?

Ahhh, my mistake. The method GetTotalSongs() is most likely the method that was used by earlier versions of MyLyrics. When MP implemented a new music database a new method was implemented for me, which has a very similar name. Sorry for my confusion, but I haven't named this method, cannot really remember the name of the new method, and haven't had the time to actually look into my code.

But the thing is, it is most likely the installation of MyLyrics that in some way failed. Perhaps not all step of the MPI installation was performed, or the plugin was installed into a wrong folder. Try to do the MPI installation of MyLyrics once again, or perhaps the best approach would be to manually delete the LyricsEngine.dll in the MP base library and the MyLyrics.dll in plugins/windows/ lib. And then do a new install using MPI. Then the old version of MyLyrics should be deleted permanently and the new version 1.0 installed.

 

[Kingmob]

I have a few suggestions, it's quite a list, but i am not good enough a programmer (yet) to do this myself.
1. Can you create some sort of lrc preference? So even when only a txt file is found at first, it will always look for an lrc if you play that song?
2. Can you make the plugin search in the directory of the mp3 (and even give that preference). I have loads of lrc files next to my mp3 through minilyrics. I see i can add them in the configuration, but this doesn't work well if i do my whole music directory at once (it gives me strange errors) and doing it artist by artist is a hassle (especially since it changes).
3. can you add minilyrics to the search. I have this program and it has an awesome database. it is not freeware, but a plugin has enabled me to use it in mediamonkey

And finally a question. I let your plugin accidentally write all lyrics to the tags, now it seems to prefer thise to lrc files, certainly not what i want. is there an easy way to clear all lyrics?

[edit]I solved my problem at 2 by doing a search for .lrc and copying them all to a directory, this directory i then manually import. It works for now, but automatic lookup during playing would still be nice

[edit2]The error i get (even while doing the above trick) is: "Error: Object reference not set to an instance of an object". It stops adding files after that. There seems to be something wrong with individual lrc files, but i can't find out what.

Btw, thanks for updating the plugin

 

[mackey]

I have a few suggestions, it's quite a list, but i am not good enough a programmer (yet) to do this myself.
1. Can you create some sort of lrc preference? So even when only a txt file is found at first, it will always look for an lrc if you play that song?
2. Can you make the plugin search in the directory of the mp3 (and even give that preference). I have loads of lrc files next to my mp3 through minilyrics. I see i can add them in the configuration, but this doesn't work well if i do my whole music directory at once (it gives me strange errors) and doing it artist by artist is a hassle (especially since it changes).
3. can you add minilyrics to the search. I have this program and it has an awesome database. it is not freeware, but a plugin has enabled me to use it in mediamonkey

And finally a question. I let your plugin accidentally write all lyrics to the tags, now it seems to prefer thise to lrc files, certainly not what i want. is there an easy way to clear all lyrics?

[edit]I solved my problem at 2 by doing a search for .lrc and copying them all to a directory, this directory i then manually import. It works for now, but automatic lookup during playing would still be nice

[edit2]The error i get (even while doing the above trick) is: "Error: Object reference not set to an instance of an object". It stops adding files after that. There seems to be something wrong with individual lrc files, but i can't find out what.

Btw, thanks for updating the plugin

Hi Kingmob

1. You are right about the lrc-files; they should get a higher preference than ordinary lyric files, and I'll include this in the next release.
2. I'll consider to look for lrc-files in the same directory as the music files, but it is not a high priority since there are many ways for the user to include the lrc files in the lyrics library quite easily. I will look into the error you describe and fix it if I can reproduce it.
3. I don't believe it is possible to possible to connect to minilyrics, since you don't offer an interface or alike for programmers to use. It is a commercial product who have no interest in opening up there source and/or database for open source-projects like our.

regards
Soren

 

[Kingmob]

Thx for the reply, number 1 has the highest priority anyway i guess, so thanks for listening

 

[coopers]

Am I right in saying that I can go into My Music and play an MP3 and then view the lyrics from there?

cos that is what I would like to do...

Or is the only way to view the lyrics associated with the playing mp3 file to back out the top level and then go into the "my lyrics" plugin? Is there a way to do what I want?

Otherwise, everything is great with this plugin - very easy to use.

 

[HappyTalk]

I looked at this plug over a year ago, but it wasn't able to do that then, in the way xbmc would, so I never installed it. This plugin seems to focus on actually going off to internet servers and getting the lyrics, something I would choose to do with an external app, (not sure if Tag&Rename does it yet?) which would then embed the lyrics for a plugin to pick up. Not sure why you would want to do admin type stuff 'WITHIN' a tv app.

My ideal would be a new slimmed down 'media' plugin for MP that is a simple file explorer able to play music/videos/photos and that offers a show-lyrics option in the music options, which if on would instead of showing swirlie patterns when you go full screen while playing music, would show/scroll the lyrics (maybe with the swirlies subtly in the background). Nice and simple, with a single on/off option, done! (also that uses the standard windows thumbnails for things, instead of creating 10,000's on my hd)

 

[mackey]

Am I right in saying that I can go into My Music and play an MP3 and then view the lyrics from there?

cos that is what I would like to do...

Or is the only way to view the lyrics associated with the playing mp3 file to back out the top level and then go into the "my lyrics" plugin? Is there a way to do what I want?

Otherwise, everything is great with this plugin - very easy to use.

Hi

The plugins have no limitations concerning the integration into MyMusic. However, as a simple plugin dev I have no permission to bulid the feature into the music core as such. Therefore each skin developer have to include a shorcut to the MyLyrics screen in the MyMusic for the user to access the lyrics more easily.

Skins such as the 3 Electric's, Replicant, ReVision and surely others have done exactly that.

I looked at this plug over a year ago, but it wasn't able to do that then, in the way xbmc would, so I never installed it. This plugin seems to focus on actually going off to internet servers and getting the lyrics, something I would choose to do with an external app, (not sure if Tag&Rename does it yet?) which would then embed the lyrics for a plugin to pick up. Not sure why you would want to do admin type stuff 'WITHIN' a tv app.

??? I would strongly advise you to try the plugin before commenting its functionality...
1. The plugin is not related to the tv section of MP at all and MP is not a tv app (cannot quite see which of these you believe)
2. All admin stuff is done in the configuration, not within MP
3. The plugin primary shows lyrics in MP; as a bonus it will automatically fetch lyrics for songs which not already have one
4. Tag&Rename does not have a lyrics fetching functionality
5. Why use an external app which costs money (at least I don't know of a free lyrics fetching app) when MyLyrics is free?

regards
mackey

 

[coopers]

Thankyou Mackey, I will try a different skin.

I have some suggestions for your future development of the plugin (don't get me wrong, it's great now):
- it would be good to have a "blacklist" of tracks/albums that are never searched for lyrics in the configuration. Currently you basically have those that are "marked" (can't find lyrics for) and "not marked". It is still my goal to find lyrics for all the "marked" files - however there are some I would like to exclude from the search forever, because lyrics will simply not be found (ie, they are my recordings, or lectures, or comedians, or the track is completely acoustic). This would speed up the search a lot and also show me at a glance what tracks don't yet have lyrics.

- It would be great to be able to search for lyrics by album, not just artist (I don't know if that is possible with the sites you are using to search on).

- It would be good to have a convenient way of (when doing manual lyric search) telling the searcher to ignore everything to the left of a "|" or a "<" (or various other annoying symbols) as I have a lot of these situations as the "artist" in my tags, and really the search is successful if you just manually remove that.

- It would be good to be able to select multiple items to search manually for - for example if I select multiple items and then force the artist to be the same thing for all of them yet leave the track names as they were.

- Also, once you have successfully/unsuccessfuly manually searched for a tracks lyrics, the column of all "marked" files jumps back to the top, and you lose your place - if it could stay with track I just searched for selected, then I wouldn't lose my place.

- full integration into mymusic plugin (it would be nice to see the lyrics scroll up the screen while the screen is doing it's animation/displaying the album art). I expect like you said this is a big problem, maybe it's possible in media portal 2? Who knows.

Thanks for a great plugin!

 

[mackey]

Hi coopers

Thanks a lot for the great suggestions. Some of them is certainly worth implementing while others might be relevant as well.

regards
mackey

 

[HappyTalk]

The plugins have no limitations concerning the integration into MyMusic. However, as a simple plugin dev I have no permission to bulid the feature into the music core as such. Therefore each skin developer have to include a shorcut to the MyLyrics screen in the MyMusic for the user to access the lyrics more easily.

Are you saying if you have a playlist running you will have to press a button every time a new song is played to bring the lyrics up?

The reason I hadn't re-tried it is it was my understanding that it still wasn't automated to play when a song played in my music, still am unsure? You can add code to the MyMusic core and post it on sourceforge and a dev will add it, or may give you svn write access to add it yourself if it needs to hook in somewhere.

I'm sure you've spent a lot of time on it but from my POV lack of seamless integration into MyMusic was why I didn't use it, no matter how awesome it might be.

I see in the Music section of MP config on the 'now playing' tab|visualisation options|Show Lyrics but it's grayed out. I'd hoped that you'd just turn that option on and that's it, any mp3's with a lyrics tag shows lyrics as the visualisation option, simple as... wouldn't need a plug or anything (PS a guitar tab version would be cool too!)

I did use to use this feature in xbmc, you could also use karaoke stuff converted to mp3+some other file, used to be loads of em on usenet