New Music Database | Page 9

Discussion in 'Listen Music' started by hwahrmann, September 27, 2007.

  1. rtv
    • Team MediaPortal

    rtv Retired Team Member

    Joined:
    April 7, 2005
    Messages:
    3,622
    Likes Received:
    301
    Occupation:
    CTO at ES2000
    Location:
    Osnabruck
    Ratings:
    +301 / 0
    Home Country:
    Germany Germany
    Show System Specs
    Since I even got that album on Vinyl I'll look at the code to see what happens there. :D


     
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. Matty
    • Premium Supporter

    Matty MP Donator

    Joined:
    January 3, 2007
    Messages:
    63
    Likes Received:
    1
    Gender:
    Male
    Occupation:
    Developer
    Location:
    Sydney
    Ratings:
    +1 / 0
    Home Country:
    Australia Australia
    Show System Specs
    rtv,

    I've done a bit of digging into the issue and problem is being introduced by the method
    MediaPortal.Database.DatabaseUtility.RemoveInvalidChars(ref string) when used in
    MusicDatabase.Updates.cs, MediaPortal.Music.Database.MusicDatabase::GetTag(string strFileName).

    I hope this save some time. :)
     
  4. Roo

    Roo Portal Member

    Joined:
    January 7, 2007
    Messages:
    24
    Likes Received:
    1
    Ratings:
    +1 / 0
    Home Country:
    United Kingdom United Kingdom
    Just discovered this same problem on my setup and came to the forums to see if I needed to post it or not.

    Only appear to have 13 albums affected so I guess I'll do a quick bit of renaming of the thumbs for the meantime.

    Hope it's an easy fix for you rtv.
     
  5. rtv
    • Team MediaPortal

    rtv Retired Team Member

    Joined:
    April 7, 2005
    Messages:
    3,622
    Likes Received:
    301
    Occupation:
    CTO at ES2000
    Location:
    Osnabruck
    Ratings:
    +301 / 0
    Home Country:
    Germany Germany
    Show System Specs
    Hehe - nice to see you're caring for it as well ;)

    Well the problem is not that easy.. If everything would use that function (that would have to be checked itself as well) everything was alright. Unfortunately filesystems do not allow different chars then those not supported by the database.
    So filenames (e.g. for cover files) use Makefilename and similar functions which might "clean" different chars than RemoveInvalidChars :(

    Furthermore this (of course) is not only a problem specific for cover art or music in general but for every part of MP.

    So even with much work fixing all places by using a common function which substitutes ALL chars that are not supported it would at least demand a complete rebuild of ALL databases and ALL thumbnails. On the other side this could be considered a needed change - therefore the earlier the better...
     
    • Like Like x 1
  6. rsbrux
    • Team MediaPortal

    rsbrux Documentation Group

    Joined:
    April 15, 2007
    Messages:
    1,022
    Likes Received:
    67
    Ratings:
    +91 / 1
    Home Country:
    Switzerland Switzerland
    Show System Specs
    Hi rtv,
    If you're looking for encouragement, I consider a DB and thumbnail rebuild a small price to pay for a consistent UI!
    Thanks for all your good work!
     
  7. Matty
    • Premium Supporter

    Matty MP Donator

    Joined:
    January 3, 2007
    Messages:
    63
    Likes Received:
    1
    Gender:
    Male
    Occupation:
    Developer
    Location:
    Sydney
    Ratings:
    +1 / 0
    Home Country:
    Australia Australia
    Show System Specs
    rtv,

    I wasn't suggesting that DatabaseUtility.RemoveInvalid required the changes to resolve the problem, I was just highlighting where the issue occurs.

    Thanks for looking into it.
     
  8. rtv
    • Team MediaPortal

    rtv Retired Team Member

    Joined:
    April 7, 2005
    Messages:
    3,622
    Likes Received:
    301
    Occupation:
    CTO at ES2000
    Location:
    Osnabruck
    Ratings:
    +301 / 0
    Home Country:
    Germany Germany
    Show System Specs
    The next SVN build will include some fixes regarding the apostrophe issues. However after some more checks I've found out that the underscore has been an issue which should be fixed for some weeks already. To be safe you should delete those files containing "_-" and rescan your collection again to build the proper cover art.
     
  9. Matty
    • Premium Supporter

    Matty MP Donator

    Joined:
    January 3, 2007
    Messages:
    63
    Likes Received:
    1
    Gender:
    Male
    Occupation:
    Developer
    Location:
    Sydney
    Ratings:
    +1 / 0
    Home Country:
    Australia Australia
    Show System Specs
    RTV,

    Thanks, great job. I've installed 16525 and all is good.
    No underscores or double apsotrophes.
     
  10. rsbrux
    • Team MediaPortal

    rsbrux Documentation Group

    Joined:
    April 15, 2007
    Messages:
    1,022
    Likes Received:
    67
    Ratings:
    +91 / 1
    Home Country:
    Switzerland Switzerland
    Show System Specs
    Just installed 2.3.0 stable release and rescanned my music collection (after deleting MusicDatabase files).
    Everything seems to be there, but there are very few album cover graphics.
    I have folder.jpg for almost everything, and all appeared correctly in 2.3.0 RC2.
    Any idea what could be wrong here?
    Configuration log attached.

    P.S. I am now gradually seeing album covers. Maybe their absence was due to my having cleared the folder cache and having selected "Create folder cache on demand".
     
  11. Freeman-TK

    Freeman-TK Portal Member

    Joined:
    November 24, 2007
    Messages:
    7
    Likes Received:
    0
    Ratings:
    +0 / 0
    wheres the download???
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!