[Bug] No comskip chapter markers in 1.6.0 pre release + Titan (1 Viewer)

catavolt · December 30, 2013

And we really shouldn´t revert it again - I read in some other thread that the markers were shown correctly in Default skins, but not in Titan Extnded

elliottmc · December 30, 2013

HomeY said:
Reverting 4202 doesn't bring ComSkip markers on the pause OSD, but besides that i think i messed up my previous tests with the wrong recording (2 identical filnames, 1 only has markers), so here's the new results with current master:

TvRecordings First Info OSD No Markers
TvRecordings Second Info OSD Markers visible
TvRecordings Pause OSD No Markers
MyVideos Info OSD Markers visible
MyVideos Pause OSD No Markers

Reverting 4202 doesn't change the above.

So fundamentally the problem is pretty simple. The comskip markers are shown correctly apart from with the pause OSD.

@catavolt - which file provides the pause OSDs?

@HomeY - is this the same with all skins, or just with Titan?

Perhaps you could post a comskip data file and I can help with the testing.

HomeY · December 30, 2013

elliottmc said:
HomeY - is this the same with all skins, or just with Titan?

Perhaps you could post a comskip data file and I can help with the testing.

Yeps, the same for both Titan & DW.
Attached a ComSkip file (only needs renaming)

elliottmc · December 30, 2013

Okay, when I start a video with comskip markers, I see this

Code:

[2013-12-30 14:03:39,487] [Log  ] [MPMain  ] [INFO ] - g_Player.OnStarted() E:\Martial Arts\Rick Clark - Vital Point Techniques.mp4 media:Video
[2013-12-30 14:03:39,506] [Log  ] [MPMain  ] [DEBUG] - g_Player: ShowFullScreenWindow
[2013-12-30 14:03:39,508] [Log  ] [MPMain  ] [INFO ] - g_Player: ShowFullScreenWindow switching to fullscreen video
[2013-12-30 14:03:39,513] [Log  ] [44  ] [DEBUG] - PlaneScene: PresentImage() dispose surfaces
[2013-12-30 14:03:39,540] [Log  ] [MPMain  ] [DEBUG] - Window: MediaPortal.GUI.Video.GUIVideoFiles deinit
[2013-12-30 14:03:39,582] [Log  ] [MPMain  ] [DEBUG] - TextureManager: CleanupThumbs()
[2013-12-30 14:03:39,608] [Log  ] [MPMain  ] [DEBUG] - Window: MediaPortal.GUI.Video.GUIVideoFullscreen init
[2013-12-30 14:03:39,610] [Log  ] [MPMain  ] [DEBUG] - Loading AR modes from "movies" section...
[2013-12-30 14:03:39,672] [Log  ] [43  ] [DEBUG] - PlaneScene: crop T, B  : 0, 0
[2013-12-30 14:03:39,673] [Log  ] [43  ] [DEBUG] - PlaneScene: crop L, R  : 0, 0
[2013-12-30 14:03:39,673] [Log  ] [43  ] [INFO ] - PlaneScene: video WxH  : 480x360
[2013-12-30 14:03:39,673] [Log  ] [43  ] [DEBUG] - PlaneScene: video AR  : 4:3
[2013-12-30 14:03:39,674] [Log  ] [43  ] [INFO ] - PlaneScene: screen WxH : 1680x1050
[2013-12-30 14:03:39,674] [Log  ] [43  ] [DEBUG] - PlaneScene: AR type  : Stretch
[2013-12-30 14:03:39,674] [Log  ] [43  ] [DEBUG] - PlaneScene: PixelRatio : 1
[2013-12-30 14:03:39,675] [Log  ] [43  ] [DEBUG] - PlaneScene: src  : (0,0)-(480,360)
[2013-12-30 14:03:39,675] [Log  ] [43  ] [DEBUG] - PlaneScene: dst  : (0,0)-(1680,1050)
[2013-12-30 14:03:39,706] [Log  ] [MPMain  ] [WARN ] - GUIWindow:OnWindowLoaded: 'C:\ProgramData\Team MediaPortal\MediaPortal\Skin\Titan\myVideo.xml' is missing control id 6 (window property: btnPlayDVD)
[2013-12-30 14:03:39,707] [Log  ] [MPMain  ] [WARN ] - GUIWindow:OnWindowLoaded: 'C:\ProgramData\Team MediaPortal\MediaPortal\Skin\Titan\myVideo.xml' is missing control id 8 (window property: btnTrailers)
[2013-12-30 14:03:39,804] [Log  ] [MPMain  ] [DEBUG] - VMR9Helper: Playing -> Repainting, Frames 57
[2013-12-30 14:03:39,818] [Log  ] [43  ] [INFO ] - planescene:PresentImage() frame:57 enabled:True allowed:False
[2013-12-30 14:03:39,826] [Log  ] [MPMain  ] [DEBUG] - VMR9: Repainting -> Playing, Frames: 58
[2013-12-30 14:03:42,132] [Log  ] [43  ] [DEBUG] - GUITVProgressControl.parseMarkerValues() - parsing markers
[2013-12-30 14:03:42,132] [Log  ] [43  ] [DEBUG] - GUITVProgressControl.parseMarkerValues() - found 2

on the first time.

I guess the key lines of code are

[2013-12-30 14:03:42,132] [Log ] [43 ] [DEBUG] - GUITVProgressControl.parseMarkerValues() - parsing markers
[2013-12-30 14:03:42,132] [Log ] [43 ] [DEBUG] - GUITVProgressControl.parseMarkerValues() - found 2

and I note that this is a video file, played in 'My Videos' and it is still calling 'GUITVProgressControl', which seems odd. Why is it not using GUIProgressControl?

If I stop the playback and play the same file again, I don't see these two lines. Maybe it doesn't need to check, since it is the same file.

In videoOSD.xml we have

Code:

  <control>
  <description>Progress Bar</description>
  <type>tvprogress</type>
  <id>105</id>
     <posX>578</posX>
     <posY>909</posY>
     <width>758</width>
     <height>15</height>
  <toptexture>-</toptexture>
  <TextureOffsetY>0</TextureOffsetY>
  <bottomtexture>-</bottomtexture>
  <texturetick>-</texturetick>
  <lefttexture>osd_progress_left.png</lefttexture>
  <midtexture>-</midtexture>
  <righttexture>-</righttexture>
  <logotexture>-</logotexture>
  <fillbackgroundtexture>-</fillbackgroundtexture>
  <fillbgxoff>-3</fillbgxoff>
  <fillbgyoff>0</fillbgyoff>
  <filltexture1>osd_progress_mid.png</filltexture1>
  <filltexture2>osd_progress_mid.png</filltexture2>
  <filltexture3>osd_progress_mid_orange.png</filltexture3>
  <markertexture>osd_progress_comskip_marker.png</markertexture>
  <fillheight>15</fillheight>
  <label>#percentage</label>
  <label1>#percent2</label1>
  <label2>#percent3</label2>
  <labelmarkerstarts>#jumppoints</labelmarkerstarts>
  <labelmarkerends>#chapters</labelmarkerends>
  </control>

with the #jumppoints and #chapters being the key information I think!

In videoFullScreen.xml we have

Code:

    <control>
       <description>Progress Bar</description>
       <type>progress</type>
       <id>1</id>
     <posX>578</posX>
     <posY>909</posY>
     <width>758</width>
     <height>15</height>
     <label>#percentage</label>
     <texturebg>-</texturebg>
     <lefttexture>osd_progress_left.png</lefttexture>
     <midtexture>osd_progress_mid.png</midtexture>
     <righttexture>osd_progress_right.png</righttexture>
       <label>#percentage</label>
       <visible>control.isVisible(111)|control.isVisible(10)|control.isVisible(11)|control.isVisible(12)</visible>
     </control>

so no jumppoints or chapters. However, these have never been there, so if it worked before, they must have been provided elsewhere.

Are we 100% sure that the comskip markers have been shown in the pause OSD in 'My Videos' in 1.5.0 or earlier?

elliottmc · December 30, 2013

The DefaultWide videoFullScreen.xml has

Code:

  <control>
  <description>Progress Bar</description>
  <type>tvprogress</type>
  <id>1</id>
  <posX>220</posX>
  <posY>627</posY>
  <width>686</width>
  <height>17</height>
  <toptexture>osd_progress_indicator.png</toptexture>
  <TextureOffsetY>23</TextureOffsetY>
  <bottomtexture>-</bottomtexture>
  <texturetick>-</texturetick>
  <lefttexture>osd_progress_left.png</lefttexture>
  <midtexture>-</midtexture>
  <righttexture>-</righttexture>
  <logotexture>-</logotexture>
  <fillbackgroundtexture>-</fillbackgroundtexture>
  <fillbgxoff>-3</fillbgxoff>
  <fillbgyoff>0</fillbgyoff>
  <filltexture1>osd_progress_mid.png</filltexture1>
  <filltexture2>osd_progress_mid.png</filltexture2>
  <filltexture3>osd_progress_mid_orange.png</filltexture3>
  <markertexture>osd_progress_mid_orange.png</markertexture>
  <fillheight>17</fillheight>
  <label>#percentage</label>
  <labelmarkerstarts>#jumppoints</labelmarkerstarts>
  <labelmarkerends>#chapters</labelmarkerends>
  <visible>control.isVisible(111)</visible>
  </control>

so it does have the chapters and jumppoints, even through they don't work.

Also note that in

https://github.com/MediaPortal/MediaPortal-1/commit/dd8f1b7c043bb64dc027df63ddac8e88a6abb221

this control was changed to a 'tvprogress' type, although Titan is inconsistent with this.

I think it is fair to say that there are serious issues with the progress bars. If I change the type in DefaultWide to 'progress' then I see no 'slider' at all. However, with Titan this is a 'progress' type and I do see the 'slider'.

So, we have a serious lack of consistency here and bugs.

Who can help?

@ncoH @catavolt @michael_t @mattjcurry ?

catavolt · December 30, 2013

Don´t mix up progress and tvprogress - both exist since begin of MP

progress can be used with any control where you want to see a progressbar - tvprogress is a different thing and works especially for TV/Recordings because it has some more/different properties

elliottmc · December 30, 2013

catavolt said:
Don´t mix up progress and tvprogress - both exist since begin of MP
progress can be used with any control where you want to see a progressbar - tvprogress is a different thing and works especially for TV/Recordings because it has some more/different properties

Yes, so why is the pause OSD for video using a 'tvprogress' control ?

Another thing I have just noticed. I am using the sample comskip marker file from @HomeY which has one 'commercial' block early in the file. I am now watching the video, and I am past the point of the comskip marker. Now when I bring up the 'info' OSD, I don't see the comskip marker. Is this because the progress bar is drawn over the top ? @HomeY - could you test and confirm?

Either way, it looks like the comskip markers are a bit of a mess, and I'd like to propose that for 1.7.0 we take a long look at all of the OSDs and fix them to be consistent.

catavolt · December 30, 2013

elliottmc said:
Yes, so why is the pause OSD for video using a 'tvprogress' control ?

Due to the fix of the comskip markers, it was introduced to videoOSD.xml as well - but better ask the responsible dev

elliottmc · December 30, 2013

catavolt said:
elliottmc said:

Yes, so why is the pause OSD for video using a 'tvprogress' control ?

Click to expand...

Due to the fix of the comskip markers, it was introduced to videoOSD.xml as well - but better ask the responsible dev

I've been asking.

Fundamentally, do we really need to have all these different progress controls? If so, why ? I'd prefer to have a single progress control so that we never get into this sort of mess where we break one part of a feature and leave other parts working. Or in this case we can use a different control in the same area in one skin and not in another.

catavolt · December 30, 2013

elliottmc said:
Fundamentally, do we really need to have all these different progress controls?

I don´t think so - one progress property should be enough if it has all the possibilites integrated - but we might think about that and put it on the list for 1.7

There are also some display problems if you use the inbuilt function for a progress background which would make skinning a lot easier.
In the actual implementation using a background integrated in the progressbar will always have an offset.
And if you look closely in your DW excerpt above, you´ll see that the progress background and the progressbar have different lengths to work correctly - this all can/should be solved

[Bug] No comskip chapter markers in 1.6.0 pre release + Titan (1 Viewer)

catavolt

Design Group Manager

elliottmc

Retired Team Member

HomeY

Test Group

Attachments

elliottmc

Retired Team Member

elliottmc

Retired Team Member

catavolt

Design Group Manager

elliottmc

Retired Team Member

catavolt

Design Group Manager

elliottmc

Retired Team Member

catavolt

Design Group Manager

Users who are viewing this thread