[Bug] No comskip chapter markers in 1.6.0 pre release + Titan (1 Viewer)

[catavolt]

Don´t know what happened - but in Default skins they were in - after checking now they´re gone

*** EDIT: *** They´re in - looked in wrong folder

 

[catavolt]

Gives exactly the same results as Titan.

The markers are in and correct - so it must work

 

[HomeY]

Don´t know what happened - but in Default skins they were in - after checking now they´re gone

Must be the ghost of Christmas Present!!

The markers are in and correct - so it must work

But it does not.

 

[catavolt]

Pls re-read my posts - they´re in and should work

 

[HomeY]

I did, and i can test what i want, but i don't see them.

 

[popy]

Here are my results:

Titan Skin
TvRecordings First Info OSD No Markers
TvRecordings Second Info OSD Markers visible
TvRecordings Pause OSD No Markers
MyVideos Info OSD No Markers
MyVideos Pause OSD No Markers

DefaultWide
Gives exactly the same results as Titan.

Thread set to 'Bug'

MP1-4330 - ComSkip markers not showing in TvRecordings/MyVideo OSDs

Exactly the same for me.
thx for setting the thread to bug.

pOpY

 

[elliottmc]

The only thing in 1.6.0 Pre Release that should affect comskip markers is

https://github.com/MediaPortal/MediaPortal-1/commit/207ee44ac0b8c1f7088d70192adcb6d6e287192b

https://issues.team-mediaportal.com/browse/MP1-4202

This was pretty carefully tested, but it should be possible to revert this one commit and see if this helps. I am happy to produce a version of current master (effectively the 1.6.0 final that we are testing) with this commit reverted in order to see if it fixes this issue, but I have some reluctance to put out a build of 1.6.0 which I guess many people will download and use even though it will then by implication have issues.

Since this commit was from @michael_t, perhaps he has some comments?

 

[HomeY]

I am happy to produce a version of current master (effectively the 1.6.0 final that we are testing) with this commit reverted in order to see if it fixes this issue...

I'll give you the test results of this in a bit

 

[HomeY]

Got a conflict when i revert that branch. Fixed and building now, but not sure if this will be a proper test.
Looking at the commit message, i'm not sure if a revert is gonna help us, because:

MP1-4202 : Comskip markers are now updated in MediaPortal.cs

- reverted changes in TVHome.cs and GUIVideoFiles.cs
- reverted changes in GUITVProgressControl.cs
- added #chapters and #jumppoints to PropertyManager.cs
- #TV.Record.chapters and #TV.Record.jumppoints do no longer exist
- so skin files have been modified

 

[HomeY]

Reverting 4202 doesn't bring ComSkip markers on the pause OSD, but besides that i think i messed up my previous tests with the wrong recording (2 identical filnames, 1 only has markers), so here's the new results with current master:

TvRecordings First Info OSD No Markers
TvRecordings Second Info OSD Markers visible
TvRecordings Pause OSD No Markers
MyVideos Info OSD Markers visible
MyVideos Pause OSD No Markers

Reverting 4202 doesn't change the above.