[Approved] - Option to disable 'Stop live TV' dialog | Page 7

Discussion in 'Submit: code patches (MediaPortal/TV-Server/etc.)' started by jonywee, February 10, 2013.

  1. seco
    • Team MediaPortal

    seco Development Group

    Joined:
    August 7, 2007
    Messages:
    1,579
    Likes Received:
    897
    Gender:
    Male
    Ratings:
    +1,234 / 4
    Home Country:
    Finland Finland
    Show System Specs
    My suggestion



    1. Rename Notifier -> Notifications
    2. Add option to TV notifications group
     
    • Like Like x 4
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. powermarcel10
    • Premium Supporter

    powermarcel10 Retired Team Member

    Joined:
    November 30, 2010
    Messages:
    2,839
    Likes Received:
    789
    Gender:
    Male
    Occupation:
    Callcenter Agent
    Location:
    Groningen
    Ratings:
    +1,028 / 4
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Yep I was thinking to that aswell.. That would been perfect! :)
     
  4. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    So who can do this? :) And renumber the string to avoid a merge conflict with Scythe's branch.
     
    Last edited: April 10, 2013
  5. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,270
    Likes Received:
    6,221
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,229 / 9
    Home Country:
    France France
    Show System Specs
    Oupps :) i was misread and was totally out lol
     
  6. Oxan
    • Premium Supporter

    Oxan Retired Team Member

    Joined:
    August 29, 2009
    Messages:
    1,730
    Likes Received:
    1,024
    Gender:
    Male
    Ratings:
    +1,115 / 2
    Home Country:
    Netherlands Netherlands
    Sorry, I've been too busy with life and MPExtended to go forward with this. Thanks for all the work guys!

    I've finally comitted the skin files by catavolt and ncoH (thanks!) to the branch. I've also moved the checkbox to the Notifier tab, and renamed it to Notifications. See example. I haven't changed the string number yet though, because I don't know which branch conflicts. @elliottmc?

    I'm a bit confused though. @Sebastiii seems to have created his own branch and recommitted everything instead of continuing on my branch or rebasing it (why?!). Anyway, I didn't discover that until I finished everything on my old branch. So FEAT_Optional_stop_live_TV_dialog is now my version with the above changes and latest master included.
     
    • Like Like x 2
  7. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,270
    Likes Received:
    6,221
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,229 / 9
    Home Country:
    France France
    Show System Specs
    Hey, i don't remember exactly, maybe to set mantis number ?
    Too many thing and i'm lost lol
     
  8. Oxan
    • Premium Supporter

    Oxan Retired Team Member

    Joined:
    August 29, 2009
    Messages:
    1,730
    Likes Received:
    1,024
    Gender:
    Male
    Ratings:
    +1,115 / 2
    Home Country:
    Netherlands Netherlands
    Don't think so, the commits are different too. It doesn't matter much (though it's nice to give proper credit with the Author:-line of git commits), except that I didn't notice it before I started working and we've got two branches now. Since everything included in yours should be in mine too, I'd say we should just go ahead with mine.
     
    • Like Like x 1
  9. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,270
    Likes Received:
    6,221
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,229 / 9
    Home Country:
    France France
    Show System Specs
    Yeah, i surely want to update branch with latest master change but i surely see conflict, so i have recreate a new one with mantis number :)
    https://forum.team-mediaportal.com/...stop-live-tv-dialog.116503/page-3#post-982120

    I think i have re apply patch based on master branch, doctor it's grave to not fully remember it ? lol
    Your skill on GIT is far better than me so, for sure better to use your branch :)
    Thanks m8 :)
     
    • Like Like x 1
  10. Oxan
    • Premium Supporter

    Oxan Retired Team Member

    Joined:
    August 29, 2009
    Messages:
    1,730
    Likes Received:
    1,024
    Gender:
    Male
    Ratings:
    +1,115 / 2
    Home Country:
    Netherlands Netherlands
    Yeah, there were quite a few conflicts indeed, so I guess you're right. Anyway, it was my fault that I didn't properly read the thread and see that you created a new branch ;) Thanks!
     
    Last edited: April 13, 2013
    • Like Like x 1
  11. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
    To avoid confusion:
    should we include @Oxan 's branch in the next testbuild and delete @Sebastiii 's branch? Feature itself works nice. There just needs to be one config screenshot and a little text updated in Wiki.

    Thanks every dev for taking care! :)
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!