[Approved] Option to disable 'Stop live TV' dialog (2 Viewers)

seco

Development Group
  • Team MediaPortal
  • August 7, 2007
    1,580
    1,236
    Finland Finland
    Country flag
    My suggestion

    1. Rename Notifier -> Notifications
    2. Add option to TV notifications group
     

    Oxan

    Retired Team Member
  • Premium Supporter
  • August 29, 2009
    1,730
    1,124
    Netherlands Netherlands
    Sorry, I've been too busy with life and MPExtended to go forward with this. Thanks for all the work guys!

    I've finally comitted the skin files by catavolt and ncoH (thanks!) to the branch. I've also moved the checkbox to the Notifier tab, and renamed it to Notifications. See example. I haven't changed the string number yet though, because I don't know which branch conflicts. @elliottmc?

    I'm a bit confused though. @Sebastiii seems to have created his own branch and recommitted everything instead of continuing on my branch or rebasing it (why?!). Anyway, I didn't discover that until I finished everything on my old branch. So FEAT_Optional_stop_live_TV_dialog is now my version with the above changes and latest master included.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,448
    10,276
    France
    France France
    Country flag
    Hey, i don't remember exactly, maybe to set mantis number ?
    Too many thing and i'm lost lol
     

    Oxan

    Retired Team Member
  • Premium Supporter
  • August 29, 2009
    1,730
    1,124
    Netherlands Netherlands
    Hey, i don't remember exactly, maybe to set mantis number ?
    Too many thing and i'm lost lol
    Don't think so, the commits are different too. It doesn't matter much (though it's nice to give proper credit with the Author:-line of git commits), except that I didn't notice it before I started working and we've got two branches now. Since everything included in yours should be in mine too, I'd say we should just go ahead with mine.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,448
    10,276
    France
    France France
    Country flag
    Yeah, i surely want to update branch with latest master change but i surely see conflict, so i have recreate a new one with mantis number :)
    https://forum.team-mediaportal.com/...stop-live-tv-dialog.116503/page-3#post-982120

    I think i have re apply patch based on master branch, doctor it's grave to not fully remember it ? lol
    Your skill on GIT is far better than me so, for sure better to use your branch :)
    Thanks m8 :)
     

    Oxan

    Retired Team Member
  • Premium Supporter
  • August 29, 2009
    1,730
    1,124
    Netherlands Netherlands
    Yeah, there were quite a few conflicts indeed, so I guess you're right. Anyway, it was my fault that I didn't properly read the thread and see that you created a new branch ;) Thanks!
     
    Last edited:

    Holzi

    Super Moderator
  • Team MediaPortal
  • April 21, 2010
    7,930
    2,234
    Ba-Wü
    Germany Germany
    Country flag
    To avoid confusion:
    should we include @Oxan 's branch in the next testbuild and delete @Sebastiii 's branch? Feature itself works nice. There just needs to be one config screenshot and a little text updated in Wiki.

    Thanks every dev for taking care! :)
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 2)

    OP Similar threads Forum Replies Date
    H 1.24.0 MP 1.24 high CPU utilization when 'Keep MediaPortal always on top' option enabled Bugreports 4
    horned_reaper [solved] FanartHandler: Duplication options Fanart Handler 0
    raffe [TV] Option for adding IPTV channels without checking Improvement Suggestions 2
    doskabouter [Question] Optional installation of subcomponents in MPE1 Developer Discussions 1
    Neoculture "Recently Added" option My TVSeries 8
    N What do the series recording options mean, and why is MP2 recording random programs? General 3
    HTPCSourcer [Finished] [MP2-793] 'Restart MP2' as additional option in shutdown menu Archive 6
    N Option to "Filter" Images by folder name Feature Requests 8
    J Option to rename the programs during advance scheduling Feature Requests 0
    Rob Hexenmeister Shutdown options General Support 0
    M [solved] Can't get TV option on installation Installation, configuration support 10
    G Splash screen option pack does not download. StreamedMP 8
    O [Question] Advice Wanted on Developing a Client Application for a Disabled Family Member MPExtended 7
    brena MCE Remote Disable Volume Mapping Input / Output interfaces 0
    cbr954rr How to disable a pre-configured plugin? General 2
    Steve.Rayner61 Online Videos - Automatic Updates fails 'Automatic update disabled. Check your internet connection' OnlineVideos 10
    M How do you disable USB drives from being detected by MP? General Support 0
    D wintv doesn’t stop recording on time Newcomers Forum 4
    toricred Using TMM, How to Stop Importer From Going to The Movie Database for Data General 1
    mickb [solved] Mediaportal Stops working General Support 5
    D [solved] Movie artwork download stopped working Submit: Bug Reports 9
    M MP 2.2.3 Unable to play .ts recordings and MediaPortal stops working for TV viewing General 31
    ajs [solved] 4982: Why this error hard stop when Mediaportal start? MediaPortal 1 3
    rsbrux IR has stopped working Remotes 4
    2BitSculptor MP 1.23.. music stops playing General Support 6
    Similar threads

























    Top Bottom