[Rejected] Possible fix for Mantis #0002437 - Incompatibility between HDTV and Microsoft DTV-DVD (1 Viewer)

[te3hpurp]

In Win7, everything is fine using Microsoft codecs for everything sd,hd,audio.

In Xp HD Coreavc is Okay. HD with Cyberlink with dxva is NOK. SD is Ok.

I am not intested in WinXP at all at this point. What happens on W7?
Does playback periodically stutter with coreavc/PDVD codecs?

Okay, sorry I missunderstood.


In Win 7 HD -with Coreavc i got picture, but it is slow motion about 28 fps, audio is normal speed.
-with Cyberlink No picture, poup says: cannot play .tsbuffer or No Audio/video
-with all set to ms codecs SD & HD ok.

 

[infinite.loop]

In Win7, everything is fine using Microsoft codecs for everything sd,hd,audio.

In Xp HD Coreavc is Okay. HD with Cyberlink with dxva is NOK. SD is Ok.

I am not intested in WinXP at all at this point. What happens on W7?
Does playback periodically stutter with coreavc/PDVD codecs?

Okay, sorry I missunderstood.


In Win 7 HD -with Coreavc i got picture, but it is slow motion about 28 fps, audio is normal speed.
-with Cyberlink No picture, poup says: cannot play .tsbuffer or No Audio/video
-with all set to ms codecs SD & HD ok.

hmm... that really is a hard nut to crack.

 

[riksmith]

Just a question: Can't you rollback the changes from my patch and see if it works than? (I don't mean the changes in MP, ONLY DirectShow). If it works than, there should be a workaround possible for the non workin codecs for every change in the patch. If it is still not working than it is somewhere in the MP changes.

 

[tourettes]

Just a question: Can't you rollback the changes from my patch and see if it works than? (I don't mean the changes in MP, ONLY DirectShow). If it works than, there should be a workaround possible for the non workin codecs for every change in the patch. If it is still not working than it is somewhere in the MP changes.

Problem is quite complex as some of the codecs didn't connect properly without the DS side of patch. And that patch works on some environments.

We definitely need to revisit the patch, prorably reverting to the old behavior and then use the hack to patch specific codecs to work with TsReader. Will take some time (as currently I'm reinstalling my dev PC, with Windows 7).

 

[riksmith]

So to be clear:
Without the patch on the DS side the codecs that do now not work, work. And with the patch the codecs that did not work do work?
So does it mean: For the codecs that did work use the old DS behaviour and all is good? Since i did not make that many changes it should no be too difficult. I don't have all of that codecs working so i cannot do it myself unfortunately.

Or are there some codecs that do not work in both scenario's?

I wouldn't suggest reverting to the old behaviour and then "hack" for W7 (and other). It seems to me the W7 way is more standard compliant, although it does not work with the other codecs. I would suggest hacking the non working codecs. I suspect the problem is that the microsoft standard came after a lot of the H264 codecs were already implemented, so they don't use the standard.

 

[tourettes]

So to be clear:
Without the patch on the DS side the codecs that do now not work, work. And with the patch the codecs that did not work do work?
So does it mean: For the codecs that did work use the old DS behaviour and all is good? Since i did not make that many changes it should no be too difficult. I don't have all of that codecs working so i cannot do it myself unfortunately.

Actually I'm not even 100% sure as I personally haven't been able to test all codecs (and as even DXVA seems to affect codec behavior on XP it gets even more complicated). Also now it seems that some SD & HD codec combinations (!?) are genretating issues (like CoreAVC and MS MPEG2 combination is causing non wotking H.264 decoding... at least on some machines).

Oh, I wish that we could drop support for XP and all 3rd pary codecs

Good thing is that Im currently installing Windows 7, bad thing is that I wont install XP on any PC near me nor I don't currently have any H.264 cabable HW (that is going to change soon).

Or are there some codecs that do not work in both scenario's?

I think DivX H.264 decoder is not working in neither of those cases (but it does work good in GraphEdit). Just under MP it fails to connect to the TsReader.

I wouldn't suggest reverting to the old behaviour and then "hack" for W7 (and other). It seems to me the W7 way is more standard compliant, although it does not work with the other codecs. I would suggest hacking the non working codecs. I suspect the problem is that the microsoft standard came after a lot of the H264 codecs were already implemented, so they don't use the standard.

Yep, that might be the better way (althou MPC-HC mpeg2 splitter would behave differently and it would be harder to troubleshoot issues).

We should somehow try to collect all the issues with H.264 handling we have with current TsReader (only the codecs that don't work). Also same info would be required to have with the older TsReader and current MP SVN version. And all should be listed with XP / Vista / Windows 7 and DXVA & non-DXVA combinations. Pretty complex So complex that getting realiable results are almost impossible as there are too many things that could go wrong (broken codecs, trials running out, user failure to copu TsReader to correct place, etc.).

 

[te3hpurp]

Please don't remove current patch totally...

Because i have most stable Mp ever
I have now:
Win 7, All codec set to MS codecs that can be set. I think Monogram is used somewhere.....

Latest corrections to graph releas and this one. If reverting back, i think it's neessary to implement
hack to MS codecs then.

Best regards,
And for Mp personel for marvelleous software.

Ps.We really don't say that too often....

 

[riksmith]

Was the change for the acceptVideoPinTypes in TsReader.cpp not nessesary? According to MSDN this is required to contain all output types that can occur.

Edit: I have been testing now:


Go to tv with TV OFF -> Start SD, ZAP to HD: Not OK, Get to see 1 frame of the last channel.

Same as mantis: 0002528

 

[tourettes]

Was the change for the acceptVideoPinTypes in TsReader.cpp not nessesary? According to MSDN this is required to contain all output types that can occur.

Edit: I have been testing now:


Go to tv with TV OFF -> Start SD, ZAP to HD: Not OK, Get to see 1 frame of the last channel.

Same as mantis: 0002528

Please check the audio formats those channels have. Gibman's issue is caused by the fact that AAC doesn't seem to work with ffdshow audio decoder.