[confirm] Possible memory leak with MPaudiorenderer (2 Viewers)

[tourettes]

Here is the patched audio renderer .ax file. To test the fix:

1) backup the old mpaudiorenderer.ax file in MP installation folder
2) unzip the new .ax in MP installation folder

 

[jehe]

Hi,

I have just tested your patched audio renderer, with AC3 encoder set to forced.
I have played some different types of videofiles (mkv,bluray,mpeg2(dvd)) and found no System.OutOfMemoryException errors.

 

[tourettes]

now

no?

 

[jehe]

Sorry my english is weak

 

[elliottmc]

Sorry my english is weak

No need to apologise, but please could you clarify so there is no doubt.

Did you get any System.OutOfMemoryException errors ?

 

[jehe]

Hi,
NO, you can check the logs.
Of course this must be confirmed by a third person.

 

[tourettes]

Sorry my english is weak

No need to feel sorry about that. I didn't find the English to be bad, actually it seemed good. Only one slipped in extra character that did change the meaning.

It is good that the patch seem to work. Lets wait @Lichloathe to report back.

 

[Lichloathe]

I have installed your new patch but unfortunately have been unable to test thoroughly today (so far no issues though), sorry but too much cricket and live tv to do proper testing. I'll be able to test properly tomorrow (wife will be home testing shows for me).

You mentioned before about memory increases/fluctuations due to c# code. What sort of memory usage should I be seeing?
So far today all I have noticed is a 10mb or so increase after a 40min 23.976mkv.

 

[tourettes]

You mentioned before about memory increases/fluctuations due to c# code. What sort of memory usage should I be seeing?
So far today all I have noticed is a 10mb or so increase after a 40min 23.976mkv.

It is hard to say what kind of memory graphs the .NET's garbage collector will show you

The two leaks that I was able to find (C++ runtime & our leak detection code could find)

#1 few kbs per played file (this you cannot see and it would take few years to be able to cause out of memory with this)
#2 whole AC3 encoded stream was leaked. This is few hundred MBs per played video (depending on the lenght of the video and audio channel count / bitrate etc.).

 

[Lichloathe]

Hi tourettes, i have had a couple of days to run your patch with various file formats and so far all seems well.
All I have noticed is the memory usage to go from about 120MB after a fresh startup to about 450MB after a couple of days worth of use (normal I assume).
Thanks again for the patch. I'll keep you informed.