Rework TV Graphbuilding CC/Post Process

Discussion in 'Area 51 - Testing Area' started by Sebastiii, December 16, 2011.

  1. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,275
    Likes Received:
    6,223
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,235 / 9
    Home Country:
    France France
    Show System Specs
    Description of the change

    Try to rework how graphbuilding is made:
    1- Fix connecting filter after mediatype change (i.e switch AC3 to AAC audio).
    2- Fix Closed Caption Subtitle (need CoreCC Parser set in TV Post Process Filter).
    3- Fix Closed Caption Subtitle selection in context Menu (actually stay to off in some condition)
    4- Fix FFDShow Post Processing option (in context menu) after mediatype change.
    5- Rework connection of Post Processing Filter when mediatype change.
    6- Enable Possibility to switch ON/OFF Analog Closed Caption when using FFDShow Decoder.
    7- Possibility to set subtitle OFF by default when starting TV or RecordedTV (Thanks Smeuf).
    8- Possibility to disable Closed Caption Subtitle if not needed (usefull for Europe)



    This is the link to the branch on GitHub so that other devs can get the code and try to help/spot any possible bugs:
    Code (Text):
    1. https://github.com/MediaPortal/MediaPortal-1/tree/BUG-3724-Graphbuilding_TV_Side_Post_Process_Fix_CC
     

    Attached Files:

    Last edited: May 14, 2012
    • Like Like x 2
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,275
    Likes Received:
    6,223
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,235 / 9
    Home Country:
    France France
    Show System Specs
    Change log

    Version 46
    • Seems PlayerFactory issue is gone
    • Rework the List of post Processing Filter
    Version 47
    • Add SupportCC for MyVideo
    Version 48
    • Installer based on 1.2.3 release
    Version 49
    • Binaries only based on 1.2.3 release
     
  4. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,275
    Likes Received:
    6,223
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,235 / 9
    Home Country:
    France France
    Show System Specs
  5. gibman
    • Premium Supporter

    gibman Retired Team Member

    Joined:
    October 4, 2006
    Messages:
    2,998
    Likes Received:
    1,321
    Occupation:
    Developer
    Location:
    Aarhus
    Ratings:
    +1,372 / 0
    Home Country:
    Denmark Denmark
    I periodically have something that looks like a deadlock when changing channels across cards.

    /gibman
     

    Attached Files:

    • Like Like x 1
  6. MrCrabs

    MrCrabs Portal Pro

    Joined:
    January 21, 2010
    Messages:
    884
    Likes Received:
    117
    Gender:
    Male
    Occupation:
    Ingenieur Maschinenbau / mechanical engineer
    Location:
    Braunschweig
    Ratings:
    +129 / 1
    Home Country:
    Germany Germany
    Show System Specs
    • Like Like x 1
  7. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,275
    Likes Received:
    6,223
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,235 / 9
    Home Country:
    France France
    Show System Specs
    Thanks,
    I have also push a change on cleanup method side for TSReaderPlayer.cs.
    Maybe Gibman can look @ your link :)
    Seb.

    Edit :) I see that Gibman answer it, effectively thread safe is the build to have :) i have it on my own and i didn't see the issue but i'm also on singleseat with one DVBs card.
     
  8. gibman
    • Premium Supporter

    gibman Retired Team Member

    Joined:
    October 4, 2006
    Messages:
    2,998
    Likes Received:
    1,321
    Occupation:
    Developer
    Location:
    Aarhus
    Ratings:
    +1,372 / 0
    Home Country:
    Denmark Denmark
    you should try sebastiii's custom build and see if the issue disappears.

    remember to back up ur db :)

    Thread safe in the context of the tvservice means that the public version of the tvservice is lacking internal protection against multiple threads accessing/running the same code sections.
    its pretty much timing related.

    when a TV user calls the tvservice for tuning a TV channel 1 thread is created on the server.

    What would happen if 2 users would tune the same channel simultaneously ?
    currently it could cause all sorts of errors.
    the thread safe version takes care of this by granting access to the tuner to one user at a time.

    /gibman
     
    • Like Like x 3
  9. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,275
    Likes Received:
    6,223
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,235 / 9
    Home Country:
    France France
    Show System Specs
    Hi,

    I can make the build public, i wasn't sure if i put it in area51 (think yes) but like it's a global custom build based on future 1.2.2 and and private code (about video player).
    Thanks :)
     
  10. gibman
    • Premium Supporter

    gibman Retired Team Member

    Joined:
    October 4, 2006
    Messages:
    2,998
    Likes Received:
    1,321
    Occupation:
    Developer
    Location:
    Aarhus
    Ratings:
    +1,372 / 0
    Home Country:
    Denmark Denmark
    yet another lock ..same deal as last time. on channel change.

    2011-12-20 16:53:46.745866 [Debug][(35)]: Finished Page 717
    2011-12-20 16:53:46.745866 [Debug][(35)]: Convert: Input data length 1000 teletext
    2011-12-20 16:53:46.769867 [Debug][MPMain(1)]: TVHome.ViewChannelAndCheck(): Stopping player. CardId:46/42, RTSP:rtsp://192.168.1.2:554/stream46.0
    2011-12-20 16:53:47.158890 [Debug][MPMain(1)]: TVHome.ViewChannelAndCheck(): Stopping player. Timeshifting:C:\Media\LiveTv\live46-0.ts.tsbuffer
    2011-12-20 16:53:47.159890 [Debug][MPMain(1)]: TVHome.ViewChannelAndCheck(): rebuilding graph (card changed) - timeshifting continueing.
    2011-12-20 16:53:47.159890 [Debug][MPMain(1)]: TvHome.RenderBlackImage()
    2011-12-20 16:53:48.166947 [Info.][MPMain(1)]: TSReaderPlayer:pause graph



     
  11. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,275
    Likes Received:
    6,223
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,235 / 9
    Home Country:
    France France
    Show System Specs
    Thanks will look that :)
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!