Rework TV Graphbuilding CC/Post Process (1 Viewer)

[Sebastiii]

Description of the change

Try to rework how graphbuilding is made:
1- Fix connecting filter after mediatype change (i.e switch AC3 to AAC audio).
2- Fix Closed Caption Subtitle (need CoreCC Parser set in TV Post Process Filter).
3- Fix Closed Caption Subtitle selection in context Menu (actually stay to off in some condition)
4- Fix FFDShow Post Processing option (in context menu) after mediatype change.
5- Rework connection of Post Processing Filter when mediatype change.
6- Enable Possibility to switch ON/OFF Analog Closed Caption when using FFDShow Decoder.
7- Possibility to set subtitle OFF by default when starting TV or RecordedTV (Thanks Smeuf).
8- Possibility to disable Closed Caption Subtitle if not needed (usefull for Europe)

This is the link to the branch on GitHub so that other devs can get the code and try to help/spot any possible bugs:

https://github.com/MediaPortal/MediaPortal-1/tree/BUG-3724-Graphbuilding_TV_Side_Post_Process_Fix_CC

 

[Sebastiii]

Change log

Version 46

• Seems PlayerFactory issue is gone
• Rework the List of post Processing Filter

Version 47

• Add SupportCC for MyVideo

Version 48

• Installer based on 1.2.3 release

Version 49

• Binaries only based on 1.2.3 release

 

[Sebastiii]

Test build

Version 2011-12-05
Known Issues:

• Look at TV HD/SD/HD channel change and also AC3 or MPEG to AAC to AC3 or MPEG audio.

Testing Required:

• TV start/stop -> TV HD to SD to HD zap channel / Subtitle / CC

Download version 2011-12-16

Version 2011-12-30

• Based on 1.2.2

Download version 2011-12-30
http://s282962534.online.de/MediaPo...branch) for TESTING ONLY_2011-12-30-08-13.exe
Version 2012-04-14

• Based on 1.2.3

Download version 2012-04-14

 

[gibman]

I periodically have something that looks like a deadlock when changing channels across cards.

/gibman

 

[MrCrabs]

Hey, Sebastii and Gibman, I am not quite sure, but is this problem also dealt with here https://forum.team-mediaportal.com/...waiting-few-hours-without-using-serve-103242/ ? It is about tvservice not running after being idle and if crc-check is activated. I also had this problem with idle grabbing active. Without idle grabbing my system now runs without problems for some days. CRC-check didn't do it.

 

[Sebastiii]

Thanks,
I have also push a change on cleanup method side for TSReaderPlayer.cs.
Maybe Gibman can look @ your link
Seb.

Edit I see that Gibman answer it, effectively thread safe is the build to have i have it on my own and i didn't see the issue but i'm also on singleseat with one DVBs card.

 

[gibman]

you should try sebastiii's custom build and see if the issue disappears.

remember to back up ur db

Thread safe in the context of the tvservice means that the public version of the tvservice is lacking internal protection against multiple threads accessing/running the same code sections.
its pretty much timing related.

when a TV user calls the tvservice for tuning a TV channel 1 thread is created on the server.

What would happen if 2 users would tune the same channel simultaneously ?
currently it could cause all sorts of errors.
the thread safe version takes care of this by granting access to the tuner to one user at a time.

/gibman

 

[Sebastiii]

Hi,

I can make the build public, i wasn't sure if i put it in area51 (think yes) but like it's a global custom build based on future 1.2.2 and and private code (about video player).
Thanks

 

[gibman]

yet another lock ..same deal as last time. on channel change.

2011-12-20 16:53:46.745866 [Debug][(35)]: Finished Page 717
2011-12-20 16:53:46.745866 [Debug][(35)]: Convert: Input data length 1000 teletext
2011-12-20 16:53:46.769867 [Debug][MPMain(1)]: TVHome.ViewChannelAndCheck(): Stopping player. CardId:46/42, RTSP:rtsp://192.168.1.2:554/stream46.0
2011-12-20 16:53:47.158890 [Debug][MPMain(1)]: TVHome.ViewChannelAndCheck(): Stopping player. Timeshifting:C:\Media\LiveTv\live46-0.ts.tsbuffer
2011-12-20 16:53:47.159890 [Debug][MPMain(1)]: TVHome.ViewChannelAndCheck(): rebuilding graph (card changed) - timeshifting continueing.
2011-12-20 16:53:47.159890 [Debug][MPMain(1)]: TvHome.RenderBlackImage()
2011-12-20 16:53:48.166947 [Info.][MPMain(1)]: TSReaderPlayerause graph

I periodically have something that looks like a deadlock when changing channels across cards.

/gibman

 

[Sebastiii]

Thanks will look that