[fixed] Screens from default skin are loaded in wrong size (1 Viewer)

[morpheus_xx]

A new skin that is currently worked on is developed to use full HD resolution (1920x1080).

When a Screen is not defined in the current skin, the inherited screen from "default" skin gets loaded as fallback. This is currently done wrong: the fallback screen is loaded in 1280x720 dimension, instead the current skin's 1920x1080 size.

The attached patch corrects this.

 

[Albert]

AW: Screens from default skin are loaded in wrong size

Hmm, I was quite sure my code is correct... I used the actual skin's resolution by design because the screen is based on that resolution. Are you sure the mouse still works well for inherited screens with different resolution when your patch is applied?
I'll try it tonight.

 

[morpheus_xx]

AW: Screens from default skin are loaded in wrong size

Yes I can confirm that mouse and keyboard navigation works fine!

See screenshot of pictures library below.

If we would not allow other skins in full HD to include default's skin files, this would make the meaning of using resources of base skin obsolete (IMHO)

 

[Albert]

AW: Screens from default skin are loaded in wrong size

Sure you should be able to mix screen files of skins with different resolutions. That was the idea.

But in your screenshot, I see that it doesn't work. The resolution of the inherited screen is much too big for that screen. The idea was that the inherited screen is shown in its native resolution....

 

[Albert]

AW: Screens from default skin are loaded in wrong size

I just pushed a patch which does something slightly different: Screens now get always the size of the skin where the screen file with the <Screen> element is located. That is the correct solution.