[Approved] Show Comskip Markers in Timeline (1 Viewer)

[Sebastiii]

Hi
Thanks the fix works
I have tested the scaling issus on StreamedMP (with skin modified) it's ok.
Going to try Default one

Edit : Default Wide skin seems ok here too.

 

[mattjcurry]

Hey Seb,

I need to give you a new test file that has the first few frames with markers and the last few frames with markers to be sure that there is no overlap. You cannot really tell with the test file you have because the markers line up somewhere in the middle.

I will work on that tonight.

 

[Sebastiii]

Ok

 

[Sebastiii]

Seems ok to me :
Hope it's fine

 

[mattjcurry]

Thanks Seb,

You have confirmed the problem in both skins. I blew up your streamedmp image and I could see it there as well. I attached the file. You can kind of see on the right where the backround outline runs out before the end of the marker. This is the same problem I have with the default skin.

 

[mattjcurry]

So after a bit of head scratching,I realized that we have the background defined as a separate control. We set its width to the same width as the TVProgress bar, but I think because there are no right, left, or backround images defined that the scaling code does not get called.

I am going to have to mess with it a bunch and see if I can get the markers to scale correctly.

 

[mattjcurry]

I think that it is actually a bug in 1.3.0Alpha, and maybe even before that. If you fast forward to the end of a recording, it seems like the ticks for the current position move past the end of the background image. I am not sure why that is, but it sounds like a horizontal scaling problem.

More debugging to come.

Also, I got some feedback from arion_p about the chapters bug fix. I need to make some changes to my code and will get that done this week.

----

adding image for 1.3.0Alpha build without my changes. Confirmation that I did not introduce this problem.

 

[mattjcurry]

Found the issue. Eventhough we are adding an offset of 3px when we get ready to render the percent numbers, we are not subtracting it from the width, so the bar goes 6 pixels too long or whatever the number represents. I guess it is not really pixels since it is reletive to resolution.

---

Pushed a one liner fix into my code.

 

[Sebastiii]

Hi new screenshot with the fix seems good now
Thanks.

 

[mattjcurry]

I updated the bugfix based on @arion_p's comments. I went ahead and pushed that one and also updated the comskip markers code to use the new bu fix rather than the old one.

Please test if you get a chance. I want to be sure that I did not break anything in the bluray or mkv players.

The way the bugfix works is that if there are text chapters, those will always take priority. Otherwise if will try to use the chapters from the player if they are there.

Matt