[Approved] Show Comskip Markers in Timeline (2 Viewers)

[mattjcurry]

I believe I have fixed the chapters problem with 1.3.0Alpha and have pushed it to GIT.

I am trying to test right now with the latest NSIS installer, but for some reason when I used it and then did the merge, it blew away my mediaportal database.

That means that I need to go re-scan for channels and generate some new recordings with comskip files. For some reason when I try to import the existing recordings, they do not come over.

Matt

 

[mm1352000]

Recordings should import as long as you have the original matroska XML files that were created at record time.

 

[mattjcurry]

I have not deleted any of the files however they will not import. I think that it might have to do with there being no channels mapped in the TV server.

I am trying to re-scan the channels and see if the recordings will import.

I will give it another shot and if I have an issue I will post the logs.

 

[Sebastiii]

hi,
Yep it can be that, if channel is not exist or not the same name, the import didn't go, it happen to me when i rescan my sat.
So sometimes i change/associate channel to import it.

 

[arion_p]

Nope missing channels should not cause any issue (though there should be at least one channel) as import also does remap the recordings to new channels if the originals do not exist in tvserver.

 

[Holzi]

I have not deleted any of the files however they will not import. I think that it might have to do with there being no channels mapped in the TV server.

I am trying to re-scan the channels and see if the recordings will import.

I will give it another shot and if I have an issue I will post the logs.

Are you using MP 1.3.0 Alpha branches? Then you have to use default skin.. on any other skins recordings will not show due to skin changes coming with MP 1.3.0.
Just a stupid guess tho. =)

 

[mattjcurry]

Once I imported channels, I was able to import the recordings.

 

[mattjcurry]

@Sebastiii,

I created a new branch called FEAT-3853-Show_Comskip_Markers_in_Timeline_1.3.0

It contains my chapter fix for 1.3.0 as well as the comskip logic. I do not know what to do about the skin files at this time. Since my changes are purely additions, should I go ahead and edit the skin files and check them in so that the skinners have something to work on?

 

[arion_p]

FEAT-3853-Show_Comskip_Markers_in_Timeline_1.3.0 should be a test branch since it contains two issues (the chapter fix and the comskip timeline). These should be merged separately to master/beta branch. Are there any conflicts between them?

You should provide modified skin files if that is necessary to enable the feature. The modified skin files ofc should be part of the feature branch and be based on the current (1.3.0 alpha) versions.

 

[mattjcurry]

OK, I will delete the branch that should be a test branch.

The Markers working in 1.3 is dependent on the bugfix for the chapters, because if the chapters are not showing up, then we cannot mark them.

There is one method in both that gets duplicated when I automerge. I will see if I can figure out how to write the code so that the implementation from the Bug Fix over rides the implementation from the feature.

Since there is a dependency, doesn't it make sense to have the bug fix merged in as part of the comskip_markers feature? The same way I merged in the scaling feature? Then when you merge both into master, you know that you will get a clean merge.