[Approved] Show Comskip Markers in Timeline (2 Viewers)

[geoffstewart]

this fix won't work with FTR ... it uses a different TV client than the built in client.

The maintainer for the FTR client was asked to put together a patch. It seems he would prefer to see this fix go into the core before commiting time to replicating this wonderful feature in the FTR client code.

I'm using FTR too and would love to see it have this feature too.

Geoff

 

[sebbl]

Great idea and effort, thanks Matt (?)

 

[mattjcurry]

Geoff is correct. I have put a request in to have the functionality in the 4tr plugin, but the maintainer wants to wait till the makes it into MP first. That makes a lot of sense since support in the plugin without the updated gui component would not really do anything.

Matt

 

[mattjcurry]

I just tested this on Avallonis and the only complaint that I have is that the markers are under the progress bar, so when the progress bar passes a commercial marker, it is no longer visible.

Right now I am working on the images so that they are semi-transparent, but I am wondering if I need to make the commercial markers sit on top of everything. Anyone have thoughts and opinions on that? Especially skinners.

Here is a screenshot.

 

[mattjcurry]

Alright, I made some changes to the avallonis skin to make the progress bar semi-transparent. I am no designer, but this was my best stab at it.

I am actually pretty happy with the result.

 

[geoffstewart]

Hey Matt,

I couldn't figure out what the problem was from your first post, but seeing this latest one clears it up. Looks good. Would each skinner need to create these transparent blocks for the progress bar to allow the comskip marks to be visible once the timeline crosses a commercial break?

 

[mattjcurry]

Hey Geoff,

For the default wide skin, the progress bar was already semi-transparent, so I did not have to make any adjustments to the images. I just reused the orange image that was already there, but still had to add a few lines to the skin xml file.

I imagine that if this becomes a feature at some point, that the skinners will probably want to put a little more effort into making the markers look nice. This was just to show what you could do since you have to make a few skin edits anyway to get the feature to work. I am using this on my home setup so I wanted to be sure that it was presented in a way that would appease the wife

The markers sit below the progress bar right now. I have been debating weather to lay them on top of the progress bar ensuring that they always show up. I used semi-transparent markers so that they would appear blue when they are under the progress bar and grey when they are over the black background. However, I could have made them solid orange and they still would have shown up. The key adjustment was making the blue progress bar semi-transparent.

Matt

 

[Sebastiii]

hi,

Is the patch was different from the pull request ?
I would like to create a branch for it
Thanks.

 

[Sebastiii]

A new branch was created : https://github.com/MediaPortal/MediaPortal-1/tree/FEAT-3853-Show_Comskip_Markers_in_Timeline

 

[mattjcurry]

Thank you. I think that the branch a pull request are the same.

Now that you have the new branch, I can pull it down and test.