[Approved] Show Comskip Markers in Timeline (1 Viewer)

[Sebastiii]

Hi,
I have locally merge the branch to 1.3.0 alpha and change skin files and i get this error :

2012-06-03 10:04:08.874059 [ERROR][MPMain(1)]: GUIWindow: Error in PreAllocResources for MediaPortal.GUI.Library.GUITVProgressControl - System.NullReferenceException: Object reference not set to an instance of an object.
  at MediaPortal.GUI.Library.GUITVProgressControl.PreAllocResources()
  at MediaPortal.GUI.Library.GUIWindow.AllocResources()
2012-06-03 10:04:08.874059 [ERROR][MPMain(1)]: GUIWindow: Error in PreAllocResources for MediaPortal.GUI.Library.GUITVProgressControl - System.NullReferenceException: Object reference not set to an instance of an object.
  at MediaPortal.GUI.Library.GUITVProgressControl.PreAllocResources()
  at MediaPortal.GUI.Library.GUIWindow.AllocResources()
2012-06-03 10:04:08.905061 [ERROR][(36)]: render exception:System.NullReferenceException: Object reference not set to an instance of an object.
  at MediaPortal.GUI.Library.GUITVProgressControl.calculateMarkerSizeAndPosition(Int32 iXPos, Int32 iYPos, Single fTotWidth)
  at MediaPortal.GUI.Library.GUITVProgressControl.Render(Single timePassed)
  at MediaPortal.GUI.Library.GUIControl.DoRender(Single timePassed, UInt32 currentTime)
  at MediaPortal.GUI.Library.GUIWindow.Render(Single timePassed)
2012-06-03 10:04:08.934063 [ERROR][(36)]: render exception:System.NullReferenceException: Object reference not set to an instance of an object.
  at MediaPortal.GUI.Library.GUITVProgressControl.calculateMarkerSizeAndPosition(Int32 iXPos, Int32 iYPos, Single fTotWidth)
  at MediaPortal.GUI.Library.GUITVProgressControl.Render(Single timePassed)
  at MediaPortal.GUI.Library.GUIControl.DoRender(Single timePassed, UInt32 currentTime)
  at MediaPortal.GUI.Library.GUIWindow.Render(Single timePassed)
2012-06-03 10:04:08.951064 [ERROR][(36)]: render exception:System.NullReferenceException: Object reference not set to an instance of an object.
  at MediaPortal.GUI.Library.GUITVProgressControl.calculateMarkerSizeAndPosition(Int32 iXPos, Int32 iYPos, Single fTotWidth)
  at MediaPortal.GUI.Library.GUITVProgressControl.Render(Single timePassed)
  at MediaPortal.GUI.Library.GUIControl.DoRender(Single timePassed, UInt32 currentTime)
  at MediaPortal.GUI.Library.GUIWindow.Render(Single timePassed)

I have attached the skinfile change (maybe i do something wrong)
When merging the branch to alpha, i have corrected TAB in the code, there is a lot, if you can corrected it directly on your own branch
I also attach *.cs files after the merge and TAB corrected
Thanks.

 

[hafblade]

That would be pretty cool. I really like this feature.

 

[mattjcurry]

Sebastiii, I will take a look tonight and see if I can reproduce.

As for the tab issues, I am using sharp develop and I have not been able to figure out how to get it to tab correctly. Please feel free to send the fixed files over.

 

[mattjcurry]

I was able to re-produce the issue and came up with a fix last night / this morning. I did not push it to git yet though because I am still not seeing the markers show up in 1.3.0Alpha_testing after the merge and skin adjustments.

The errors you were getting are not there anymore, but there is something else going on. I will keep you posted, but should get it fixed tonight because it is bugging the heck out of me.

Matt

 

[Sebastiii]

Thanks

 

[mattjcurry]

There is a bug in the current Git branch where Chapters will never show up, which was causing my code to not work because it never thought there was any chapters. In addition, when you went to the Info screen from full screen video, you would never get the chapters option even if they were there.

I submitted it on the 1.3 thread to the rest of the dev team. I just need to know how they want me to fix it and if they want me to file a separate mantis bug for it, or just want me to include the fix in this feature. It is a fairly simple fix, I just need a little direction from the dev manager before I go nuts.

 

[arion_p]

Well the deadline for Alpha is over if I'm correct?

You are right, and it is not going in Alpha.

And as it is a new feature it would bot be allowed for a beta.

No BIG new features are allowed in beta.
No new features at all are allowed after beta.

 

[Holzi]

So there is still a chance to have this in BETA? If everything got worked out. =)

 

[arion_p]

Ofc

 

[Holzi]

Cool! =)
Maybe we could schedule it for 1.3.0 BETA then? -> http://mantis.team-mediaportal.com/view.php?id=3853
Thank you!