[Approved] Show Comskip Markers in Timeline (2 Viewers)

[mattjcurry]

Latest status is this....

My code works as intended on 1.3.0Alpha_Test, however there is a bug that prevents chapters from showing up in the TsReaderPlayer.

For the Blu-Ray and MKV Players the logic for chapters is in those classes. However for the tsReaderPlayer, the logic is somewhere else. The fix for the bug needs to move the loading of the comskip data from the text file into the TsReaderPlayer code and out of the static class.

I will submit a mantis bug today and try to get the fix written this weekend.

 

[mattjcurry]

Mantis bug submitted...

http://mantis.team-mediaportal.com/view.php?id=3875

 

[kiwijunglist]

You submitted the bug under MP 1.3 Alpha, isn't this a bug for MP 1.3 Beta? If I'm wrong just ignore

 

[Holzi]

Target version should be 1.3 BETA indeed.
mattjcurry:
Can you assign this to yourself and schedule it for 1.3 BETA too. =) -> http://mantis.team-mediaportal.com/view.php?id=3853

Thank you!

 

[offbyone]

I assigned both to 1.3 beta and Matt

 

[mattjcurry]

Thanks guys,

I just created a new branch in github and updated the mantis ticket:
https://github.com/MediaPortal/Medi...turns_False_for_HasChapters_for_TV_Recordings

I will go ahead and push the changes for the comskip feature since I consider that part pretty much complete. I just need to go through and fix some of the tabbing so that it is correct. I finally figured out how to configure sharpdevelop.

 

[Sebastiii]

Hi Mattjcurry

About the branch, i think you have created from 130alpha_pretesting, this branch doesn't exist anymore.
Better will be to create from new 1.3.0Alpha but i would like to be sure that it will not messed up Git log.
Thanks

 

[mattjcurry]

I did create it from 1.3.0alpha_testing. I will use 1.3.0Alpha instead. Thanks for the heads up. I guess I missed the status update.

Do you think that I should just work off master instead?

 

[Oxan]

Yeah, Sebas is right, it seems to be based upon an older branch which has deleted commits which haven't been merged. If you can base it on 1.3.0Alpha now everything should be fine (try to delete and recreate the branch before committing, should be easier than rebasing).

I wouldn't work off master right now - it contains relatively ancient code, which can make merging later on a pain. Usually you should work off the most recent release branch (unless you make a bugfix that should go into an older branch, but that's not relevant here).

 

[mattjcurry]

Done

---------

Edit: Man, you guys are making me feel very liked today this is better than facebook.