Show the year of recording in recorded tv/radio | Page 2

Discussion in 'Improvement Suggestions' started by doskabouter, October 31, 2016.

  1. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,742
    Likes Received:
    702
    Location:
    Nuenen
    Ratings:
    +1,048 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    @mm1352000

    Pull request made: https://github.com/MediaPortal/MediaPortal-1/pull/107
    Took a bit of time because it wasn't easy to get things compiled (missing serveragent stuff, skipping compilation due to wrong configuration settings in solution etc).
    Couple of questions:
    - I couldn't find a piece of code which is present in the master branch of MP1, and not in the EXP TVE3.5 branch, so I'm not able to fully merge my changes into the TVE3.5 branch.
    it's this piece (in TvRecorded.cs, LoadDirectory method)
    Code (Text):
    1.  
    2.   if (singleRecording)
    3.   {
    4.     item = BuildItemFromRecording(folder, channels.FirstOrDefault(chan => folder.IdChannel == chan.IdChannel));
    5.     TimeSpan ts = folder.EndTime - folder.StartTime;
    6.     item.Label2 = String.Format("{0} ({1})",
    7.                              Utils.GetNamedDate(folder.StartTime),
    8.                              Utils.SecondsToHMString((int)ts.TotalSeconds));
    9.   }
    10.  
    - I can't imagine that I'm the first one with changes for the TVPlugin, but I didn't see any commits for over 3 years.
    Are other changes in separate branches, and are you going to do a massive merge when the 3.5 version is stable, or am I missing something?

    Paul


     
    • Like Like x 1
    • Thank You! Thank You! x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. regeszter
    • Team MediaPortal

    regeszter Retired Team Member

    Joined:
    October 29, 2005
    Messages:
    5,335
    Likes Received:
    2,863
    Ratings:
    +5,151 / 18
    Home Country:
    Hungary Hungary
    Here is mm's working branch. https://github.com/MediaPortal/MediaPortal-1/commits/EXP-TVE3.5-MP1-MP2_mm_working
    but the master of TVE3.5 is the https://github.com/MediaPortal/MediaPortal-1/tree/EXP-TVE3.5-MP1-MP2
     
    • Thank You! Thank You! x 2
    • Like Like x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!