Show the year of recording in recorded tv/radio

Discussion in 'Improvement Suggestions' started by doskabouter, October 31, 2016.

  1. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,739
    Likes Received:
    696
    Location:
    Nuenen
    Ratings:
    +1,042 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Just noticed that for older recordings no year is displayed but only the weekday, day and month for my recordings, and I think showing the year (especially for old recordings) is more useful than f.e. what day of the week it was.



    Proposal:

    Add a new property: "#TV.RecordedTV.Year" and fill that with the year of the recording, so effects on existing skins are none, and for skin developers it's possible to include that info on the screen too. (Perhaps only if year isn't the current year or so)

    Patch seems pretty easy, I'll create it if it will be accepted
     
    • Like Like x 4
    • Agree Agree x 2
    • Thank You! Thank You! x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,739
    Likes Received:
    696
    Location:
    Nuenen
    Ratings:
    +1,042 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    After digging in the code I have found that the format of the labels of the recordings in the list is hardcoded in TvRecorded.cs, method SetLabels, so I'm not able to make this change without changes for everyone.

    Does anyone object to this?

    Edit: I also like to remove the weekday in that list, in case of recordings of past years to leave more room for the title
     
    Last edited: November 1, 2016
    • Thank You! Thank You! x 1
  4. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,739
    Likes Received:
    696
    Location:
    Nuenen
    Ratings:
    +1,042 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    After a bit of silence, I'm ready to proceed on this.
    I do see a lot of duplicated code, and I do want to clean that up first.
    Don't think providing a number of patches is the way to go for this, I think it's better if someone created an issue so I can have several commits on this feature branch and keep things administrated correctly, so if anyone can do this for me...
     
    • Thank You! Thank You! x 1
  5. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,497
    Likes Received:
    4,709
    Ratings:
    +8,171 / 17
    Home Country:
    New Zealand New Zealand
    Please think carefully before proceeding. I suspect the sort of clean up you're starting to think and talk about now is exactly the sort of thing that has already been (or should be in future) done for TVE 3.5. Repeating the clean up could be considered wasted effort.

    Please also keep in mind:
    1. If you want a patch for TVE 3 to be accepted, you must make a patch for TVE 3.5.
    2. If you make a change for TV, you will need to make the same changes for radio where applicable.
    TVE 3.5's radio and TV code is much more shared/common, so there's a good chance you'd only have to make changes once... whereas with TVE 3 you'd almost certainly have to do it twice. Once for TV, and again for radio.
     
    • Like Like x 1
    • Agree Agree x 1
  6. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,739
    Likes Received:
    696
    Location:
    Nuenen
    Ratings:
    +1,042 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    For TVE 3 I'm indeed duplicating my changes in tv and radio to keep them in sync.

    Which of the many EXP-TVE3.5 branches is the best for this kind of changes?

    Edit: pull request made: https://github.com/MediaPortal/MediaPortal-1/pull/104

    Please review and let me know if something needs to be changed
     
    Last edited: November 15, 2016
    • Like Like x 2
  7. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,497
    Likes Received:
    4,709
    Ratings:
    +8,171 / 17
    Home Country:
    New Zealand New Zealand
    • Thank You! Thank You! x 1
  8. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,739
    Likes Received:
    696
    Location:
    Nuenen
    Ratings:
    +1,042 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Are you sure? Latest commit is from over 2 years ago...
     
  9. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,739
    Likes Received:
    696
    Location:
    Nuenen
    Ratings:
    +1,042 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    @mm1352000 : did you see my previous question?
     
  10. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,497
    Likes Received:
    4,709
    Ratings:
    +8,171 / 17
    Home Country:
    New Zealand New Zealand
    Yes I did, and yes I'm sure.
     
    • Thank You! Thank You! x 1
  11. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,739
    Likes Received:
    696
    Location:
    Nuenen
    Ratings:
    +1,042 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Ok, I'll do that.
    But from the brief look into the code, the parts that I need to change feel older than what is in the main branch of MP, I assume that when TVE 3.5 is ready, the code from the TVE branch will be used, and not the code from the MP1 branch?
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!