I still disagree. Not resetting SMS key state on selection change is in itself a bug as well.
ResetSearchString is named appropriately and it does what its name suggests. Anytime the search string is cleared the previous and current key should be cleared too. And that should happen every time the selection changes EXCEPT when the change is a result of SMS search. That last part is the issue: this exception is not implemented.
In fact SMS search does not work properly in any list control (list/thumb/filmstrip). It only allows typing the first letter whereas by looking at the code you can see that the intent was to be able to type more than just the first letter. Also linked to this is another bug(?): when searching the info label does not show the title of the selected/found entry but rather it shows the search string (which is already displayed above the list).
A proper fix would be to make sure ResetSearchString is not called when selection changes as a result of a call to SearchItem. Also I have suggested in the past to rework all list controls inherit from a base list control where common functionality (such as SMS searching) can be implemented only once.
ResetSearchString is named appropriately and it does what its name suggests. Anytime the search string is cleared the previous and current key should be cleared too. And that should happen every time the selection changes EXCEPT when the change is a result of SMS search. That last part is the issue: this exception is not implemented.
In fact SMS search does not work properly in any list control (list/thumb/filmstrip). It only allows typing the first letter whereas by looking at the code you can see that the intent was to be able to type more than just the first letter. Also linked to this is another bug(?): when searching the info label does not show the title of the selected/found entry but rather it shows the search string (which is already displayed above the list).
A proper fix would be to make sure ResetSearchString is not called when selection changes as a result of a call to SearchItem. Also I have suggested in the past to rework all list controls inherit from a base list control where common functionality (such as SMS searching) can be implemented only once.