[fixed] Sort by Size problem (1 Viewer)

[Seidelin]

Actually it's integer overflow

No it's not. You were right.

 

[jameson_uk]

code is

        case SortMethod.Size:
          if (item1.FileInfo == null || item2.FileInfo == null)
          {
            if (sortAscending)
            {
              return (int)(item1.Duration - item2.Duration);
            }
            else
            {
              return (int)(item2.Duration - item1.Duration);
            }
          }
          else
          {
            if (sortAscending)
            {
              return (int)(item1.FileInfo.Length - item2.FileInfo.Length);
            }
            else
            {
              return (int)(item2.FileInfo.Length - item1.FileInfo.Length);
            }
          }

so if there is no file info available it will sort by duration

way down in the depths of the virtual directory code you have

        Win32API.WIN32_FIND_DATA fd = new Win32API.WIN32_FIND_DATA();
        fd.cFileName = new String(' ', 256);
        fd.cAlternate = new String(' ', 14);
...
        fi.Length = (((long)fd.nFileSizeHigh) << 32) + fd.nFileSizeLow;

then even deeper down you have

private long length = 0;

in FileInformation

we define the two Win32 attributes as

      public uint nFileSizeHigh;
      public uint nFileSizeLow;

looks like an issue with calculating fi.length ??

Edit: Damn you silent... do you ever stop fixing things

 

[SilentException]

Again, as I said. It's int overflow.

Here is a patch that fixes the sorting by size

 

[Seidelin]

I was chasing some wild geese. At least my initial hunch was right.

 

[greybox]

Thank you for confirming the bug. I wonder if same code is used for sorting the files in My Pictures, music and other modules, and if yes, then you know what to do!

 

[Seidelin]

Thanks SE, it is working perfect now.

 

[jameson_uk]

Thank you for confirming the bug. I wonder if same code is used for sorting the files in My Pictures, music and other modules, and if yes, then you know what to do!

Silent has already fixed it... he is too quick for me

 

[Seidelin]

Thank you for confirming the bug. I wonder if same code is used for sorting the files in My Pictures, music and other modules, and if yes, then you know what to do!

SE already fixed that as well. If you want to test, try the attached binary.

 

[greybox]

Installed the dll, everything works fine now. Good job! Thank you very much!!

 

[SilentException]

Fixed in r27898