string.equals breaks on some comparisons (1 Viewer)

[mbuzina]

MediaPortal Version: 1.4.0

Description
A visibility condition of

<visible>string.equals(#music.title,#Play.Current.Title)</visible>

will not only give the wrong result (allways true), but will also break the other visibility string.equals on the same window (all true, negating them results in always false).

Steps to Reproduce:
Add the following to the musicsongs.xml:

<control>
  <type>label</type>
  <label>Selected: #music.title</label>
</control>
<control>
  <type>label</type>
  <label>Playing: #Play.Current.Title</label>
</control>
<control>
  <type>label</type>
  <label>Music File selected (title not empty)</label>
  <visible>string.equals(#music.title,)</visible>
</control>
<control>
  <type>label</type>
  <label>Folder selected (title empty)</label>
  <visible>!string.equals(#music.title,)</visible>
</control>
<control>
  <type>label</type>
  <label>Selected Title is playing</label>
  <visible>string.equals(#music.title,#Play.Current.Title)</visible>
</control>

See what happens when selecting Folders/Music Files while music is playing/not playing. Compare to what happens when the last control (label Selected Title is playing) is removed from skin file. The behaviour of the other visibility conditions is changing.

 

[kiwijunglist]

omg this must of been an annoying bug to work out, given that it breaks the other parts.

 

[mbuzina]

Yes it was quite confusing. There are some other reports on string comparison in the forum, will link later.

 

[mbuzina]

Added to mantis:
0004491

valid string.equals can break skin visibility for other controls
Skin Engine - 2013-06-21 10:12