title ends with '-' prohibits recording? (1 Viewer)

andy1724

New Member
August 10, 2013
2
1
Home Country
Germany Germany
MediaPortal Version: 1.4.0

Description
hi
i think recording doesn't work when the title of the program ends with - (minus) or (minus blank)
just happened again at german channel SWR program 23:30 sat aug 10th, Die Rheinreise -

uploaded logs (i hope it worked)
Steps to Reproduce:
-
 
Last edited:

andy1724

New Member
August 10, 2013
2
1
Home Country
Germany Germany
logs added.
i think it is a bug: insufficient filtering of text originating from EPG
please have a look at aug 10, 23:25
 

mm1352000

Retired Team Member
  • Premium Supporter
  • September 1, 2008
    21,577
    8,224
    Home Country
    New Zealand New Zealand
    Hello again

    Thank you for the log files. (y)
    I agree - I think there is a bug in the filtering of EPG text. The problem character seems to be "\r" (carriage return).
    I will raise a JIRA issue this evening.

    mm
     

    regeszter

    Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Home Country
    Hungary Hungary
    Hi,

    can somebody define which characters needs to filter before is used it for filename?

    Now the following characters are replaced:

    Code:
    	  string strFName = strText.Replace(':', '_');
    	  strFName = strFName.Replace('/', '_');
    	  strFName = strFName.Replace('\\', '_');
    	  strFName = strFName.Replace('*', '_');
    	  strFName = strFName.Replace('?', '_');
    	  strFName = strFName.Replace('\"', '_');
    	  strFName = strFName.Replace('<', '_');
    	  strFName = strFName.Replace('>', '_');
    	  strFName = strFName.Replace('|', '_');
     
    Last edited:

    regeszter

    Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Home Country
    Hungary Hungary
    Change log:
    • \t, \r and \n are escaped.
    Pls. make a backup before you overwrite the original tvservice.exe.

    How to test:

    1. Stop TvService service
    2. Copy the attached TvService.exe to tv server directory
    3. Start TvService service
    4. Make a test. :)
     

    Attachments

    • 0001-Fix-for-MP1-4149-Recording-file-name-is-not-properly.patch
      1 KB
    • TvService.zip
      88.4 KB
    Last edited:

    regeszter

    Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Home Country
    Hungary Hungary
    Will we resolve this bug or it is posponed because of code freeze of TVE3?
     

    Vasilich

    Portal Pro
    August 30, 2009
    3,394
    1,170
    Germany, Mayence
    Home Country
    Russian Federation Russian Federation
    i don't think that code freeze shall forbid bugfixes - it meant to be there for discarding new/changed features.
    The only thing after fixing it is to tell to mm about it.
     

    Users who are viewing this thread

    Top Bottom