TSWriter deadlock potential fix. (3 Viewers)

[nimrodel50]

@mm135200 No luck with the new tswriter the lock still there. Hope the logs put some light on it.

 

[mm1352000]

Thanks for reporting @nimrodel50
Okay, so the new TsWriter still seems to be locking in CBaseFilter:top() for you.
The deadlock occurred after grabbing on Canal Catala Barcelona. For everyone that is not aware, we have already had several reports of problems with that specific multiplex:
https://forum.team-mediaportal.com/...er-will-not-be-able-to-use-them-again.118980/

I'm going to examine igalan's dump file again.
Can you confirm: do you have CRC checking enabled for the EPG grabber?

 

[nimrodel50]

yes I have CRC checking enabled

 

[doskabouter]

Hmmm, okay.

Anybody who is able to reproduce this problem: please could you try the attached TsWriter which should be compatible with MP 1.3 and 1.4.

...
Feedback is welcome!

Just updated MP and completely forgot about this issue, which manifested itself again within 1 day.
So now I'm installing this patch (is there a difference with the one in the first post?) and hoping it's fixed (as it was with mp 1.3).

Perhaps it could be merged in mp 1.5?

 

[igalan]

Today I will install this updated TSWriter and post back with the results.

Update: after letting it grab some EPG data the problem appeared again. CRC was disabled. I attach the logs.

 

[mm1352000]

is there a difference with the one in the first post?

Yes.

Perhaps it could be merged in mp 1.5?

Depends on testing, and from the sounds of it DJBlu may be still investigating. I certainly am because as you can see the issue doesn't appear to be entirely solved (or maybe there are other issues).

Today I will install this updated TSWriter and post back with the results.

Update: after letting it grab some EPG data the problem appeared again. CRC was disabled. I attach the logs.

Thanks igalan.
Can you confirm the time when you experienced the problem. I had a quick look in your log files and couldn't see the regular pattern that I look for, so maybe the patch had some effect but now the problem has moved.

 

[mm1352000]

Okay, here's another version.
Need separate versions for MP 1.3 and 1.4 now due to the TVLibrary.dll.

 

[igalan]

I just installed it and enabled EPG for Canal Català. I'll post back with the results.

 

[igalan]

Things don't look good. After applying the changes and enabling EPG for Canal Catala, I left SetupTV open on the manual control screen so I could see what was doing. Unfortunately after many minutes waiting for EPG to complete turns out SetupTV was freezed. So I had to kill it and restart it. Then I tried to stop the TVService but it would not stop so I had to kill it as well. Here are the logs.

 

[Owlsroost]

Hmmm, okay.

Anybody who is able to reproduce this problem: please could you try the attached TsWriter which should be compatible with MP 1.3 and 1.4.

The patch is also attached for those who are interested. My main goal was to replace the common use of m_Lock with use of m_filterLock for filter related synchronisation (ie. Run(), Pause(), Stop()) and m_channelLock for synchronising access to m_vecChannels.

Feedback is welcome!

Just so you know, I'm currently running a version of TsWriter.ax with the locking mods from the patch (and my async logging mods) on my HTPC for regression testing.

Seems OK so far - I've had a hang after a channel change once, but I'm not convinced that was caused by TsWriter (and nothing useful in the logs to narrow it down) so I'm giving it the benefit of the doubt at the moment