TV Server Plugin: TvWishList (2 Viewers)

[huha]

foxbenw,
once again your detailed comments did help a lot:

1)I have not changed anything with the recording options. I see from a log there is still a bug at the same spot, but i am not able to find it yet. i have placed more traces hoping you can do another run. This part drives me crazy. I introduced a new bug yesterday, so i have to go back first.

i found in yesterday's log for the The Big Bang Theory:

2012-02-08 08:27:22.249854 [(4)]: TvWishList EpgClass: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
2012-02-08 08:27:22.251854 [(4)]: TvWishList EpgClass: Maximum number (100) of programs found - will ignore additional matches
2012-02-08 08:27:22.253855 [(4)]: TvWishList EpgClass: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
You had more than a 100 schedules scheduled for the same wish and follow ups got ignored



2) If the description is different between the recorded file and the scheduled one it cannot be recognized as a repeated one and will be scheduled again.
I searched for "EpisodeName=Pilot" and it got correctly scheduled again.


a,b) I agree that this has become confusing. I have to add a filter for description as well and will add 3 checkboxes (description, name,number).
I did not understand what you meant by a text box for 'skip repeat identifier'. Can you make an example? I think you still need the skip repeated checkbox in addition.
None means that neither names or numbers will beused, but description will be used from the defaults.

c) I have changed this already. It should get scheduled again.


Can you tell me what channel names you have in the group HD? i can guess some, but others i do not know.

 

[foxbenw]

1)
Here you go. The log file is c 100mb!
View attachment TvWishList 4.zip
I changed the max schedules per wish to 1000. I assume this really means 'max epg entries to process per wish' rather than max schedules? (I don't have 100 in my schedules). I left the 'description' checkbox checked, for consistency with yesterday's file.

Two example errors are:
the wish called whitechapel does not schedule the preferred group every time.
the wish called the big bang theory is not scheduling repeated programs from my preferred HD group.
The channels in HD are BBC HD, BBC One HD, ITV 1 HD, Channel 4 HD.

a), b)
Now for the other discussion on repeat episode overrides.

My understanding of what we have now is this:
We create a default setting for 4 different repeat checks in the plugin. They are 'episode name', 'episode number', 'description', and 'epg repeat marker'. If any of them are blank/empty they are ignored, ie will not be considered a duplicate. The logic with these settings is AND. So for a duplicate to be identified, all of the conditions must be equal. This default can be turned on or off per wish by using the 'skip repeated episodes' checkbox.

With your new drop down box we can override the settings for just 'epsiode name' and 'episode number' per wish, to use one or other or both. (I do not know if it is an override or an additional filter but I assume it is an override).

My suggestion was this:
Remove the drop down box completely and replace it with check boxes for each of name, number, description. The text box I suggested was to override the 'epg repeat marker' that is the fourth condition in the default settings. I do not use it, but others might.

I then thought that because of these 4 new fields we wouldn't need the 'skip repeated episodes' checkbox that turns on the defaults per wish, because instead of unchecking that we could set the 4 new fields to be blank (or three 'FALSE' and one blank).
But, having thought about it, you are probably right. It is better to keep the ability to turn the default on and off per wish in order to use it in the 'easy' mode.

If you decide to implement the checkboxes instead of the dropdown box, may I suggest that the overrides will be applied even if the 'skip repeated episodes' box is unchecked? Then for my wishes I would have skip repeated episodes = false for all of them, and fill in the overrides myself for each one.

c) I re-ran the whitechapel wish with description turned off in the default and no schedules were made. Are the name and number tests also set so that if they are blank they match all episodes rather than none? They should probably be consistent, don't you think? I would prefer it if shows with no name or number were all scheduled even with 'skip repeated episodes' turned on but I obviously cannot talk for other users.

One final comment - when I press the 'delete all messages' checkbox it does not delete the records from the sql database. Is it meant to?

Another essay. Let me know if anything is unclear.
Have a good weekend
Ben

 

[huha]

foxbenw,
I really appreciate your patience.

In your previous log(TvWishList - Copy.log) I saw
the >100 warning, which was caused by another bug i found.
This counter refers to the maximum amount of schedules per Tvwish, not to the EPG program.
It is a safety flag to avoid scheduling thousands of programs if you mistype a search (I did that once).

Thanks to your new trace i think i got the bug which was driving me crazy the last nights.
I am asking for one more log.

Thanks also for your channel group description. I should not have guessed. I thaught E4+1 is also a HD channel
and E4 is a SD channel


Now for the other discussion:
a,b)
- your understanding is correct, besides if both the new and the old schedule have an blank/empty field they will be skipped if
all other AND criteria match. If only one of them has a blank/empty filed they will not be considered the same and recorded
again.

- with the new drop down box you can override name and number of episodes (no description). i will use the checkboxes in the
future for each tv wish. This will then be consistent to the general settings and easier for the user. i understand now the
textbox for the epg marker, but think a general default setting should be ok, as the marker should be the same for all your epg
data. Are you aware of any other case?

-the next one i do not understand. If skip repeated is false, the overwrites in the checkboxes would be ignored, as all programs
will be scheduled. This can be set individually for each Tvwish.
In the case of "skip repeated episodes = true" the overwrite checkboxes would define the criteria for skipping a schedule
individually for each tvwish. The defaultsetting specified in the tv server plugin would only be used as a default when a new
tvwish is created.

c) Since the last version i have changed this. So description, episode name, episode number, series number and episode part are
treated all the same as described above. This may have been affected by the bug.
When you press delete messages on the tv server plugin please make sure you are not running at the same time the MP plugin. The
messages should get deleted after you leave the plugin (do not cancel!)

 

[foxbenw]

foxbenw,
I really appreciate your patience.

It's not patience, it is desire to help. You are the one that's done all the good work!

Thanks to your new trace i think i got the bug which was driving me crazy the last nights.
I am asking for one more log.

Sorry, I'm recording at the moment - will need to be in the morning now...

i understand now the
textbox for the epg marker, but think a general default setting should be ok, as the marker should be the same for all your epg
data. Are you aware of any other case?

Probably ok to have it as a default only, yes. Combined with the comment below I guess it means the extra field is not necessary.
I don't use them so cannot comment on different markers within epgs, but it would be unlikely unless combining different sources.

-the next one i do not understand. If skip repeated is false, the overwrites in the checkboxes would be ignored, as all programs
will be scheduled. This can be set individually for each Tvwish.
In the case of "skip repeated episodes = true" the overwrite checkboxes would define the criteria for skipping a schedule
individually for each tvwish. The defaultsetting specified in the tv server plugin would only be used as a default when a new
tvwish is created.

OK. It probably doesn't matter, as long as I know what the logic is. So I will use skip = true and make sure the overrides are what i need them to be for each wish.
EDIT: If skip = true and default for description = true, how do i set description = false?

c) Since the last version i have changed this. So description, episode name, episode number, series number and episode part are
treated all the same as described above. This may have been affected by the bug.

OK, I will check tomorrow after the bug is gone .

When you press delete messages on the tv server plugin please make sure you are not running at the same time the MP plugin. The messages should get deleted after you leave the plugin (do not cancel!)

I have never been running the mp plugin at the same time. I will try again at some point and let you know. The messages should be deleted from the settings table in the sql database - is that correct?

Ben

 

[foxbenw]

Log attached.
View attachment TvWishList5.zip
Mostly good. All whitechapels are now in the preferred group, and it is also picking up some old recordings that are being re-shown in a preferred group (the big bang theory).

But it is still picking up some duplicates from a non-preferred group.
eg search for 'rhinitis'. It will give you an episode of the big bang theory that i have already recorded but has been re-scheduled in a non-preferred group.

Also, I tried delete messages again (from the tv service plugin). It doesn't delete the records from the sql settingls table.
Ben

 

[foxbenw]

Me again!
The name or number is blank rule doesn't seem to do what you said above.
I ran one wish called 'fresh meat'. there is no name or number data in the epg or in old recordings.
I think from what you said above that it should record all episodes. skip = true, description = false, name = true, number = true, episode criteria = default. No episodes are scheduled.
If i run it with skip = false, all episodes are scheduled.
View attachment 98961
Ben

 

[huha]

foxbenw,
we are getting there. I found the issue when you had a SD schedule followed by another SD schedule. It tried to rerecord again.
On the delete messages i found that i deleted only the first line and did not clean up the data base. This could become a source for more errors, so I fixed it, too.
Got a few more bugs with message reporting. Can you post one more log?

Have a good week end, huha

Update: Oops I have not seen your post before (TvWishList6.log) This will be next.

 

[foxbenw]

The messages deleted this time. In the settings table I now have TvWishList_ListViewMessages = <ROOT/> and TvWishList_ListViewMessages_001 = "". I don't know if that is what it should be, just letting you know the result.

New log:
View attachment TvWishList7.zip

Almost perfect. It has picked up the preferred group repeats, and is preferring the HD group where possible.
But 3 repeat, non-preferred group episodes of the big bang theory scheduled. It looks like the description, number and name are the same as in recordings, so it is odd that only these 3 were added.
search for:
The Electric Can Opener Fluctuation
The Adhesive Duck Deficiency
The Cornhusker Vortex

Ben

 

[foxbenw]

Actually, it is correct. There are minor differences in the epg description field. How annoying!

 

[huha]

Ben,
this is great to hear. In the future you can disable then description per tv wish.

Update: the TvWishList_ListViewMessages_001 = "" is correct and needs to stay that way.

I am still struggling if i should allow empty fields for properties for both, the old and the new schedule
to skip the recording. This was implemented in 1.2.1.11 following the following algorithm for skipping:

Option 1 implemented in 1.2.1.11
if ((newDescription == oldDescription) || (!useDescription) )
{
if ((newEpisodePart == oldEpisodePart) || (!useNames) )
{
if ((newEpisodeName == oldEpisodeName) || (!useNames) )
{
if ((newSeriesNumber == oldSeriesNumber) || (!useNumbers) )
{
//Log.Debug("SeriesNumber true");
if ((newEpisodeNumber == oldEpisodeNumber) || (!useNumbers) )
{
//Log.Debug(" ==> EpisodeManagement = true");
return true;
}//EpisodeNumber
}//SeriesNumber
}//EpisodeName
}//EpisodePart
}//Description
//Log.Debug("episodeManagement = false");


What you are proposing is to skip only schedules if none of the activated fields is empty resulting in

Option2:
if ((newDescription == oldDescription) && (newDescription != string.Empty) || (!useDescription))
{
if ((newEpisodePart == oldEpisodePart) && (newEpisodePart != string.Empty) || (!useNames))
{
if ((newEpisodeName == oldEpisodeName) && (newEpisodeName != string.Empty) || (!useNames))
{
if ((newSeriesNumber == oldSeriesNumber) && (newSeriesNumber != string.Empty) || (!useNumbers))
{
if ((newEpisodeNumber == oldEpisodeNumber) && (newEpisodeNumber != string.Empty) || (!useNumbers))
{
//Log.Debug(" ==> EpisodeManagement = true");
return true;
}//EpisodeNumber
}//SeriesNumber
}//EpisodeName
}//EpisodePart
}//Description
//Log.Debug("episodeManagement = false");



The problem i see to come up is that many users have EPG data with a EpisodeName but an empty EpisodePart. So names would never work for them.
I have not seen EPG data where series numbers were missing, but episode numbers are in. So they seem to occur in pairs only.
I definitely do not want to implement both options as this would confuse the average user. So another option would be to add one more checkbox for episode part resulting in checkboxes for description, episodepart, episodename and episodenumber.
I would like to hear your opinion and of course also from any other users.

greetings, huha