TVplugin - avoiding RTSP in multiseat mode (test plz). (1 Viewer)

[gibman]

The patched tsreader doesnt help me.

h264 craps itself, but mpeg2 SD contents is ok.

when using a 25 mb buffer the hickups occurs very often ..each 3-4 sec on h264.

/gibman

 

[disaster123]

tourettes
mhm - you're right but he has no integrety erros in log and my patch will only fix this (for me).

gibman
Do you have integrity errors or others?

I've attached the small patch - cause it really fixes the caching problem which results in integrity errors. It will not fix anything else. At the moment the patch also includes some other debugging stuff.

 

[clintebb]

i should also mention after 1 min of playing tv once it starts stuttering, it doesnt stop. as long as i leave tv playing it will stutter. at that point i closed MP and uploaded the log file shown above.

 

[disaster123]

Nobody else here with 0x80 errors before? I've now tested 2 days - working fine / perfectly.

Before i had 10 or 20 lines of integrity errors then stuttering..

and now:

08-02-2009 18:06:50.573 [ee4]Adding file O:\VID.TIME\live1-0.ts.tsbuffer9.ts (400000000)

08-02-2009 18:06:50.573 [ee4]Opened File O:\VID.TIME\live1-0.ts.tsbuffer9.ts
08-02-2009 18:08:16.538 [c]MultiFileReader has error 0x80 in Loop 0. Try to clear SMB Cache.
08-02-2009 18:08:16.533 [ee4]MultiFileReader has error 0x80 in Loop 0. Try to clear SMB Cache.
08-02-2009 18:08:17.445 [c]Files Added 1, Removed 0

08-02-2009 18:08:17.445 [ee4]Files Added 1, Removed 0

08-02-2009 18:08:17.446 [ee4]Opened File O:\VID.TIME\live1-0.ts.tsbuffer9.ts
08-02-2009 18:08:17.446 [c]Opened File O:\VID.TIME\live1-0.ts.tsbuffer9.ts

Devs? Will you integrate this?

 

[blaudden]

Maybe you should split your patch into one that contains the fix and one that does the cosmetic changes. Makes it easier to see what changes you propose.

Btw, isn't sleep(2) a very long time?

 

[disaster123]

blaudden
the real change is only this:

     {
-      Sleep(10) ;
       Error=0x80;
+
+	  LogDebug("MultiFileReader has error 0x80 in Loop %d. Try to clear SMB Cache.", 10-Loop) ;
+	  // try to clear  local / remote smb file cache. This should happen when we close the filehandle
+        m_TSBufferFile.CloseFile();
+        m_TSBufferFile.OpenFile();
+	  Sleep(2);
     }
[/CLOSE]

The original is a sleep(10) i lowered it to (2) also remember that it is milliseconds not seconds

 

[tourettes]

Devs? Will you integrate this?

Maybe, even when non-RTSP is not supported officially. Main reason being that 4 the Record exposes direct file access over SMB to the users

I'll ask Ambass to check, as he is the person who has been the last dev who has been looking into that specific are in TsReader.ax.

To me the patch looks pretty harmless (althou I'm always really skeptic when some code needs Sleep(), but the original code already had such hack... )

 

[disaster123]

tourettes
OK - i'm pretty sure the code does not need any sleep at all - the original one had a sleep(10) and so i thought i should leave it in. But I'm sure you can remove it.

4TR is not open source isn't it? Otherwise perhaps someone can borrow the code

I know that non-RTSP is not supported BUT - i think non-RTSP could be a solution for nearly everybody - cause nobody must care about Winsock1/Winsock2, implementation of Comskip and things like that. Or do i miss something?

 

[Ambass]

Just waked up by tourettes on this ( but no possible test at work !).

Your patch in MutiFileReader probably help to have fresh data. Closing & re-opening the tsbuffer file list probably do the job and in this case the Sleep() is probably not required.

A problem I see is the fact we use filesize parameters from this file, and due to caches, ts data file may be not updated yet, so we can read wrong data....

 

[dvdfreak]

4TR is not open source isn't it? Otherwise perhaps someone can borrow the code

https://mp-plugins.svn.sourceforge.net/svnroot/mp-plugins/trunk/plugins/ForTheRecord

For The Record makes playback over UNC optional (default is RTSP) for live TV only, recordings are always played over UNC (which works just great, including comskip).