Update Subtitle MPC-HC Engine (1 Viewer)

ronilse

Retired Team Member
  • Premium Supporter
  • July 19, 2005
    4,422
    282
    Moss
    Norway Norway
    Country flag
    Hi,
    As reported in Mantis, tested & found no issues/errors on my setup with a lots of different files with subs, so works good for me(I'll leave it on HTPC & see if something else shows up, when viewing series etc during normal use(longtime test)) :)

    Regards
    Roy
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,447
    10,273
    France
    France France
    Country flag
    • Thread starter
    • Moderator
    • #12
    Hi,

    I have updated to v2 bin with latest fix from MPC-HC (read first post to link to the issue).
    Thanks.
     

    mironicus

    Portal Pro
    March 9, 2008
    688
    44
    Country flag
    Hi! I am compiling the 1.3.0Alpha_SEB_ADDONV2_HomeY version and in this built the subtitles are always displayed with a little delay (about 100 ms). I have some Anime MKV and I can see that in those moments where a title screen is displayed the subtitles remain for a short amount of time on the next screen where they should not be any more.

    The normal Mediaportal 1.30 Beta version works fine though.
     
    Last edited:

    HomeY

    Test Group
  • Team MediaPortal
  • February 23, 2008
    6,466
    4,635
    45
    ::1
    Netherlands Netherlands
    Country flag
    Hi! I am compiling the 1.3.0Alpha_SEB_ADDONV2_HomeY version and in this built the subtitles are always displayed with a little delay (about 100 ms). I have some Anime MKV and I can see that in those moments where a title screen is displayed the subtitles remain for a short amount of time on the next screen where they should not be any more.

    The normal Mediaportal 1.30 Beta version works fine though.
    Are you sure it's not a sync issue with the subs? i've been running this branch for months now and never had sync issues with subs. Do you use the MPC-HC as subtitle engine?

    My settings:
    Subtitles.PNG Advanced.PNG
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,447
    10,273
    France
    France France
    Country flag
    • Thread starter
    • Moderator
    • #15
    Hi! I am compiling the 1.3.0Alpha_SEB_ADDONV2_HomeY version and in this built the subtitles are always displayed with a little delay (about 100 ms). I have some Anime MKV and I can see that in those moments where a title screen is displayed the subtitles remain for a short amount of time on the next screen where they should not be any more.

    The normal Mediaportal 1.30 Beta version works fine though.
    Effectively in this branch, it's the latest code from MPC-HC Team :)
    Can you supply a sample with time where sub are not correct ?
    Also is it possible that you can test on MPC-HC player too (to see if it does the same) ?
    Thanks.

    Last question does it happen with latest fix for SRT or was already there ?
     

    mironicus

    Portal Pro
    March 9, 2008
    688
    44
    Country flag
    I tried the latest built from 6 hours ago (I have a Virtual Machine with Windows 7, Visual Studio 2012 and always try out the latest branches) .

    http://www.animedigital.de/Sample/Sample.mkv

    At 2:34 on the title screen there is the subtitle "There is no God in a Digital World". This subtitle is still displayed on the next scene for 1-2 frames if I use the HomeY branch. I tested this on 2 different clients. With the latest MPC-HC release the timing is correct and also the 1.30 Beta is working fine.
     
    Last edited:

    HomeY

    Test Group
  • Team MediaPortal
  • February 23, 2008
    6,466
    4,635
    45
    ::1
    Netherlands Netherlands
    Country flag
    TNX for the sample mironicus! That helped a lot. I just installed the branch on my Test system and tried to reproduce your issue, which i can! It's related to the dshowhelper.dll file. When i replace the file in the HomeY branch with the 1 from the 1.3Beta release, the issue is gone, so it's not related to the Subtitle code ;)

    If you use the attached (1.3Beta) dshowhelper, your problem should be fixed.

    @Owlsroost might need to look into this.
     

    vuego

    Documentation Group
  • Team MediaPortal
  • August 5, 2006
    1,585
    745
    Göteborg
    Sweden Sweden
    Country flag
    Thanks Seb, I tested your v2 on .mkv files with .srt and .ass subs and it works fine.

    However I have an issue with squeezed subtitles when using the setting Position relative to video frame. I think we discussed this issue a long time ago so it's not a problem of this patch.

    Let's see some screenshots to show you what I mean. I compared the setting in MediaPortal and MPC-HC application:
    1. MediaPortal - Position relative to video frame turned off - Normal:
      MediaPortal - position unchecked.jpg
    2. MediaPortal - Position relative to video frame turned on - Squished:
      MediaPortal - Position relative to frame.jpg
    3. MPC-HC - Position relative to video frame turned off - Normal:
      MPC-HC - position unchecked.jpg
    4. MPC-HC - Position relative to video frame turned on - Normal:
      MPC-HC - Position relative to frame.jpg
    As you can see, MPC-HC moves and shrinks the subtitle (i guess it is compressed both vertically and horizontally) but MediaPortal just compress it vertically.
    Do you think it's possible to get MediaPortal to behave like MPC-HC? :)
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,447
    10,273
    France
    France France
    Country flag
    • Thread starter
    • Moderator
    • #19
    Hi Vuego,

    I don't know, i didn't touch the code, i only back port the one from MPC-HC, so i will try to look if it's on MP C# or in C++ part of MPC-HC Engine.
    For sure, the MPC-HC code is 1:1 so it's on MP side now C# or C++ lol
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,447
    10,273
    France
    France France
    Country flag
    • Thread starter
    • Moderator
    • #20
    Thanks Seb, I tested your v2 on .mkv files with .srt and .ass subs and it works fine.

    However I have an issue with squeezed subtitles when using the setting Position relative to video frame. I think we discussed this issue a long time ago so it's not a problem of this patch.

    Let's see some screenshots to show you what I mean. I compared the setting in MediaPortal and MPC-HC application:
    1. MediaPortal - Position relative to video frame turned off - Normal:
      View attachment 118672
    2. MediaPortal - Position relative to video frame turned on - Squished:
      View attachment 118671
    3. MPC-HC - Position relative to video frame turned off - Normal:
      View attachment 118674
    4. MPC-HC - Position relative to video frame turned on - Normal:
      View attachment 118673
    As you can see, MPC-HC moves and shrinks the subtitle (i guess it is compressed both vertically and horizontally) but MediaPortal just compress it vertically.

    Do you think it's possible to get MediaPortal to behave like MPC-HC? :)
    I have try to look but seems to need adaption on C++ side of MPC-HC Subs Engine @cpp2005 , hope you can see why it failed :)

    In C# code :
    Code:
          Rectangle r = posRelativeToFrame ? frameRect : subsRect;
          int posY = adjustPosY * r.Height / GUIGraphicsContext.Height;
          MpcSubtitles.Render(r.X, r.Y + posY, r.Width, r.Height);
    But here i really can't help :(
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    M.Hulot After Update 1.25 internal blu-ray-player doesn't work General Support 8
    M.Hulot Interner Blu-ray-Player spielt nach Update auf 1.25 keine Discs mehr ab Allgemeines Supportforum 2
    E retaining Watch Status when updating? Newcomers Forum 1
    J Update .NET framework? Improvement Suggestions 9
    G Update von MediaPortal Installationsprobleme? 0
    morpheus_xx [Evaluate] Update to VS 2019? MediaPortal 2 4
    Golf4 Nach Windows-Updates läuft TV-Plugin nicht mehr Allgemeines Support- und Diskussionsforum 0
    B MPEM update list never completes. General Support 0
    JJDoherty Updated DTT frequencies for Ireland... Submit: EPG-Grabbers and tuningdetails 1
    Dark Eyes Updated to Windows 10, now TVServer won't work Installation, configuration support 1
    R [solved] Files moved to new location - Easy way to update database? My TVSeries 7
    M.Hulot Moving Pictures lässt sich nach Windows-Update nicht mehr öffnen Plugins & Erweiterungen 1
    R Files moved to different location - Easy way to update database? Moving Pictures 2
    k12158 [solved] Kein direkter Wechsel von TV-Kanal zu TV-Kanal mehr nach Update? Allgemeines Support- und Diskussionsforum 16
    ajs Mediaportal update to .Net 4.6.2+ MediaPortal 1 13
    Mr6686 [solved] Titan skin broken since update to 1.23 Installation, configuration support 6
    B TV-Server Auto-Update mptvdb after x hours General Support 0
    Terra LAVFilter Plugin cannot be updated (MP1.23) MediaPortal 1 Plugins 10
    TLD Windows 10 1903 feature update General Support 3
    azzuro [WiP] 5043: Update MP1 to VisualStudio 2019 MediaPortal 1 138
    A Problem Windows 10 64 bit prof. Update auf Version 1903(gelöst) Installationsprobleme? 0
    T No TV after updating Windows 10 to latest Version 1903 / OS build 18362.175 (logs attached) General Support 2
    M [solved] Updated Swedish translation for MP 1.24 Submit: Localization of MediaPortal and DeployTool 0
    framug 1.22.0 BasicHome Editor settings for DefaultWide HD skin not kept when update 1.22 3
    Neoculture Bulk file name update My TVSeries 6
    Similar threads

























    Top Bottom