[solved] Version 1.26 breaks ReplayGain ? (1 Viewer)

bta489 · November 8, 2020

Hi,

After the update from 1.25 to 1.26 the replay gain functionality appears to be broken. I had no sound on all audio files (TV and videos played fine). So after experimenting with the settings I got audio to play again by disabling the replay Gain functionality. I don't really use this so disabling it is fine for now, but it might be worth to take a look at.

A look into the logs shows that all replay gain values are parsed as "NaN" (Not a Number). This value is nonetheless set to the player which results in no audio output. The files I tried had no replay gain values, so it appears the parsing logic is not working properly when values are not present.

Here is the relevant excerpt of the logs for playback with no audio:

Code:

[2020-11-08 13:21:07,409] [Log    ] [MPMain   ] [DEBUG] - Analyzing media \\Server\SomeFile.flac.
[2020-11-08 13:21:07,410] [Log    ] [MPMain   ] [DEBUG] - Check MediaInfo.dll from ./.
[2020-11-08 13:21:07,411] [Log    ] [MPMain   ] [INFO ] - Library MediaInfo.dll was found at ./
[2020-11-08 13:21:07,413] [Log    ] [MPMain   ] [DEBUG] - MediaInfo library was loaded. Handle=1073734248 Version is MediaInfoLib - v20.08
[2020-11-08 13:21:07,423] [Log    ] [MPMain   ] [DEBUG] - MediaInfo library successfully opened \\Server\SomeFile.flac. Handle=1
[2020-11-08 13:21:07,425] [Log    ] [MPMain   ] [DEBUG] - Found 0 video streams.
[2020-11-08 13:21:07,426] [Log    ] [MPMain   ] [DEBUG] - Found 1 audio streams.
[2020-11-08 13:21:07,427] [Log    ] [MPMain   ] [DEBUG] - Found 0 subtitle streams.
[2020-11-08 13:21:07,428] [Log    ] [MPMain   ] [DEBUG] - Found 0 chapters.
[2020-11-08 13:21:07,429] [Log    ] [MPMain   ] [DEBUG] - Found 0 menu items.
[2020-11-08 13:21:07,430] [Log    ] [MPMain   ] [DEBUG] - Process file \\Server\SomeFile.flac was completed successfully. Video=0, Audio=1, Subtitle=0
[2020-11-08 13:21:07,430] [Log    ] [MPMain   ] [INFO ] - Inspecting media    : \\Server\SomeFile.flac
[2020-11-08 13:21:07,431] [Log    ] [MPMain   ] [DEBUG] - DLL version         : MediaInfoLib - v20.08
[2020-11-08 13:21:07,432] [Log    ] [MPMain   ] [DEBUG] - Media duration      : 00:03:49.5860000
[2020-11-08 13:21:07,433] [Log    ] [MPMain   ] [DEBUG] - Has audio           : True
[2020-11-08 13:21:07,434] [Log    ] [MPMain   ] [DEBUG] - Has video           : False
[2020-11-08 13:21:07,435] [Log    ] [MPMain   ] [DEBUG] - Has subtitles       : False
[2020-11-08 13:21:07,436] [Log    ] [MPMain   ] [DEBUG] - Has chapters        : False
[2020-11-08 13:21:07,437] [Log    ] [MPMain   ] [DEBUG] - Is DVD              : False
[2020-11-08 13:21:07,438] [Log    ] [MPMain   ] [DEBUG] - Is Blu-Ray disk     : False
[2020-11-08 13:21:07,438] [Log    ] [MPMain   ] [DEBUG] - Audio duration      : 00:03:49.5860000
[2020-11-08 13:21:07,439] [Log    ] [MPMain   ] [DEBUG] - Audio rate          : 933940
[2020-11-08 13:21:07,440] [Log    ] [MPMain   ] [DEBUG] - Audio channels      : Stereo
[2020-11-08 13:21:07,441] [Log    ] [MPMain   ] [DEBUG] - Audio codec         : FLAC
[2020-11-08 13:21:07,442] [Log    ] [MPMain   ] [DEBUG] - Audio bit depth     : 16
[2020-11-08 13:21:07,443] [Log    ] [MPMain   ] [INFO ] - g_Player.Play(\\Server\SomeFile.flac Music)
[2020-11-08 13:21:07,444] [Log    ] [MPMain   ] [DEBUG] - PlayerFactory: Successfully created player instance for file - \\Server\SomeFile.flac
[2020-11-08 13:21:07,483] [Log    ] [MPMain   ] [INFO ] - g_Player.OnStarted() \\Server\SomeFile.flac media:Music
[2020-11-08 13:21:11,394] [Log    ] [MPMain   ] [DEBUG] - Analyzing media \\Server\SomeFile.flac.
[2020-11-08 13:21:11,395] [Log    ] [MPMain   ] [DEBUG] - Check MediaInfo.dll from ./.
[2020-11-08 13:21:11,396] [Log    ] [MPMain   ] [INFO ] - Library MediaInfo.dll was found at ./
[2020-11-08 13:21:11,398] [Log    ] [MPMain   ] [DEBUG] - MediaInfo library was loaded. Handle=1073734120 Version is MediaInfoLib - v20.08
[2020-11-08 13:21:11,408] [Log    ] [MPMain   ] [DEBUG] - MediaInfo library successfully opened \\Server\SomeFile.flac. Handle=1
[2020-11-08 13:21:11,409] [Log    ] [MPMain   ] [DEBUG] - Found 0 video streams.
[2020-11-08 13:21:11,410] [Log    ] [MPMain   ] [DEBUG] - Found 1 audio streams.
[2020-11-08 13:21:11,411] [Log    ] [MPMain   ] [DEBUG] - Found 0 subtitle streams.
[2020-11-08 13:21:11,412] [Log    ] [MPMain   ] [DEBUG] - Found 0 chapters.
[2020-11-08 13:21:11,413] [Log    ] [MPMain   ] [DEBUG] - Found 0 menu items.
[2020-11-08 13:21:11,414] [Log    ] [MPMain   ] [DEBUG] - Process file \\Server\SomeFile.flac was completed successfully. Video=0, Audio=1, Subtitle=0
[2020-11-08 13:21:11,415] [Log    ] [MPMain   ] [INFO ] - Inspecting media    : \\Server\SomeFile.flac
[2020-11-08 13:21:11,418] [Log    ] [MPMain   ] [DEBUG] - DLL version         : MediaInfoLib - v20.08
[2020-11-08 13:21:11,419] [Log    ] [MPMain   ] [DEBUG] - Media duration      : 00:03:49.5860000
[2020-11-08 13:21:11,420] [Log    ] [MPMain   ] [DEBUG] - Has audio           : True
[2020-11-08 13:21:11,421] [Log    ] [MPMain   ] [DEBUG] - Has video           : False
[2020-11-08 13:21:11,422] [Log    ] [MPMain   ] [DEBUG] - Has subtitles       : False
[2020-11-08 13:21:11,423] [Log    ] [MPMain   ] [DEBUG] - Has chapters        : False
[2020-11-08 13:21:11,424] [Log    ] [MPMain   ] [DEBUG] - Is DVD              : False
[2020-11-08 13:21:11,425] [Log    ] [MPMain   ] [DEBUG] - Is Blu-Ray disk     : False
[2020-11-08 13:21:11,425] [Log    ] [MPMain   ] [DEBUG] - Audio duration      : 00:03:49.5860000
[2020-11-08 13:21:11,426] [Log    ] [MPMain   ] [DEBUG] - Audio rate          : 933940
[2020-11-08 13:21:11,427] [Log    ] [MPMain   ] [DEBUG] - Audio channels      : Stereo
[2020-11-08 13:21:11,428] [Log    ] [MPMain   ] [DEBUG] - Audio codec         : FLAC
[2020-11-08 13:21:11,429] [Log    ] [MPMain   ] [DEBUG] - Audio bit depth     : 16
[2020-11-08 13:21:11,432] [Log    ] [MPMain   ] [INFO ] - g_Player.Play(\\Server\SomeFile.flac Music)
[2020-11-08 13:21:11,433] [Log    ] [MPMain   ] [DEBUG] - PlayerFactory: Successfully created player instance for file - \\Server\SomeFile.flac
[2020-11-08 13:21:11,436] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:21:11,437] [Log    ] [MPMain   ] [INFO ] - BASS: Creating BASS audio stream
[2020-11-08 13:21:11,437] [Log    ] [BASS FadeOut] [DEBUG] - BASS: FadeOutStop of stream \\Server\SomeFile.flac
[2020-11-08 13:21:11,441] [Log    ] [MPMain   ] [INFO ] - BASS: Stream Information
[2020-11-08 13:21:11,442] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:21:11,443] [Log    ] [MPMain   ] [INFO ] - BASS: File: \\Server\SomeFile.flac
[2020-11-08 13:21:11,444] [Log    ] [MPMain   ] [DEBUG] - BASS: Type of Stream: BASS_CTYPE_STREAM_FLAC
[2020-11-08 13:21:11,445] [Log    ] [MPMain   ] [INFO ] - BASS: Number of Channels: 2
[2020-11-08 13:21:11,446] [Log    ] [MPMain   ] [INFO ] - BASS: Stream Samplerate: 44100
[2020-11-08 13:21:11,446] [Log    ] [MPMain   ] [DEBUG] - BASS: Stream Flags: BASS_MUSIC_FLOAT, BASS_MUSIC_DECODE, BASS_UNICODE
[2020-11-08 13:21:11,447] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:21:11,448] [Log    ] [MPMain   ] [DEBUG] - BASS: Registering stream playback events
[2020-11-08 13:21:11,449] [Log    ] [MPMain   ] [DEBUG] - BASS: Replay Gain Data: Track Gain=NaNdB, Track Peak=NaN, Album Gain=NaNdB, Album Peak=NaN
[2020-11-08 13:21:11,450] [Log    ] [MPMain   ] [DEBUG] - BASS: Setting Replay Gain to NaNdB
[2020-11-08 13:21:11,451] [Log    ] [MPMain   ] [INFO ] - BASS: Successfully created BASS audio stream
[2020-11-08 13:21:11,452] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:21:11,453] [Log    ] [MPMain   ] [DEBUG] - BASS: Updating Dictionary for GCHandle for stream -2147483598
[2020-11-08 13:21:11,460] [Log    ] [MPMain   ] [INFO ] - BASS: playback started
[2020-11-08 13:21:11,462] [Log    ] [MPMain   ] [INFO ] - g_Player.OnStarted() \\Server\SomeFile.flac media:Music

And here the same file after disabling ReplayGain, with audio:

Code:

[2020-11-08 13:26:42,140] [Log    ] [MPMain   ] [DEBUG] - Analyzing media \\Server\SomeFile.flac.
[2020-11-08 13:26:42,155] [Log    ] [MPMain   ] [DEBUG] - Check MediaInfo.dll from ./.
[2020-11-08 13:26:42,155] [Log    ] [MPMain   ] [INFO ] - Library MediaInfo.dll was found at ./
[2020-11-08 13:26:42,171] [Log    ] [MPMain   ] [DEBUG] - MediaInfo library was loaded. Handle=264439864 Version is MediaInfoLib - v20.08
[2020-11-08 13:26:42,202] [Log    ] [MPMain   ] [DEBUG] - MediaInfo library successfully opened \\Server\SomeFile.flac. Handle=1
[2020-11-08 13:26:42,249] [Log    ] [MPMain   ] [DEBUG] - Found 0 video streams.
[2020-11-08 13:26:42,249] [Log    ] [MPMain   ] [DEBUG] - Found 1 audio streams.
[2020-11-08 13:26:42,296] [Log    ] [MPMain   ] [DEBUG] - Found 0 subtitle streams.
[2020-11-08 13:26:42,296] [Log    ] [MPMain   ] [DEBUG] - Found 0 chapters.
[2020-11-08 13:26:42,296] [Log    ] [MPMain   ] [DEBUG] - Found 0 menu items.
[2020-11-08 13:26:42,327] [Log    ] [MPMain   ] [DEBUG] - Process file \\Server\SomeFile.flac was completed successfully. Video=0, Audio=1, Subtitle=0
[2020-11-08 13:26:42,327] [Log    ] [MPMain   ] [INFO ] - Inspecting media    : \\Server\SomeFile.flac
[2020-11-08 13:26:42,327] [Log    ] [MPMain   ] [DEBUG] - DLL version         : MediaInfoLib - v20.08
[2020-11-08 13:26:42,327] [Log    ] [MPMain   ] [DEBUG] - Media duration      : 00:03:49.5860000
[2020-11-08 13:26:42,327] [Log    ] [MPMain   ] [DEBUG] - Has audio           : True
[2020-11-08 13:26:42,327] [Log    ] [MPMain   ] [DEBUG] - Has video           : False
[2020-11-08 13:26:42,327] [Log    ] [MPMain   ] [DEBUG] - Has subtitles       : False
[2020-11-08 13:26:42,327] [Log    ] [MPMain   ] [DEBUG] - Has chapters        : False
[2020-11-08 13:26:42,327] [Log    ] [MPMain   ] [DEBUG] - Is DVD              : False
[2020-11-08 13:26:42,327] [Log    ] [MPMain   ] [DEBUG] - Is Blu-Ray disk     : False
[2020-11-08 13:26:42,343] [Log    ] [MPMain   ] [DEBUG] - Audio duration      : 00:03:49.5860000
[2020-11-08 13:26:42,343] [Log    ] [MPMain   ] [DEBUG] - Audio rate          : 933940
[2020-11-08 13:26:42,343] [Log    ] [MPMain   ] [DEBUG] - Audio channels      : Stereo
[2020-11-08 13:26:42,343] [Log    ] [MPMain   ] [DEBUG] - Audio codec         : FLAC
[2020-11-08 13:26:42,343] [Log    ] [MPMain   ] [DEBUG] - Audio bit depth     : 16
[2020-11-08 13:26:42,343] [Log    ] [MPMain   ] [INFO ] - g_Player.Play(\\Server\SomeFile.flac Music)
[2020-11-08 13:26:42,359] [Log    ] [MPMain   ] [INFO ] - Loading external players plugins
[2020-11-08 13:26:42,359] [Log    ] [MPMain   ] [INFO ] -   found plugin:MediaPortal.WinampPlayer.WinampPlugin in C:\Program Files (x86)\Team MediaPortal\MediaPortal\Plugins\ExternalPlayers\ExternalPlayers.dll
[2020-11-08 13:26:42,359] [Log    ] [MPMain   ] [INFO ] -   player:Winamp.  author: int_20h
[2020-11-08 13:26:42,359] [Log    ] [MPMain   ] [INFO ] -   found plugin:MediaPortal.ITunesPlayer.ITunesPlugin in C:\Program Files (x86)\Team MediaPortal\MediaPortal\Plugins\ExternalPlayers\ExternalPlayers.dll
[2020-11-08 13:26:42,359] [Log    ] [MPMain   ] [INFO ] -   player:iTunes.  author: Frodo
[2020-11-08 13:26:42,359] [Log    ] [MPMain   ] [INFO ] - BASS: Initializing BASS audio engine...
[2020-11-08 13:26:42,374] [Log    ] [MPMain   ] [INFO ] - BASS: Device Information
[2020-11-08 13:26:42,374] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:26:42,374] [Log    ] [MPMain   ] [INFO ] - BASS: Name: SAMSUNG (Intel(R) Display-Audio)
[2020-11-08 13:26:42,374] [Log    ] [MPMain   ] [INFO ] - BASS: Default Device: True
[2020-11-08 13:26:42,374] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:26:42,430] [Log    ] [MPMain   ] [INFO ] - BASS: Device Information
[2020-11-08 13:26:42,431] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:26:42,433] [Log    ] [MPMain   ] [INFO ] - BASS: Name: Speakers=2, MinRate=0, MaxRate=0, DX=9, EAX=False
[2020-11-08 13:26:42,434] [Log    ] [MPMain   ] [INFO ] - BASS: Directsound version: 9
[2020-11-08 13:26:42,435] [Log    ] [MPMain   ] [INFO ] - BASS: # Output Channels: 2
[2020-11-08 13:26:42,436] [Log    ] [MPMain   ] [DEBUG] - BASS: Minimum Buffer Samples: 10
[2020-11-08 13:26:42,437] [Log    ] [MPMain   ] [DEBUG] - BASS: Current Sample rate: 48000
[2020-11-08 13:26:42,438] [Log    ] [MPMain   ] [DEBUG] - BASS: Maximum Sample rate: 0
[2020-11-08 13:26:42,439] [Log    ] [MPMain   ] [DEBUG] - BASS: Minimum Sample rate: 0
[2020-11-08 13:26:42,439] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:26:42,440] [Log    ] [MPMain   ] [INFO ] - BASS: Initialization done.
[2020-11-08 13:26:42,442] [Log    ] [MPMain   ] [DEBUG] - PlayerFactory: Successfully created player instance for file - \\Server\SomeFile.flac
[2020-11-08 13:26:42,459] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:26:42,460] [Log    ] [MPMain   ] [INFO ] - BASS: Creating BASS audio stream
[2020-11-08 13:26:42,484] [Log    ] [MPMain   ] [INFO ] - BASS: Stream Information
[2020-11-08 13:26:42,485] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:26:42,486] [Log    ] [MPMain   ] [INFO ] - BASS: File: \\Server\SomeFile.flac
[2020-11-08 13:26:42,487] [Log    ] [MPMain   ] [DEBUG] - BASS: Type of Stream: BASS_CTYPE_STREAM_FLAC
[2020-11-08 13:26:42,489] [Log    ] [MPMain   ] [INFO ] - BASS: Number of Channels: 2
[2020-11-08 13:26:42,490] [Log    ] [MPMain   ] [INFO ] - BASS: Stream Samplerate: 44100
[2020-11-08 13:26:42,491] [Log    ] [MPMain   ] [DEBUG] - BASS: Stream Flags: BASS_MUSIC_FLOAT, BASS_MUSIC_DECODE, BASS_UNICODE
[2020-11-08 13:26:42,492] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:26:42,493] [Log    ] [MPMain   ] [DEBUG] - BASS: Registering stream playback events
[2020-11-08 13:26:42,501] [Log    ] [MPMain   ] [INFO ] - BASS: Successfully created BASS audio stream
[2020-11-08 13:26:42,503] [Log    ] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2020-11-08 13:26:42,515] [Log    ] [MPMain   ] [DEBUG] - BASS: ---------------------------------------------
[2020-11-08 13:26:42,516] [Log    ] [MPMain   ] [DEBUG] - BASS: Creating BASS mixer stream
[2020-11-08 13:26:42,518] [Log    ] [MPMain   ] [DEBUG] - BASS: Creating 2 channel mixer with sample rate of 44100
[2020-11-08 13:26:42,521] [Log    ] [MPMain   ] [DEBUG] - BASS: Successfully created BASS Mixer stream
[2020-11-08 13:26:42,532] [Log    ] [MPMain   ] [DEBUG] - BASS: Updating Dictionary for GCHandle for stream -2147483629
[2020-11-08 13:26:42,536] [Log    ] [MPMain   ] [INFO ] - BASS: playback started
[2020-11-08 13:26:42,539] [Log    ] [MPMain   ] [INFO ] - g_Player.OnStarted() \\Server\SomeFile.flac media:Music

ajs · November 8, 2020

@hwahrmann

hwahrmann · November 15, 2020

As no changes have been applied to BASS engne at all, i can see no reason, why it should be our fault.

hwahrmann · November 15, 2020

Somefile.flac simply has no ReplayGain information.

Code:

[2020-11-08 13:21:11,449] [Log    ] [MPMain   ] [DEBUG] - BASS: Replay Gain Data: Track Gain=NaNdB, Track Peak=NaN, Album Gain=NaNdB, Album Peak=NaN
[2020-11-08 13:21:11,450] [Log    ] [MPMain   ] [DEBUG] - BASS: Setting Replay Gain to NaNdB

"NaN" means that no value was available.

hwahrmann · November 15, 2020

I agree that we could apply a check if this is the case and disable replagain. will have a look into that.

bta489 · November 15, 2020

Yes, the file indeed does not have those values. Only a some files of mine have them. Nonetheless, this was never an issue before. All files played fine, whether they had replaygain values or not. Maybe during the update some settings got reset.

I don't want to blame anyone. Since there were no changes it might have been some freak coincidence on my end, I don't know. As I said in my first post I'm fine with disabling this feature because I don't really use it.

Something seemed 'not right' to me, that not having an optional value essentially breaks audio output.
I checked logs from before the update (with a different file) and found this line:

Code:

[2020-11-06 19:53:10,696] [Log    ] [MPMain   ] [DEBUG] - BASS: No Replay Gain Information found in stream tags

So it seems I had the replayGain enabled and it correctly detected no information instead of passing NaN and effectively breaking audio-output.

hwahrmann · November 15, 2020

i know that you are not blaming anyone. i guess this is related to the TagReader, which is returning now a different format instead of 0.0.
i'll have a look into that immediately.

for the time being, you should turn off replaygain support, as this is really broken.

hwahrmann · November 15, 2020

Fixed in branch MP1-5051

Ready for testing and can be merged into master.
Just a minor change, which i did several month ago in MPTagThat.

Edit: Basically the update of Taglib-sharp in MP1-5047 was causing this, since this was changing the way how ReplayGain Information is returned.

badboyxx · November 27, 2020

Maybe you can provide a fix without you have to compile anything?

ajs · November 27, 2020

badboyxx said:
Maybe you can provide a fix without you have to compile anything?

Try - https://tinyurl.com/y24bvllu

[solved] Version 1.26 breaks ReplayGain ? (1 Viewer)

bta489

Portal Pro

ajs

Development Group

hwahrmann

Development Group

hwahrmann

Development Group

hwahrmann

Development Group

bta489

Portal Pro

hwahrmann

Development Group

hwahrmann

Development Group

badboyxx

Portal Pro

ajs

Development Group

Users who are viewing this thread