[fixed] Wrong dialog when manual record stopping [Jira MP1-3401] (1 Viewer)

[regeszter]

I added more debug log. Can you test with the #35 + the uploaded tvplugin_debugV2? Please do not forget update your tvserver too.

The server side log not need at the moment.

Sorry to disturb you but if I can't reproduce the error here, I can't work alone.

Thx.

 

[elliottmc]

I added more debug log. Can you test with the #35 + the uploaded tvplugin_debugV2? Please do not forget update your tvserver too.

The server side log not need at the moment.

Sorry to disturb you but if I can't reproduce the error here, I can't work alone.

Thx.

Does #35 include server changes, or is it just your 3401 current branch? I already have your 3401 branch on my server.

I can test this evening.

 

[regeszter]

#35 include server changes. The tvdatabase.dll need to be same in tvserver and tvplugin side.

 

[regeszter]

@elliottmc

Could you tested this stuff?

 

[elliottmc]

@elliottmc

Could you tested this stuff?

Sorry, I didn't get chance last night. Should be good this evening.

 

[elliottmc]

With this installer I give stop dialog on stop recordings and delete dialog on recorded tv -> delete recording

@regeszter - I have tested with this installer, and I also get the delete dialog on both now.

What is different from the 3401 branch in GIT ?

Maybe it is something that was odd with my system.

Note that I didn't include any of the later TvPlugin.dll - just the installer in the first instance.

Mark

 

[elliottmc]

And now my own build with the 3401 branch is working perfectly in all cases as well.

No idea how to explain that.

So, make sure code is reviewed, see if anyone else can confirm that the fix is good and then we can include this in 1.7.0.

 

[regeszter]

What is different from the 3401 branch in GIT ?

Same.

 

[elliottmc]

What is different from the 3401 branch in GIT ?

Same.

Oh well, we can't work on the basis of inconsistent testing. Would be good if others can test your installer and confirm that everything works with no regression.

 

[regeszter]

I added the link to the installer in the 1st post to help the testers.