[6.0.3] Trakt for MediaPortal [2020-01-01] (1 Viewer)

doskabouter

Development Group
  • Team MediaPortal
  • September 27, 2009
    3,502
    1,702
    Nuenen
    Netherlands Netherlands
    Country flag
    I've updated the trakt plugin and now I have a problem with the onlinevideos/trakt combination because onlinevideos is compiled against an older version of trakt.
    Specifically, I get an error:
    Exception getting watched status: Method not found: 'System.Collections.Generic.IEnumerable`1<TraktPlugin.TraktAPI.DataStructures.TraktMovieWatched> TraktPlugin.TraktCache.GetWatchedMoviesFromTrakt(Boolean)'.

    Is it possible to add that missing method again (possibly with some kind of depcrecated attribute/warning) so that at least untill the next release (and accompanying fix ofcourse) onlinevideos will still work as intended?
     

    ltfearme

    Community Plugin Dev
  • Premium Supporter
  • June 10, 2007
    6,697
    7,081
    Sydney
    Australia Australia
    Country flag
    I'm on holidays for a week, I can see what I can do after that.

    Do you know if the reference is used directly by OnlineVideos or is it one of the site utils? If its the later, then it might be easier to reach out to the person that did the site and have an update published?
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    3,502
    1,702
    Nuenen
    Netherlands Netherlands
    Country flag
    Well, off the top of my head, it's part of onlinevideos itself, but I'll investigate further soon.
    I do see a traktplugin.dll in the onlinevideos repo, which probably gets overwritten.
    But as I said, I'll investigate further

    P.S. have a good holiday!
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    3,502
    1,702
    Nuenen
    Netherlands Netherlands
    Country flag
    Ok, after investigation I found that the trakt dlls are indeed distributed in the onlinevideos plugin as optional installation.
    Since the method isn't removed from trakt, but moved to a separate dll, I think it's not easy to patch trakt so that the current onlinevideos keeps working.
    I'm currently the only one suffering from this as far as I know, so I'll create a workaround for myself and also fix the onlinevideos repository

    Edit: ok, it's not part of the onlinevideos setup, it's only in the repo to link to when compiling...
     
    Last edited:

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    Hi :)

    @ltfearme i have run into a bug about rate dialog that i have explain in private forum but i wrote it here to know if we can discuss about this.
    The issue happen and timing related, it's when doing stop and rate dialog is asked, if the whole stop is not yet processed correctly (when directshow graph filter is not fully released) then the rate dialog is running but nothing can be displayed and lead to MP kind of loop and feel like MP Freezed.

    So not sure if we can do it differently with actual code or need to add a new event when filter are fully released :)
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    So what i have add in Trakt : (line 17 to 20) and in MP code, we have changed GUIGraphicsContext.Vmr9Active to be set to false when all filter are properly released)
    If you have a better idea :p

    C#:
    private void OnEpisodeWatched(DBEpisode episode, bool isPlaylist)
            {
                if (TraktSettings.AccountStatus != ConnectionState.Connected) return;
    
                EpisodeWatching = false;
    
                TraktLogger.Info("Playback of MP-TVSeries episode stopped and considered watched. Title = '{0}', PlayList Item = '{1}'", episode.ToString(), isPlaylist);
                double progress = GetPlayerProgress(episode);
    
                // purely defensive check against bad progress reading
                // for an episode that counts as watched.
                if (progress < 80) progress = 100;
    
                var stopWatching = new Thread((objEpisode) =>
                {
                    // Wait playback is fully stopped to avoid loop on stop
                    while (g_Player.FullScreen || GUIGraphicsContext.Vmr9Active)
                    {
                         Thread.Sleep(10);
                    }
    
                    var stoppedEpisode = objEpisode as DBEpisode;
                    if (stoppedEpisode == null) return;
    
                    TraktScrobbleResponse response = null;
                    TraktScrobbleEpisode scrobbleData = null;
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    Hi :)

    I have moved the code into : \Trakt-for-Mediaportal\TraktPlugin\GUI\GUIUtils.cs :)
    It works on my side, hope it's the good way to do :p (like this it will be ok for all sections)
     
    Last edited:

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    In fact i did a bad copy of the modified DLL and it doesn't works, so will remove the above patch for now lol
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    ajs Trakt crashed Mediaportal if no Internet in home lan Trakt 2
    Lichloathe Trakt for MP2 question General 7
    ajs Trakt error when start with MP crash Trakt 1
    thepahakurki Trakt error: Invalid or missing file Trakt 8
    fischy667 wrong/no sync with trakt on some series Trakt 2
    A Mediaportal Allgemeines Support- und Diskussionsforum 0
    G Update von MediaPortal Installationsprobleme? 0
    ajs [News] MediaPortal 1 - 1.25 Released! News and Announcements 1
    horned_reaper Standby is prevented by MediaPortal client General Support 0
    U [solved] MediaPortal crashing on startup General Support 10
    g0rsq Info box randomly popping up when watching TV or other video MediaPortal 2 Newcomers Forum 1
    high [unanswered] Hallo möchte gerne Mediaportal. nutzen kann mich jemand anrufen? contactform feedback and requests 2
    ajs [News] MediaPortal 1.25 Pre-Release ready for testing! News and Announcements 0
    ajs [Rejected] Mediaportal Codename MediaPortal 1 41
    M 2nd (Touch-)Display Support on MediaPortal 2 such MPDisplay++? General 2
    N Steam release of MediaPortal MediaPortal 1 Talk 0
    torone Dritter versuch mit Mediaportal 2 Allgemeines Support- und Diskussionsforum 1
    M Fehlerhafter Link auf der aktuellen MediaPortal Seite Page- und Forumsfeedback 0
    H 1.24.0 MP 1.24 high CPU utilization when 'Keep MediaPortal always on top' option enabled Bugreports 4
    mickb [solved] Mediaportal Stops working General Support 5
    J [solved] Newbie to MediaPortal 2 - Cannot open/run TV programs Newcomers Forum 4
    atlantic How to use Spotify inside Mediaportal? Listen Music 18
    horned_reaper MediaPortal configuration error log message General Support 1
    Rob Hexenmeister Mediaportal Properties #plot etc... General Support 3
    ajs [News] MediaPortal 1 - 1.24 Released! News and Announcements 3
    Similar threads

























    Top Bottom