[Approved] Allow plugins as Screensavers (1 Viewer)

[azzuro]

you can merge the MP branch into your own branch.
and post the patch

 

[sccrgoalie1]

you can merge the MP branch into your own branch.
and post the patch

I think I did this right based on what you said. Thanks by the way! Fix pushed here.
https://github.com/sccrgoalie1/MediaPortal-3/tree/MP1-4231-FEAT-Allow_plugins_as_Screensavers

 

[Holzi]

Thanks!
I think @Sebastiii is the one who will push your fix into the MediaPortal branch.

 

[Sebastiii]

Hi sccrgoalie1

Can you set your Visual Studio with recommended setting from wiki ? (from here : http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/18_Contribute/4_Development/Coding_Standards)

Your latest push in branch missing some space (you can compare the branch from MP1 repo)
Thanks

Also the latest fix is not 100% working, now we can't enable plugins disabled and can't disable plugins enabled, it's like setting is not write to xml.
Can you correct it ?

Seb.

 

[sccrgoalie1]

Hi sccrgoalie1

Can you set your Visual Studio with recommended setting from wiki ? (from here : http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/18_Contribute/4_Development/Coding_Standards)

Your latest push in branch missing some space (you can compare the branch from MP1 repo)
Thanks

Also the latest fix is not 100% working, now we can't enable plugins disabled and can't disable plugins enabled, it's like setting is not write to xml.
Can you correct it ?

Seb.

I thought I set visual studio correctly, I'll double check the settings. Thanks.

I'll check out the enable disable issue tomorrow, and fix it up.

 

[sccrgoalie1]

Hi sccrgoalie1

Can you set your Visual Studio with recommended setting from wiki ? (from here : http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/18_Contribute/4_Development/Coding_Standards)

Your latest push in branch missing some space (you can compare the branch from MP1 repo)
Thanks

Also the latest fix is not 100% working, now we can't enable plugins disabled and can't disable plugins enabled, it's like setting is not write to xml.
Can you correct it ?

Seb.

I thought I set visual studio correctly, I'll double check the settings. Thanks.

I'll check out the enable disable issue tomorrow, and fix it up.

Commit pushed to my branch that fixes this issue. I also reviewed all the coding standards and updated some spacing. If you see anything specific I'm missing please let me know and I'd be happy to fix

 

[Sebastiii]

Yeah thanks seems good

I have corrected 2005-2010 to 2005-2013 (i forgot also to change that lol)
Remove some space at the end of line (when commit the change, you can see it and you can remove it manually) :

You see : these ...... after }, they can be removed

Last thing i think is when we have a Jira Entry, you have to put Jira issue key in each commit message like :
Yours : Spacing updates
Correct one : MP1-4231 : Spacing updates

This will help to create review easily

Ps : don't get me wrong, you did a good job and with above it will like perfect

 

[sccrgoalie1]

Yeah thanks seems good

I have corrected 2005-2010 to 2005-2013 (i forgot also to change that lol)
Remove some space at the end of line (when commit the change, you can see it and you can remove it manually) :

View attachment 137849

You see : these ...... after }, they can be removed

Last thing i think is when we have a Jira Entry, you have to put Jira issue key in each commit message like :
Yours : Spacing updates
Correct one : MP1-4231 : Spacing updates

This will help to create review easily

Ps : don't get me wrong, you did a good job and with above it will like perfect

Thanks for taking time to explain these things. I really appreciate it!

 

[Holzi]

Merged to master. Will be in MP 1.6.0.
Thanks!

I'll update the wiki as necessary if approved

Does there already a Wiki page exist?


EDIT:
Docs done it seems! -> http://wiki.team-mediaportal.com/1_...nfig_Tool_Changes/Set_a_plugin_as_screensaver
Very nice!

 

[sccrgoalie1]

Not sure if I should post this here or in a new thread, but I just pushed a commit to fix a save issue when navigating to different sections of the configuration as suggested by HomeY.

https://github.com/sccrgoalie1/MediaPortal-3/tree/Screensaver_Save_Fix