[Approved] Allow plugins as Screensavers (2 Viewers)

sccrgoalie1

Portal Pro
September 12, 2013
109
165
38
Home Country
United States of America United States of America
thanks, but you have update on master branch and not the good branch.
we can't import from master !
Please, only use branch dedicated for each change.
one branch = one change , more easy for Dev team to verify the code. ;)

Sorry, not sure I understand I created a separate branch in my fork called "Screensaver." That's the only spot where I've pushed my changes. I'm new to git, so sorry if this is a beginner mistake.
 

azzuro

Test Group
  • Team MediaPortal
  • May 10, 2007
    9,948
    5,617
    France - IDF
    Home Country
    France France
    one question : plugins should have special code inside, for to be detected as compatible plugins for screensaver, or all plugins can be set ?
     

    sccrgoalie1

    Portal Pro
    September 12, 2013
    109
    165
    38
    Home Country
    United States of America United States of America
    one question : plugins should have special code inside, for to be detected as compatible plugins for screensaver, or all plugins can be set ?
    The way it's built any plugin could be set as screensaver. I'm not sure it's necessary to build a whole separate special code for screensaver plugins, but if the team thinks we need this is could be done.
     

    azzuro

    Test Group
  • Team MediaPortal
  • May 10, 2007
    9,948
    5,617
    France - IDF
    Home Country
    France France
    was only for understand.
    because i'm affraid for users want use any plugins with it, and causing crash.
    but it's only supposition ...
    thank you for your reply
     

    sccrgoalie1

    Portal Pro
    September 12, 2013
    109
    165
    38
    Home Country
    United States of America United States of America
    was only for understand.
    because i'm affraid for users want use any plugins with it, and causing crash.
    but it's only supposition ...
    thank you for your reply
    Makes sense. There isn't any reason it would cause a crash as it launches the plugin just like it would be launched anywhere else. There is a chance a user would choose a plugin that doesn't do anything (to prevent screenburn etc) and therefore isn't a good candidate for a screensaver, but it's up to the users discretion.
     

    sccrgoalie1

    Portal Pro
    September 12, 2013
    109
    165
    38
    Home Country
    United States of America United States of America
    I discovered a minor bug in the configuration tool. How do I submit this fix now that it's a branch of Media Portal?

    Specifically, in the GuiScreensaver class this line:

    Code:
    xmlreader.SetValue("general", "IdlePluginWindow", loadedPlugins[pluginsComboBox.SelectedIndex].WindowId);

    Needs to change to this

    Code:
     if (loadedPlugins.Count > -1)
            {
              xmlreader.SetValue("general", "IdlePluginWindow", loadedPlugins[pluginsComboBox.SelectedIndex].WindowId);
            }
     

    Users who are viewing this thread

    Top Bottom