BASS Visualisation fix (1 Viewer)

[hwahrmann]

Here you will find a version based on 1.5 final which contains the Bass Visualisation fixes created by @BassFan.

Please test as much as possible and report errors here.

Thanks again to BassFan and Sebastii (for creating test versions and merge), who took the responsibility during my absence.

 

[CypherMK]

@hwahrmann @BassFan
If I understand correctly, bassfan also made some improvements with wasapi mode.

I tested the wasapi mode, but it still has some cracking noises. Easiest way to reproduce: Start some music, go to Now Playing. Then press X, and again and again and again..... you get my point. On my system I will get these cracking noises. I don't get them with bassplayer.

Should we make a new thread for this?

 

[edterbak]

Hi hwahrmann,

Here my logs.

Attention. My hardware is asus Xonar DX. From historical experiences more troublesome than std hardware.

Started MP. (debug mode + skin)
Started mp3 P!nk - Try
Pressed X for a while. (thanks for the tip @CypherMK)
Stuttered once in a while.

Hope you find this log usefull.

 

[BassFan]

FPS to slow
my fixed see picture 2
your fixed see picture 1

please check the new visExec FLAG! AMP_UseFakeWindow
high recommended set this flag to true
so do not use internal message Handler for WinampViz from MP

With this flag, the plugins and their Messages be completely decoupled from MediaPortal

see!
patch.. bring back W2 plugin support which destroyed after focus patch
and remark in WinampViz.cs // Create the Visualisation

or codebox..

 // REMARK NEWFLAG: AMP_UseFakeWindow
/* Set UseFakeWindow "TRUE" if you want to use a dedicated window which processes messages from vis plug-in.
(This is only to avoid any unexpected problem by using owner window's message handler.)
If UseFakeWindow is set "FALSE" then messages from vis plug-in are processed by the message handler
of the owner Application like Mediaportal.
Don't set UseFakeWindow to "TRUE", the window class name('Winamp v1.x') is used.
Do use UseFakeWindow Winamp2 Plugin with class name ('Winamp v1.x') no longer work.*/
 
// Create the Visualisation
BASSVIS_EXEC visExec = new BASSVIS_EXEC(VizPluginInfo.FilePath);
visExec.AMP_ModuleIndex = VizPluginInfo.PresetIndex;
visExec.AMP_UseOwnW1 = 1;
visExec.AMP_UseOwnW2 = 1;
visExec.AMP_UseFakeWindow = true;
BassVis.BASSVIS_ExecutePlugin(visExec, _visParam);
if (_visParam.VisHandle != 0)
{

after you has set this Flag then
set all Max Framerate in Milk2 Config Dialog to 60 FPS
and test it with Fraps or other Software which can show the framerate as Overlay.

all other work fine like resize in Windowmode and so on..

Realtec HD.. 2 Speaker
nothing Stuttered or cracking noises on Now Playing Window!
with and without Wasapi.

@CypherMK go to Now Playing
If I understand correctly, bassfan also made some improvements with wasapi mode.

i have nothing fixed on Now Playing only for BassPlayer!

@edterbak Pressed X for a while.

your hold the key?
LOL then you are start the Vis again, again, again.. your think this is OK?
i think not!

greets

 

[CypherMK]

@BassFan

Wenn du im now playing schirm bist, und dann auf die 'x' taste drückst, und das mehrmallst hintereinder machst (nicht eingedrückt halten), dann hört mann dieses geraüsch (WASAPI). Hoffe mein Deutsch ist zureichend, das du mich verstehst. haha

Dieses problem hat nichts zu tun mit visualisation.

----------------------------------------------------------------------------------------------------------------------

Wenn you are at the now playing screen and press the x button, and do this multiple times (not keeping it pressed), then you will hear this noise (WASAPI).

This has nothing to do with visualisation.

 

[BassFan]

@BassFan

Wenn du im now playing schirm bist, und dann auf die 'x' taste drückst, und das mehrmallst hintereinder machst (nicht eingedrückt halten), dann hört mann dieses geraüsch. Hoffe mein Deutsch ist zureichend, das du mich verstehst. haha

Dieses problem hat nichts zu tun mit visualisation.

i understand you
i mean this message

@edterbak Pressed X for a while.

not your

i do the same as you

Start some music, press Z and go to Now Playing. Then press X, and again and again and again..
i can not reproduce this mistake sound ok by me..

This has nothing to do with visualisation.

I think that does a lot with the visualization
then when press X Button Visualization going to Fullscreen
is a bad idea start Viz again, again and again

if so then your message should moved to other place..

greets

 

[CypherMK]

i understand you
i mean this message

not your

i do the same as you

Start some music, press Z and go to Now Playing. Then press X, and again and again and again..
i can not reproduce this mistake sound ok by me..


I think that does a lot with the visualization
then when press X Button Visualization going to Fullscreen
is a bad idea start Viz again, again and again


greets

Oh I forgot to mention that I disabled Viz!

 

[BassFan]

Oh I forgot to mention that I disabled Viz!

yes then your Mistake do nothing with this thread..
should be moved on other place.

please test it with Visualization ON.. like me

greets

 

[CypherMK]

yes then your Mistake do nothing with this thread..
should be moved on other place.

please test it with Visualization ON.. like me

greets

But just to make this clear: did you change code to make wasapi work better?

 

[BassFan]

yes then your Mistake do nothing with this thread..
should be moved on other place.

please test it with Visualization ON.. like me

greets

But just to make this clear: did you change code to make wasapi work better?

i think @hwahrmann do it if necessary.
Thank you for mistake report to

i have test it without Viz and Wasapi my sound is OK.

greets