[fixed] - BassPlayer bug | Page 6

Discussion in '1.4.0 Pre-Release' started by l337, May 18, 2013.

  1. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs
    Does skip step works on the same button as FF/REW (TOPBER/Remote etc.) when option is checked. ?
    I can't test right now but if yes, maybe remove it / change wiki and hide this option and enable it by default is the good way to do :)
    But why it was working before the rework and why wasapi is ok ? (just question :) )


     
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. hwahrmann
    • Team MediaPortal

    hwahrmann Development Group

    Joined:
    September 15, 2004
    Messages:
    4,503
    Likes Received:
    1,641
    Gender:
    Male
    Location:
    Vienna, Austria
    Ratings:
    +2,271 / 1
    Home Country:
    Austria Austria
    Yes, it works with the same buttons.


    WASAPI doesn't rely on the buffer. it works more direct with the device.

    The whole BASS rework made the player much more stable and introduced new features, like WASAPI.
    I don't want to make now any changes just because of the REW.
    In fact using a lower buffer would work anyhow.

    We were having skip steps in versions pre 1.2 only and then someone decided that he would like to have FF / REW the same way like on a DVD player. for whatever reason.
     
    • Like Like x 1
  4. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    So @hwahrmann

    based on testing, do you feel that

    - 0004463: [Music] Wrong error message on thumbs create during music folder scan (hwahrmann) - ready for testing.
    - 0004466: [Music] FF and REW produces wrong result wiith standard BASS Player (hwahrmann) - ready for testing.
    - 0004451: [Music] GetStreamTags() has been removed as part of BASS Rework by accident (hwahrmann) - ready for testing.

    are all safe and ready to merge?
     
  5. hwahrmann
    • Team MediaPortal

    hwahrmann Development Group

    Joined:
    September 15, 2004
    Messages:
    4,503
    Likes Received:
    1,641
    Gender:
    Male
    Location:
    Vienna, Austria
    Ratings:
    +2,271 / 1
    Home Country:
    Austria Austria
    yes.
    i'd like to do a small test on 4466 tomorrow.
    late afternoon i should know if it is ok.
     
    • Like Like x 3
  6. jameson_uk
    • Premium Supporter

    jameson_uk Retired Team Member

    Joined:
    January 27, 2005
    Messages:
    7,258
    Likes Received:
    2,228
    Gender:
    Male
    Occupation:
    Data Warehousing Consultant
    Location:
    Birmingham
    Ratings:
    +2,405 / 0
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    @hwahrmann could you just explain what
    Code (C):
    1.         TimeSpan ts = DateTime.Now - _seekUpdate;
    2.         if (_speed > 1 && ts.TotalMilliseconds > 120)
    3.         {
    4.           SeekForward(80 * _speed);
    5.           _seekUpdate = DateTime.Now;
    6.         }
    7.         else if (_speed < 0 && ts.TotalMilliseconds > 120)
    8.         {
    9.           SeekReverse(80 * -_speed);
    10.           _seekUpdate = DateTime.Now;
    11.         }
    12.       }
    does.
    Is the TimeSpan just to prevent skipping too often? (so if it has been last than 120 seconds since process was last called then this gets ignored?)

    In terms of REW would it work if we added ts.TotalMilliseconds to the value passed to SeekReverse ?
    else without this if Process is called every 20 ms then the skip would be called every 7 calls so ts.TotalMiilliseconds = 140 and if you are running at 2x REW then we are currently trying to seek to 80 * -2 = -160 ms but we have jumped forward 160 ms so the net result is we are basically back where we started ??
     
    • Like Like x 1
  7. hwahrmann
    • Team MediaPortal

    hwahrmann Development Group

    Joined:
    September 15, 2004
    Messages:
    4,503
    Likes Received:
    1,641
    Gender:
    Male
    Location:
    Vienna, Austria
    Ratings:
    +2,271 / 1
    Home Country:
    Austria Austria
    Unfortunatley / Fortunatley this code is not from me. :)
    The timespan is there to prevent skipping to often.
    I am looking already into a way, like you described in your above post.
    I have now about 2 hours time and will sort that out.
     
    • Like Like x 2
  8. hwahrmann
    • Team MediaPortal

    hwahrmann Development Group

    Joined:
    September 15, 2004
    Messages:
    4,503
    Likes Received:
    1,641
    Gender:
    Male
    Location:
    Vienna, Austria
    Ratings:
    +2,271 / 1
    Home Country:
    Austria Austria
    Using the suggestions given by Mike above solved the issue.
    Changes have been commited to the branch. Please test and let me know, so that it can be merged to master.
     
    • Like Like x 2
  9. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs
    Solved also for me :)
     
  10. hwahrmann
    • Team MediaPortal

    hwahrmann Development Group

    Joined:
    September 15, 2004
    Messages:
    4,503
    Likes Received:
    1,641
    Gender:
    Male
    Location:
    Vienna, Austria
    Ratings:
    +2,271 / 1
    Home Country:
    Austria Austria
    So it can be merged. Right?
     
    • Agree Agree x 1
  11. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs
    I think yes :)
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!