Blow WindowPlugins.dll to separate plugin DLLs (5 Viewers)

[azzuro]

sorry, i have writte too fast

i have used " reinstall function" in deploy tool.
1.6 blowwindows branch --- Reinstall --- > MP1.6 Final

All Dll created with your version, was not deleted. MyVideo.dll / GuiHome.dll / ...

but i think, it's due to "reinstall" deploy tool

 

[Sebastiii]

Normally it should be deleted (i think) on upgrade from nsis, we just need to be sure that in setup.nsi files are removed.

 

[azzuro]

upgrade from nsis,

Upgrade, maybe

but Reinstall ???

 

[Sebastiii]

Strange it should be deleted

  Delete "$MPdir.Plugins\Windows\Dialogs.dll"
  Delete "$MPdir.Plugins\Windows\GUIDisc.dll"
  Delete "$MPdir.Plugins\Windows\GUIDVD.dll"
  Delete "$MPdir.Plugins\Windows\GUIHome.dll"
  Delete "$MPdir.Plugins\Windows\GUIMusic.dll"
  Delete "$MPdir.Plugins\Windows\GUINumberPlace.dll"
  Delete "$MPdir.Plugins\Windows\GUIPictures.dll"
  Delete "$MPdir.Plugins\Windows\GUIRSSFeed.dll"
  Delete "$MPdir.Plugins\Windows\GUISettings.dll"
  Delete "$MPdir.Plugins\Windows\GUITetris.dll"
  Delete "$MPdir.Plugins\Windows\GUITopbar.dll"
  Delete "$MPdir.Plugins\Windows\GUIWeather.dll"
  Delete "$MPdir.Plugins\Windows\GUIVideos.dll"
  Delete "$MPdir.Plugins\Windows\GUIWikipedia.dll"

Maybe it's @ wrong place in .nsi

 

[Sebastiii]

upgrade from nsis,

Upgrade, maybe

but Reinstall ???

Need to tweak that

 

[azzuro]

don't search, i have understand

this code above is in BlowWindow installer, but not in MP1.6 Final, and all files availables in the folder Plugins/windows/ and related to BlowWindows change, are not written in MP 1.6 final isntaller, so, it don't know, what it must delete.

YEAAAHHH , so it's not a bug

 

[seco]

Normal MP uninstaller is bad in my opinion, especially for testing. Even with complete uninstall I delete all MP folders always manually

But of course we need to test normal uninstall too, even though I dont think it works properly since there is always leftovers

 

[azzuro]

i watch movie since 2h, without issue with your branch !

 

[azzuro]

@Sebastiii can you post the installer with 1.6

 

[Sebastiii]

[14-01-10 18:05:14] Link: http://tinyurl.com/mqjfv6t