Bugs and improvements (incl. themes) (4 Viewers)

[ge2301]

Thanks! I found the reason. At the same time I also changes the weather icon layout as in Win10 theme.
Because I can not see the icons , could you exchange the 2 files in TE folder with attached ones. It would be fine now

 

[hofi]

Now its OK[DOUBLEPOST=1457783627][/DOUBLEPOST]

 

[morpheus_xx]

• <Label x:Name="ProgramStart" Margin="10,0,0,0" Color="{ThemeResource TextColor}" VerticalAlignment="Center"

• Content="{Binding [StartTime]}" FontSize="{ThemeResource SmallFontSize}"/>

• <Label Margin="5,0,5,0" Content="—" Color="{ThemeResource TextColor}" VerticalAlignment="Center" />

• <Label x:Name="ProgramEnd" Content="{Binding [EndTime]}" VerticalAlignment="Center" Margin="0,0,10,0"

Color="{ThemeResource TextColor}" FontSize="{ThemeResource SmallFontSize}" />

It should also work to use a MultiBinding for Label.Content to combine different items in one string, like https://github.com/MediaPortal/Medi...screens/SlimTvClient-extschedule.xaml#L37-L40.

The ConverterParameter should look like "{}{0}+{1}+{2}" (I think), with Binding "[StartTime]", " - ", "[EndTime]"

 

[ge2301]

It's not working so far, the column remains empty un-/focused. I've checked the model and "+" seems also correct: https://github.com/MediaPortal/Medi...nverters/ExpressionMultiValueConverter.cs#L39

      <Label x:Name="ProgramStartEnd" Margin="10,0,0,0"  Color="{ThemeResource TextColor}" VerticalAlignment="Center"
             FontSize="{ThemeResource SmallFontSize}">
        <Label.Content>
          <MultiBinding Converter="{StaticResource ExpressionMultiValueConverter}" ConverterParameter="{}{0}+{1}+{2}">
            <Binding Path="{Binding [StartTime]}"/>
            <Binding Path=" — "/>
            <Binding Path="{Binding [EndTime]}"/>
          </MultiBinding>
        </Label.Content>
      </Label>

 

[morpheus_xx]

<Binding Path="{Binding [StartTime]}"/>

This is not correct: the "<Binding>" equals to "{Binding ...}", so it's duplicated.
I think it should be <Binding Path="[StartTime]"/> (not sure though, I also always look for other code examples )
And the literal should probably be: <Binding Source=" - "/>

 

[ge2301]

It's working!

Same problem in footer. Here actually 2 converters have to be considered, not sure how to do it. I tried following, but it was unsuccessful:

            <Label x:Name="ProgramStartEnd" HorizontalAlignment="Right"
                   Margin="-150,0,0,0" Color="{ThemeResource TextColor}" FontSize="{ThemeResource SmallFontSize}">
              <Label.Content>
                <MultiBinding Converter="{StaticResource ExpressionMultiValueConverter}" ConverterParameter="{}{0}+{1}+{2}">
                  <Binding Path="StartTime" Converter="{StaticResource SlimTvDateFormatConverter}"/>
                  <Binding Source=" — "/>
                  <Binding Path="EndTime" Converter="{StaticResource SlimTvDateFormatConverter}"/>
                </MultiBinding>
              </Label.Content>
            </Label>

Putting another {...} around was also not possible. Google did not help.
So I need another hint

 

[ge2301]

@morpheus_xx

The description label in the GroupMenu bar is showing every single headline of an active screen.
In many cases this is not intended. The idea was actually, that just the 2 top level are shown here "Group Name" and "Tile Name".
E.g. Videohub is focussed -> "Video" is shown. After selecting the Movies Tile "Movies" is shown. if movies are filtered or something else is done the description label should allways show "Movies" never going deeper. Can that be changed?

Here an example:

 

[morpheus_xx]

The description label in the GroupMenu bar is showing every single headline of an active screen.

This is intentional, the LastSelectedItemName is set for 2 different cases:

• In "Home" state the Group name
• In all other States the Workflow's Display name. If we wouldn't do this, there would be no indicator for current screen i.e. when browsing MediaLibrary

One idea though, we might exclude Dialog states from the 2nd feature...

 

[ge2301]

This is intentional, the LastSelectedItemName is set for 2 different cases:

• In "Home" state the Group name
• In all other States the Workflow's Display name. If we wouldn't do this, there would be no indicator for current screen i.e. when browsing MediaLibrary

One idea though, we might exclude Dialog states from the 2nd feature...

There are several cases where it's not working as expected. Partly also the "filter commands" remain here after setting a filter.
I'll take some screenshots and colleact some cases.

Main problem I see in BV Default and Default Large themes, the space is not enough, the text is cut after one words and some texts are long.

 

[ge2301]

@morpheus_xx
I closed meanwhile almost all points, which were posted here as "bug" and additional points I found by byself.
I put a (done) behind every closed point.

Open:
1) Next Program: https://forum.team-mediaportal.com/threads/bugs-and-improvements.132233/page-4#post-1177566

I can implement it, but it makes only sense with headlines. I'd need your help or guide to add new strings into transiflex for translation. I have no idea about it. I add those thrings to the strings_en.xml in SlimTv language folder and then? New strings are marked by red in attached image

      <Label Grid.Column="2" Grid.Row="0" x:Name="CurrentProgramLabel" Margin="5,4,0,4"
             Content="{Binding Programs[0].Program.Title}" FontSize="{ThemeResource SmallFontSize}"
             Color="{ThemeResource TextColor}"/>
      <Label Grid.Column="2" Grid.Row="0" x:Name="NextProgramLabel" Margin="5,4,0,4"
             Content="{Binding Programs[0].NextProgram.Title}" FontSize="{ThemeResource SmallFontSize}"
             Color="{ThemeResource TextColor}"/>

Programs[0].NextProgram.Title does not work​

2) Currently Playing

Unfortunately I realized still problems with the CP screen.

Unfortunately a long standing issue which I couldn't solve yet
I

I think we can not make a release without fixing this. There is a chance to not safely reach the player controls, that would make MP2 unusable and give a bad impression.​

3) Question, if we can consider the slide-in menus also for BV to improve navigation with keyboard