Call for tester for 1.4.0 features and fixes (2 Viewers)

Status
Not open for further replies.

Scythe42

Retired Team Member
  • Premium Supporter
  • June 20, 2009
    2,065
    2,703
    51
    Berlin
    Home Country
    Germany Germany
    New build attached to first post.
    • TS playback should be fine now again
    • Added a grace period for the refresh rate changer of 250ms to avoid a minimizing to tray.
    Please test if these issues are fixed and what other you might encounter.

    Sure it was me. No doubt about that one... :cry: As I don't watch TV and therefore don't play any TS files I never noticed it got broken for quite some time now.

    Off to break some more stuff :D. Maybe just Radio this time. Don't listen to it either. Only Pandora. Anything with commercials is a no go for me.
     
    Last edited:

    chrissnow

    Portal Pro
    January 21, 2011
    50
    3
    Nottingham
    Home Country
    United Kingdom United Kingdom
    Great news :)
    Will test it later, is it in GIT? I only ask as without merging DJBlu's EPG mods I wont be allowed to test it on the TV ;)
     
    Last edited:

    Scythe42

    Retired Team Member
  • Premium Supporter
  • June 20, 2009
    2,065
    2,703
    51
    Berlin
    Home Country
    Germany Germany
    I need to sort out my current local commit history (lot of temporary stuff) before I push it to github. Branch is: EXP-Windows-7-Half-Full-Screen
     
    Last edited:

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    I spotted on change that will cause regression:

    Code:
    -	Thread.CurrentThread.Name = "MPMain"; 
    +	Thread.CurrentThread.Name = "MediaPortal";

    It will break the BaseTSReaderPlayer.cs in

    Code:
    if (_ireader != null && Thread.CurrentThread.Name == "MPMain")
    {		
      _ireader.SetMediaPosition((long)(_streamPos * 10000000d));
    }
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    It will also break other Plugins that rely on the Name of that thread like OnlineVideos.

    In generally it would be good to use the thread id instead of the thread name which is usually used for the debugging aid. But to not to make regression then it might be safer to rename the thead back as we don't know what additional plugins are going to break.
     

    infinite.loop

    Retired Team Member
  • Premium Supporter
  • December 26, 2004
    16,163
    4,133
    127.0.0.1
    Home Country
    Austria Austria
    With the new build I can play *.ts files again. (y)

    Still have the "blackscreen" issue after the fullscreensplashscreen is gone (did you have time for that additional logging? :) ), and MP still miminizes when I play a video that triggers a RR change.
    Attached logs contain both.
     

    Attachments

    • minimize.zip
      21.3 KB
    Last edited:

    Scythe42

    Retired Team Member
  • Premium Supporter
  • June 20, 2009
    2,065
    2,703
    51
    Berlin
    Home Country
    Germany Germany
    @infinite.loop: I'll need to add some more debug code to find out where the delay is coming from and why the RR change still steals focus. Do you use stock RR changer or do you call any external programs in addition?
     
    Status
    Not open for further replies.

    Users who are viewing this thread

    Top Bottom