Call for tester for 1.4.0 features and fixes (2 Viewers)

[Scythe42]

While checking for issues with btweb, I did notice in MP 1.4 that command line parameters weren't parsed. Is this correct?
I have /fullscreen and /screen=1, but neither of them had any influence on screen selection/window size

Yep, broke 'em. Will fix 'em. Thanks for pointing out.

I moved their default init values to the constructor of D3D. But the D3D object is initialized after the attributes have been set. It's an easy fix that will be in the next build.

Edit: Fixed and pushed to Git.

 

[disaster123]

Mhm minidisplay always works if i enable extensive logging - race condition? No time to get the SystemEvent in thread whithout logging?

Yep, race condition.

...


What you could try:

• Remove the " msg.Result = (IntPtr)1;" at the end of "case WM_POWERBROADCAST:", that should be right at the top of WndProc() in MediaPortal.cs
• Add a "thread.sleep(1000)" to OnSuspend() in MediaPotal.cs with the intent of the MP form not shutting down too quickly as a test case. That would delay the return code in regards to WM_POWERBROADCAST.

Let me know how these two things work out.

Sadly it does not help at all.

$ git diff
WARNING: terminal is not fully functional
diff --git a/mediaportal/MediaPortal.Application/MediaPortal.cs b/mediaportal/MediaPortal.Applicatio
index 3e24cf8..05efea2 100644
--- a/mediaportal/MediaPortal.Application/MediaPortal.cs
+++ b/mediaportal/MediaPortal.Application/MediaPortal.cs
@@ -1121,7 +1121,7 @@ public class MediaPortalApp : D3D, IRender
			   OnResume();
			   break;
		   }
-		  msg.Result = (IntPtr)1;
+		  // msg.Result = (IntPtr)1;
		   break;

		 // set maximum and minimum form size in windowed mode
@@ -1606,7 +1606,9 @@ public class MediaPortalApp : D3D, IRender
	   Log.Debug("Suspending is already in progress");
	   return;
	 }
-	_suspending = true;
+	_suspending = true;
+
+	Thread.Sleep(1000);

	 if (!_suspended)
	 {
(END)

 

[Scythe42]

Was worth a try. Need to be fixed on the MiniDisplay code side. Out of scope for this work.

Edit:
Just hand another idea: add a "PluginManager.WndProc(ref msg)" call before the OnSuspend() call in WndProc() of Mediaportal.cs.

case PBT_APMSUSPEND:
  Log.Info("Main: Suspending operation.");
  PluginManager.WndProc(ref msg);
  OnSuspend();
  break;

Let me know if this does the trick for you.

 

[FreakyJ]

@Scythe42
If you need some raw TS dumps for the dummy BDA driver let me know, I can create some for you
It just came to my mind that it would be useless for you without such^^

 

[Scythe42]

Thanks, but don't have the bandwidth to download them...

 

[FreakyJ]

I can give you RDP access to my system if you want to
But I think also for this the bandwidth is to low :/ So if I can help you in any way let me know, this is my last week where I have free

 

[Scythe42]

If you can reproduce the zapOSD (meaning generating an exception) issue on demand that would be helpful. Currently don't have much time, so this one is something for the weekend.

 

[FreakyJ]

hmm sorry, not able to reproduce it at all, here it is working fine...

Currently don't have much time, so this one is something for the weekend.

take your time

 

[Scythe42]

Everyone who is seeing this error in his log when zapping channels:

[2013-04-02 16:10:35,998] [Error  ] [MPMain  ] [ERROR] - OnMessage exception:System.NullReferenceException: Object reference not set to an instance of an object.
  at MediaPortal.GUI.Library.GUITextControl.SetText(String strText)
  at MediaPortal.GUI.Library.GUITextControl.set_Label(String value)
  at TvPlugin.TvZapOsd.ShowPrograms()
  at TvPlugin.TvZapOsd.SetCurrentChannelLogo()
  at TvPlugin.TvZapOsd.OnPageLoad()
  at MediaPortal.GUI.Library.GUIWindow.OnMessage(GUIMessage message)

Can you please try the attached build?

It logs more stuff about variables and where we are in the SetText() method as I can not remotely debug over the Internet. Tons of lines in the logs but this is for narrowing it down.

When reproducible for you, please also test if this happens on all skins (e.g. Titan vs. Default Wide). My gut tells me we don't have a proper font object here.

This is the first in a couple of test until I found the exact circumstances when the problems surfaces, followed by a fix.

@elliottmc: error was from your log, so please test as well? Thx.

Edit:
Just to elaborate my gut feeling:

From Titan's tvZapOSD.XML

<control>
	<description>On tv NEXT</description>
	<id>37</id>
	<type>textbox</type>
	<width>900</width>
	<height>37</height>
	<posX>-2000</posX>
	<posY>642</posY>
	<align>left</align>
	<font>font13</font>
	<textcolor>FFB2D4F5</textcolor>
</control>

And from the logs:

[2013-04-02 16:01:48,719] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\debug_12.dds
[2013-04-02 16:01:48,919] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\font2_20.dds
[2013-04-02 16:01:49,459] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\font10_18.dds
[2013-04-02 16:01:49,751] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\font11_20.dds
[2013-04-02 16:01:50,396] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\font12_21.dds
[2013-04-02 16:01:50,990] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\font14_25.dds
[2013-04-02 16:01:51,536] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\font22_40.dds
[2013-04-02 16:01:53,673] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\fontB11_20.dds
[2013-04-02 16:01:54,251] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\fontB12_21.dds
[2013-04-02 16:01:54,805] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\fontB14_25.dds
[2013-04-02 16:01:55,947] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\fontB16_29.dds
[2013-04-02 16:01:57,071] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\fontB20_36.dds
[2013-04-02 16:01:59,291] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\TitanLight10_18.dds
[2013-04-02 16:01:59,601] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\TitanLight11_20.dds
[2013-04-02 16:02:00,246] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\TitanLight12_21.dds
[2013-04-02 16:02:00,807] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\TitanLight14_25.dds
[2013-04-02 16:02:01,369] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\TitanLight16_29.dds
[2013-04-02 16:02:02,476] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\TitanLight20_36.dds
[2013-04-02 16:02:03,678] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\TitanLight22_40.dds
[2013-04-02 16:02:05,839] [Log	] [MPMain ] [DEBUG] - TextureLoader.CreateFile C:\ProgramData\Team MediaPortal\MediaPortal\Cache\Titan\fonts\TitanLight32_58.dds

As you can see: no "font13" was loaded. @ncoH: is font13 correct or is it a typo in the skin file?

When you can reproduce the problem, please edit the ZapOSD xml and change font13 to font12 and check if the issue is still there.

Edit: Build removed - as gut feeling was confirmed

 

[FreakyJ]

here we go, it is reproducible with the titan skin, BlackGlass doesn't have this issue
I started MP, selected a channel and pressed 5 than closed MP
With BlackGlass it worked, with titan it doesn't

Logs attached