Call for tester for 1.4.0 features and fixes (3 Viewers)

[Scythe42]

sure!
how it should look like:
View attachment 125906

how it shouldn't

View attachment 125907

Interesting. Looks like the correct font but the size is wrong. Logs don't show anything that is different in regarding to loading fonts when the skin is changed.

All in all it must be something OnSkinChanged() in GUISettingsGUI_Skin.cs is doing or better not doing. Some stuff is not properly reset.

Regarding the D3D error. I made the following change that should prevent the issue:

		  // prevent MP from rendering when resource are disposed during live changing of a skin
		  lock (GUIGraphicsContext.RenderLock)
		  {
			OnSkinChanged();
		  }

I just locked the rendering during skin change. The exception you saw was caused by the fact that MP tried to render before all resource were reloaded. Bug in GUISettingsGUI_Skin.cs. The locking hopefully does the trick.

This in theory could fix the above one if it is related to some source not being available. Please do a test with the next build.


There is also one more bug, the mouse cursor does not show right away after switching skins. Only after you move the mouse, wait for cursor hiding and move it again it will be shown. That's one more imbalance of mouse cursor hiding showing inside MP. Fixed a lot of them, but a few remain. It is at least consistent at the moment.

But changing the skin does not happen that often, so out of scope for this rework. Needs to be done on the GUISetting side anyway.

There are a few more mouse cursor glitches left I could not fix yet. We need to sort them out individually one by one in separate branches.

I think one issue is there when playback starts. It briefly shows the mouse cursor. But that was the case for me on stock 1.3.0 and before all the time. It might now be consistent and shows on all playbacks, which is a good thing as this mean it is reproducible on demand now.

 

[Scythe42]

Attached Build 18 to first post, plus changes for skin files regarding GUI Settings.

Let's consider this the official RC for this work. Meaning feature complete and now it's just about regressions.

Changelog:

• Fixed the exception with Configuration.exe (TVLibrary.Interfaces.dll was needed)
• Removed the option "restart MP on resume" (not needed anymore, MP resumes properly, XP hack for bad GPU drivers)
• Removed the option "turn on screen after resuming" (let Windows do this stuff, specific XP hack for malconfigured systems)
• Removed the option "hide taskbar in fullscreen mode" (workaround not needed anymore, remaining glitches need to be fixed if any)
• When changing skins over the GUI, no exception should happen anymore (locked the rendering thread during reloading of skin resources)
• When closing/preparing to exit MP, WndProc() for plugins is called (fix for Minidiplays not shutting down or other plugins)
• Fixed logging when a font requested by a skin file does not exist, will not log an error when requesting the default font
• Changed logging when a font requested by skin file does not exists from error to warning.

I hope I included all files that changed and are relevant. We'll find out if you get strange errors.

Please test any issues you had with Build 17 to verify they are gone and continue testing everything. I count on you guys.

 

[azzuro]

Doesn't that plugin require modified core.dll? Such shouldn't be EVER used when testing any new features / fixes.

I know, but have tested on my productive system, and forgot to disable all plugins, & the modified Core for atmolight don't add big function to Core, only add Capture from Directshow. (2-3 linecode) but can make BUG with MP.

- Zapping tv block to each change

- Steps to reproduce the first one? And cannot some with TV setup please test.

only change channel with P+ P- on my remote , nothing else, display block 2 sec (when OSD show) after nothing .

 

[FreakyJ]

only change channel with P+ P- on my remote , nothing else, display block 2 sec (when OSD show) after nothing .

really don't get your point oO Please be more precise what the issue is, maybe a screen capture if it is hard to describe...

 

[struppi21]

I made a short first test with build 18.

"Mediaportal Configurator" worked without exception.

But one new issue:
The option "Autostart MP on Windows startup" don't work anymore.

and one cosmetic issue:
"Fixed logging when a font requested..." works not for Configuration.exe
Please look at attached error.log.

 

[Scythe42]

The option "Autostart MP on Windows startup" don't work anymore.

Typo. Will fix right away an upload Build 18a.

:
"Fixed logging when a font requested..." works not for Configuration.exe
Please look at attached error.log.

That is actually OK. Configuration.exe loads some stuff from plugins, who in turn try to probably render some text (they should not do this...) And these fonts are of course not available in Connfiguration.exe, which has nothing to do with the skin engine.

This is then properly logged as a warning and the absence of the default font as an error, meaning there is no fallback.

Anyway, will suppress it if no fonts are loaded at all for cosmetic reasons.

Edit:
Added Build 18a to the first thread.

 

[elliottmc]

Tested with latest from GIT.

Configuration error log has

[2013-04-11 08:30:37,601] [Config ] [Config Main] [ERROR] - GUIFontManager: could load default font
[2013-04-11 08:30:37,601] [Config ] [Config Main] [ERROR] - GUIFontManager: could load default font
[2013-04-11 08:30:37,601] [Config ] [Config Main] [ERROR] - GUIFontManager: could load default font
[2013-04-11 08:30:37,601] [Config ] [Config Main] [ERROR] - GUIFontManager: could load default font
[2013-04-11 08:30:37,601] [Config ] [Config Main] [ERROR] - GUIFontManager: could load default font
[2013-04-11 08:30:37,601] [Config ] [Config Main] [ERROR] - GUIFontManager: could load default font
[2013-04-11 08:30:37,601] [Config ] [Config Main] [ERROR] - GUIFontManager: could load default font
[2013-04-11 08:30:37,601] [Config ] [Config Main] [ERROR] - GUIFontManager: could load default font
[2013-04-11 08:30:37,601] [Config ] [Config Main] [ERROR] - GUIFontManager: could load default font

and with Titan, MediaPortal log has

[2013-04-11 08:33:04,462] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name 'font13' does not exist
[2013-04-11 08:33:04,462] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name 'font13' does not exist
[2013-04-11 08:33:04,462] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name '-' does not exist
[2013-04-11 08:33:04,462] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name '-' does not exist
[2013-04-11 08:33:04,462] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name '-' does not exist
[2013-04-11 08:33:04,462] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name '-' does not exist
[2013-04-11 08:33:04,478] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name 'font13' does not exist
[2013-04-11 08:33:04,478] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name 'font13' does not exist
[2013-04-11 08:33:04,478] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name '' does not exist
[2013-04-11 08:33:04,478] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name '' does not exist
[2013-04-11 08:33:04,478] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name '' does not exist
[2013-04-11 08:33:04,478] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name '' does not exist
[2013-04-11 08:33:04,478] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name '' does not exist
[2013-04-11 08:33:04,478] [Log	] [7		] [WARN ] - GUIFontManager: Font with the name '' does not exist

Since the other issue with 'font13' I suspect these lines are correct and something need fixing. Perhaps the others are also in need of skin fixes?

Apart from that, everything else seems fine.

So, probably ready to merge, but someone else should make that call!

 

[Scythe42]

Titan log messages are OK. "font13" does not exist and neither does a font called "-". Fixed "font13" in GIT as well last night.

Strange we have an empty one in Titan. As the code actually checks for != null. Probably it is just an CR/LF or just a space that got trimmed (so pure cosmetic). Any warning means that the skinner referenced some font he did not include in the skin.

Configuration thingy is technically OK. Skin Engine related stuff is not loaded by Configuration.exe. But a plugin loaded by Configuration.exe does request it. Should not do it. Bad little plugin.

Anyway, to avoid confusion I just made one more adjustment in regards to GetFont a few minutes ago:

https://github.com/MediaPortal/MediaPortal-1/commit/b480552c602b82655943d2d1ef2d087e0c4e1524

Apart from that, everything else seems fine.
So, probably ready to merge, but someone else should make that call!

Let's give build 18a until Sunday, so more users have the chance to test it. There are for sure some minor glitches left. But can't be anything serious as most attention is a single log line at the moment. Users are really looking for anything, which is great!

On a side note: The GetFont actually does a render lock. Does not make much sense to me. I have to urge to remove this. Nah, not that late in the game. Does not hurt much as returning a reference to a font object should be a matter of a few ticks.

 

[radical]

Configuration is working now for me.
But I see a other problem. For me It's not possible to start MP on secondary screen.
After splashscreen it's switch from secondary to primary screen.

 

[struppi21]

Autostart is working fine, with build18a.

But I found another problem.
Sometimes mediaportal comes up at fullscreen but with no audio, after standby.

I have to close and restart it, to solve the problem.

I power on, tv and pc at the same time with my harmony remote.
Can it be a problem with my philips tv at power up?

Logs are attached, but no error log was written!

A other question:
My system starts sometimes with live tv in fullscreen mode
and sometimes at basic home.
What should it normally do?