Database: Refactor MP1 database for multi seat usage (2 Viewers)

[Anthony Vaughan]

I think it's easiest if you just push your changes to your fork of mediaportal.
That way everybody can easily see all the changes and optionally comment on that, and eventually merge it into master
Too bad you didn't do this earlier because the only option right now is probably one large commit instead of a more granular itemized set of commits.

I agree.

The issue for me is that my changes will mean that we will need to make sure that all of the extensions work with the new databases project. I expect that this will usually just require a recompile but it may sometimes need me to alter the databases project (but only in a minor way - adding or changing the odd method).

I think you will have to judge whether my code would be better introduced as a separate release from your standard releases. BTW, when is you next release scheduled for? I guess that will determine the practicality of adding my code then or later.

 

[doskabouter]

well, at the very least others can easily view the changes you did.
And for further changes you can add sensible commit messages.


I remember there is a system in place in mediaportal (https://www.team-mediaportal.com/wiki/display/MediaPortal1/Version+Compatibility) where you can version subsystems of it. That way (theoretically) it should make old plugins incompatible with the new database, but I'm not 100% sure that system is working correctly.
Also not sure if your changes are going to break every plugin that uses the updated databases.

 

[CyberSimian]

for 64 bit machines this is not so simple because %ProgramFiles% points to C:\Program Files\.

Yes, I have just looked at the value of %ProgramFiles% on 64-bit Windows 7, and it is:

C:\Program Files​

So Microsoft has actually changed its value in 64-bit Windows 10. What were they thinking?

The result is that one cannot rely on that environment variable to indicate the bitness of the operating system. It will be necessary to check first for the existence of "C:\Program Files (x86)". If that exists, that folder contains the Team MediaPortal folder to use as the destination. Otherwise it is "C:\Program Files" that contains the Team MediaPortal folder.

Apologies for suggesting a bad fix.

-- from CyberSimian in the UK

 

[doskabouter]

It depends on the bitness of the program asking for the env.vars
cmd (64bit) reports:

ProgramFiles=C:\Program Files
ProgramFiles(x86)=C:\Program Files (x86)

4nt (still my favorite command prompt alternative, 32bits) reports:

ProgramFiles=C:\Program Files (x86)
ProgramFiles(x86)=C:\Program Files (x86)

Edit: disclaimer: only tested in win7

 

[Anthony Vaughan]

I remember there is a system in place in mediaportal (https://www.team-mediaportal.com/wiki/display/MediaPortal1/Version+Compatibility) where you can version subsystems of it. That way (theoretically) it should make old plugins incompatible with the new database, but I'm not 100% sure that system is working correctly.
Also not sure if your changes are going to break every plugin that uses the updated databases.

Yes, I think that's the point as well. That's why I'm going to such lengths to make sure that you are ready to do this. I am confident about the changes as far as what I can see in the 1.29 release, but I don't know which extensions will be broken by the database changes. I guess someone will have to go through every one of them. I am happy yo take on any that need to be fixed, but I don't think I'm the best person to find out because I don't know what they are meant to do.

 

[Anthony Vaughan]

Apologies for suggesting a bad fix.

No problem. AJS gave me the code so the batch file in my latest release should work. Please let me know if it doesn't.

 

[Anthony Vaughan]

I am loath to send you the completed work until I have tested the stacked setup, and I don't know how to do that. Could someone post at least two files that are a proven example of stacking? Even edited down files (say, of 5-10 minutes of video) would suffice. The reason I ask is because I really don't know what goes on there and how MP handles that case. I'll be able to work it out once I've run MP against the stacked files.

I need to work with this so I can see whether I need to reflect that a video is a stacked setup, in the database. Doing the database changes won't take me long and, if I think it is the right thing to do, now is the time to do it. The code is a bit obscure, to say the least, so I cannot work out why it's doing what it does from the code alone .

 

[ajs]

Could someone post at least two files that are a proven example of stacking?

Take any video file, make three copies of it with names:
The Thing (1982) CD1.mkv
The Thing (1982) CD2.mkv
The Thing (1982) CD3.mkv
And import it into MyVideo

 

[Anthony Vaughan]

And import it into MyVideo

Where is MyVideo. I doesn't seem to appear in my extension list and it might need to be upgraded. Where can I get the code?

 

[ajs]

MyVideo - standart MP1 plugin for Video files